Subject: bug#50160: 28.0.50; Wrong NSToolbarItem identifier

From: tsuucat <[email-masked]>
Date: Sun, 22 Aug 2021 11:32:05 +0900

Emacs version: 28.0.50
window system: ns

EmacsToolbar now uses [img hash] as NSToolbarItem’s identifier
(see addDisplayItemWithImage in src/nsmenu.m).

This is not good because this causes conflict.
For example, “close” icon is used as `kill-this-buffer' by default but
isearch-tool-bar-map uses “close” icon as `isearch-cancel’.
addDisplayItemWithImage reuses NSToolbarItem which has same 
identifier so when in isearch “close” icon on toolbar doesn’t work.

I’m not a Objective-C expert so I don’t know what value should be set
as correct identifier... 🙇

--
tsuucat