GNU bug report logs - #50137
Mark page navigation commands as repeatable

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50137 in the body.
You can then email your comments to 50137 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Davide Masserut <dm <at> mssdvd.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Mark page navigation commands as repeatable
Date: Fri, 20 Aug 2021 16:23:05 +0200

[Message part 1 (text/plain, inline)]

Hi, I made a patch that allows to navigate through pages using
repeat-mode.

[0001-Mark-page-navigation-commands-as-repeatable.patch (text/x-patch, inline)]

From 061dded6ea68a641cc172f37d721556044c2ff6b Mon Sep 17 00:00:00 2001
From: Davide Masserut <dm <at> mssdvd.com>
Date: Fri, 20 Aug 2021 15:29:13 +0200
Subject: [PATCH] Mark page navigation commands as repeatable

* doc/emacs/basic.texi (Repeating): Document page navigation
repeatability

* lisp/bindings.el (page-navigation-repeat-map): Add new map
---
 doc/emacs/basic.texi | 17 +++++++++--------
 lisp/bindings.el     | 11 +++++++++++
 2 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/doc/emacs/basic.texi b/doc/emacs/basic.texi
index ba8d822b18..88e2777515 100644
--- a/doc/emacs/basic.texi
+++ b/doc/emacs/basic.texi
@@ -887,15 +887,16 @@ Repeating
 subsequent @kbd{z} repeats it once again.
 
 @findex repeat-mode
-  Also you can activate @code{repeat-mode} that temporarily enables
-a transient mode with short keys after a limited number of commands.
+  Also you can activate @code{repeat-mode} that temporarily enables a
+transient mode with short keys after a limited number of commands.
 Currently supported shorter key sequences are @kbd{C-x u u} instead of
 @kbd{C-x u C-x u} to undo many changes, @kbd{C-x o o} instead of
 @kbd{C-x o C-x o} to switch several windows, @kbd{C-x @{ @{ @} @} ^ ^
 v v} to resize the selected window interactively, @kbd{M-g n n p p} to
-navigate @code{next-error} matches.  Any other key exits transient mode
-and then is executed normally.  The user option @code{repeat-exit-key}
-defines an additional key to exit this transient mode.  Also it's
-possible to break the repetition chain automatically after idle time
-by customizing the user option @code{repeat-exit-timeout} to a number
-of seconds.
+navigate @code{next-error} matches, @kbd{C-x ] ] [ [} to navigate
+through pages.  Any other key exits transient mode and then is
+executed normally.  The user option @code{repeat-exit-key} defines an
+additional key to exit this transient mode.  Also it's possible to
+break the repetition chain automatically after idle time by
+customizing the user option @code{repeat-exit-timeout} to a number of
+seconds.
diff --git a/lisp/bindings.el b/lisp/bindings.el
index 0345944894..b67c6ad638 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -1434,6 +1434,17 @@ ctl-x-map
 
 (define-key ctl-x-map "[" 'backward-page)
 (define-key ctl-x-map "]" 'forward-page)
+
+(defvar page-navigation-repeat-map
+  (let ((map (make-sparse-keymap)))
+    (define-key map (kbd "]") #'forward-page)
+    (define-key map (kbd "[") #'backward-page)
+    map)
+  "Keymap to repeat page navigation key sequences.  Used in `repeat-mode'.")
+
+(put 'forward-page 'repeat-map 'page-navigation-repeat-map)
+(put 'backward-page 'repeat-map 'page-navigation-repeat-map)
+
 (define-key ctl-x-map "\C-p" 'mark-page)
 (define-key ctl-x-map "l" 'count-lines-page)
 (define-key ctl-x-map "np" 'narrow-to-page)
-- 
2.33.0

[Message part 3 (text/plain, inline)]

-- 
Davide Masserut

Message #8 received at 50137 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Davide Masserut <dm <at> mssdvd.com>
Cc: 50137 <at> debbugs.gnu.org
Subject: Re: bug#50137: Mark page navigation commands as repeatable
Date: Fri, 20 Aug 2021 17:50:03 +0200

Davide Masserut <dm <at> mssdvd.com> writes:

> Hi, I made a patch that allows to navigate through pages using
> repeat-mode.

Thanks; looks good to me, so I've pushed it to Emacs 28.

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 50137 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Davide Masserut <dm <at> mssdvd.com>
Cc: 50137 <at> debbugs.gnu.org
Subject: Re: bug#50137: Mark page navigation commands as repeatable
Date: Fri, 20 Aug 2021 18:09:55 +0200

Davide Masserut <dm <at> mssdvd.com> writes:

>> This change was small enough to apply without assigning copyright to the
>> FSF, but for future patches you want to submit, it might make sense to
>> get the paperwork started now, so that subsequent patches can be applied
>> speedily. Would you be willing to sign such paperwork?
>
> Sure!

Great!  Here's the form to get started:


Please email the following information to assign <at> gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]
Emacs

[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]

[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]

[For the copyright registration, what country are you a citizen of?]

[What year were you born?]

[Please write your email address here.]

[Please write your postal address here.]

[Which files have you changed so far, and which new files have you written
so far?]

Message #16 received at 50137 <at> debbugs.gnu.org (full text, mbox):

From: Davide Masserut <dm <at> mssdvd.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 50137 <at> debbugs.gnu.org
Subject: Re: bug#50137: Mark page navigation commands as repeatable
Date: Fri, 20 Aug 2021 18:06:56 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Thanks; looks good to me, so I've pushed it to Emacs 28.
Great!

> This change was small enough to apply without assigning copyright to the
> FSF, but for future patches you want to submit, it might make sense to
> get the paperwork started now, so that subsequent patches can be applied
> speedily. Would you be willing to sign such paperwork?

Sure!

-- 
Davide Masserut

Message #19 received at 50137 <at> debbugs.gnu.org (full text, mbox):

From: Davide Masserut <dm <at> mssdvd.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 50137 <at> debbugs.gnu.org
Subject: Re: bug#50137: Mark page navigation commands as repeatable
Date: Fri, 20 Aug 2021 18:15:37 +0200

Thanks!
-- 
Davide Masserut

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.