Subject: bug#50135: closed (Re: [bug#50135] [PATCH core-updates-frozen] gnu: appstream-glib: Fix failing tests.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 20 Aug 2021 19:08:01 +0000

Your bug report

#50135: [PATCH core-updates-frozen] gnu: appstream-glib: Fix failing tests.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
50135: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50135
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#50135] [PATCH core-updates-frozen] gnu: appstream-glib: Fix failing tests.
From: Leo Famulari <[email-masked]>
To: Maxime Devos <[email-masked]>
Cc: [email-masked]
Date: Fri, 20 Aug 2021 15:07:09 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

On Fri, Aug 20, 2021 at 03:55:26PM +0200, Maxime Devos wrote:
> * gnu/packages/glib.scm
>   (appstream-glib)[arguments]<#:phases>{set-home}: Set the $HOME
>   environment variable.

Thanks! As discussed on #guix IRC, I changed it to use /tmp instead of
(getcwd), and pushed as a24631a6dfc765c1e4e3f56cca51bd12672e8726.

Subject: [PATCH core-updates-frozen] gnu: appstream-glib: Fix failing tests.
From: Maxime Devos <[email-masked]>
To: [email-masked]
Cc: Maxime Devos <[email-masked]>
Date: Fri, 20 Aug 2021 15:55:26 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/glib.scm
  (appstream-glib)[arguments]<#:phases>{set-home}: Set the $HOME
  environment variable.
---
 gnu/packages/glib.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
index ae88dbe9e7..b382d530d8 100644
--- a/gnu/packages/glib.scm
+++ b/gnu/packages/glib.scm
@@ -1101,7 +1101,11 @@ Some codes examples can be find at:
            (lambda _
              (substitute* "libappstream-glib/as-self-test.c"
                (("g_test_add_func.*as_test_store_local_appdata_func);") ""))
-             #t)))))
+             #t))
+         (add-before 'check 'set-home
+           (lambda _
+             ;; Some tests want write access there.
+             (setenv "HOME" (getcwd)))))))
     (home-page "https://github.com/hughsie/appstream-glib")
     (synopsis "Library for reading and writing AppStream metadata")
     (description "This library provides objects and helper methods to help

base-commit: c9484c9c9944f65a69cf6182caf442d9285f3a65
-- 
2.33.0