GNU bug report logs - #50131
[PATCH 0/3] Add docbook2x and generate lxc man pages.

Previous Next

Full log

Message #20 received at 50131 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 50131 <at> debbugs.gnu.org, Andrew Whatson <whatson <at> gmail.com>
Subject: Re: [bug#50131] [PATCH 3/3] gnu: Generate man pages for lxc.
Date: Thu, 26 Aug 2021 12:49:51 -0300

Hello Andrew,

Em sexta-feira, 20 de agosto de 2021, às 09:09:07 -03, Andrew Whatson 
escreveu:
> * gnu/packages/virtualization.scm (lxc)[inputs]: Add docboo2x.
> [phases]{patch-docbook-dtd}: New phase.
> ---
>  gnu/packages/virtualization.scm | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)

Looks good to me. Just one question below.

> diff --git a/gnu/packages/virtualization.scm
> b/gnu/packages/virtualization.scm index 1bbcb46b99..f1a9e28d3f 100644
> --- a/gnu/packages/virtualization.scm
> +++ b/gnu/packages/virtualization.scm
> @@ -1008,7 +1008,8 @@ all common programming languages.  Vala bindings
> are also provided.")
> "0qz4l7mlhq7hx53q606qgvkyzyr01glsw290v8ppzvxn1fydlrci")))) (build-system
> gnu-build-system)
>      (native-inputs
> -     `(("pkg-config" ,pkg-config)))
> +     `(("pkg-config" ,pkg-config)
> +       ("docbook2x" ,docbook2x)))
>      (inputs
>       `(("gnutls" ,gnutls)
>         ("libcap" ,libcap)
> @@ -1022,6 +1023,12 @@ all common programming languages.  Vala bindings
> are also provided.") "--localstatedir=/var")
>         #:phases
>         (modify-phases %standard-phases
> +         (add-before 'configure 'patch-docbook-dtd
> +           (lambda _
> +             ;; Fix incorrect DocBook DTD
> +             (substitute* "configure"
> +               (("\\\\\"-//Davenport//DTD DocBook V3\\.0//EN\\\\\"")
> +                "\\\"-//OASIS//DTD DocBook XML\\\"
> \\\"http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd\\\""))))

Has this fix been submitted upstream, or is it already available in a newer 
lxc version? Ideally, we wouldn’t have to carry this change indefinitely.

The same question would apply to the substitutions made in docbook2x, but 
that project seems abandoned so there’s no point.

-- 
Thanks,
Thiago

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.