GNU bug report logs - #50117
[PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates

Previous Next

Package: guix-patches;

Reported by: BonfaceKilz <me <at> bonfacemunyoki.com>

Date: Thu, 19 Aug 2021 07:18:01 UTC

Severity: normal

Tags: patch

Done: Arun Isaac <arunisaac <at> systemreboot.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#50117: closed ([PATCH 0/2] go-github-com-aswinkarthik-csvdiff
 package updates)
Date: Mon, 20 Dec 2021 05:36:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Mon, 20 Dec 2021 11:05:19 +0530
with message-id <87ee6796ug.fsf <at> systemreboot.net>
and subject line Re: [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates
has caused the debbugs.gnu.org bug report #50117,
regarding [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
50117: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50117
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: guix-patches <at> gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, arunisaac <at> systemreboot.net,
 iskarian <at> mgsn.dev
Subject: [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates
Date: Thu, 19 Aug 2021 10:17:09 +0300
Hi all. Find attached the updated package definition of csv diff which addresses the following issues that were kindly pointed out by Sarah:

--8<---------------cut here---------------start------------->8---
Typically end-user Go packages will want inputs/native-inputs rather
than propagated inputs unless the input provides a binary used at
runtime, so user profiles are not cluttered (go-build-system needs
source from all transitive dependencies).  Also, a more friendly name
("csvdiff" is available) might be better for end-user packages like
this.
--8<---------------cut here---------------end--------------->8---


BonfaceKilz (2):
  gnu: go-github-com-aswinkarthik-csvdiff: Rename name to "csvdiff".
  gnu: go-github-com-aswinkarthik-csvdiff: Make inputs native.

 gnu/packages/golang.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.31.1



[Message part 3 (message/rfc822, inline)]
From: Arun Isaac <arunisaac <at> systemreboot.net>
To: "Bonface M. K" <me <at> bonfacemunyoki.com>
Cc: 50117-done <at> debbugs.gnu.org
Subject: Re: [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates
Date: Mon, 20 Dec 2021 11:05:19 +0530
[Message part 4 (text/plain, inline)]
Hi Bonface,

I have applied the patch on master with a few changes. Most
significantly, I moved the deprecated alias from
gnu/packages/textutils.scm to gnu/packages/golang.scm since golang.scm
is where the original package was.

Thanks,
Arun
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 3 years and 155 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.