GNU bug report logs - #50117
[PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates

Previous Next

Full log

Message #17 received at 50117 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: BonfaceKilz <me <at> bonfacemunyoki.com>, 50117 <at> debbugs.gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, iskarian <at> mgsn.dev
Subject: Re: [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates
Date: Fri, 20 Aug 2021 01:17:39 +0530

[Message part 1 (text/plain, inline)]

Hi Bonface,

Thanks for the patches! Some feedback follows.

1. I think we can combine the two commits into one since this is
logically just a single change.

2. We should retain the old package as a deprecated package. We should
add something like the snippet below.

--8<---------------cut here---------------start------------->8---
(define-public go-github-com-aswinkarthik-csvdiff
  (deprecated-package "go-github-com-aswinkarthik-csvdiff" csvdiff))
--8<---------------cut here---------------end--------------->8---

>  (define-public go-github-com-aswinkarthik-csvdiff

3. We should rename the variable name as well.

>    (package
> -    (name "go-github-com-aswinkarthik-csvdiff")
> +    (name "csvdiff")

3. We should also move the package to some file other than
golang.scm. How about textutils.scm?

Thank you for your patience! :-)
Arun

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.