From unknown Wed Aug 20 00:02:46 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#50111 <50111@debbugs.gnu.org> To: bug#50111 <50111@debbugs.gnu.org> Subject: Status: [PATCH] cuirass: Allow filter-only searches. Reply-To: bug#50111 <50111@debbugs.gnu.org> Date: Wed, 20 Aug 2025 07:02:46 +0000 retitle 50111 [PATCH] cuirass: Allow filter-only searches. reassign 50111 guix-patches submitter 50111 Sarah Morgensen severity 50111 normal tag 50111 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 18 13:37:59 2021 Received: (at submit) by debbugs.gnu.org; 18 Aug 2021 17:37:59 +0000 Received: from localhost ([127.0.0.1]:57512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGPVj-0003XS-GY for submit@debbugs.gnu.org; Wed, 18 Aug 2021 13:37:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:47318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGPVe-0003XD-0r for submit@debbugs.gnu.org; Wed, 18 Aug 2021 13:37:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGPVd-0003rg-Mt for guix-patches@gnu.org; Wed, 18 Aug 2021 13:37:49 -0400 Received: from out1.migadu.com ([2001:41d0:2:863f::]:27574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGPVb-0003mO-3T for guix-patches@gnu.org; Wed, 18 Aug 2021 13:37:49 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1629308263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=do35E1B/ZQ6hK3l+qp7d636s6JtqMOyB+aEoVQJNgyM=; b=GrgCfbrop73h+/CIQQAZCB3wSDJwYnX0Q/gK9eqNqRa+dttP1t8+EzM/uAbNRtuZu1ABXk Xvus+4zQ+KPdSSEHkDEhxp4i1jeIFKeE8FNlJVP9WZClJopI8gphFBcu4lVZ1wzEz9WU4F 38lMMvxpNU6RhUUw9ep6hsDEpsPOYLM= From: Sarah Morgensen To: guix-patches@gnu.org Subject: [PATCH] cuirass: Allow filter-only searches. Date: Wed, 18 Aug 2021 10:37:39 -0700 Message-Id: <20210818173740.17581-1-iskarian@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=2001:41d0:2:863f::; envelope-from=iskarian@mgsn.dev; helo=out1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) If there are non-query search filters and there is no query, assume a wildcard query. * src/cuirass/database.scm (query->bind-arguments): Add a wildcard query if there are other filters and no query. --- Hello Guix, I noticed that it's not possible to search on cuirass with only filters, and no query. So this patch allows a filter-only search, without a query. (After reading the code I realized I could use a SQL (!) wildcard "%", but that's not even noted on the Cuirass website.) I haven't tested this, of course, because I don't have a cuirass instance ;) -- Sarah src/cuirass/database.scm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/cuirass/database.scm b/src/cuirass/database.scm index 0aa3f0b..2aa99a1 100644 --- a/src/cuirass/database.scm +++ b/src/cuirass/database.scm @@ -5,6 +5,7 @@ ;;; Copyright © 2018 Clément Lassieur ;;; Copyright © 2018 Tatiana Sholokhova ;;; Copyright © 2019, 2020 Ricardo Wurmus +;;; Copyright © 2021 Sarah Morgensen ;;; ;;; This file is part of Cuirass. ;;; @@ -1060,7 +1061,11 @@ DELETE FROM Checkouts WHERE evaluation=" eval-id ";"))) (if (assq key acc) acc (cons (cons key #f) acc))) - args '(#:spec #:system)))) + (if (or (assq-ref args #:query) + (null? (alist-delete #:query args))) + args + (cons '(#:query . "%") args)) + '(#:spec #:system)))) (define (db-get-build-products build-id) "Return the build products associated to the given BUILD-ID." -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 19 10:49:00 2021 Received: (at 50111-done) by debbugs.gnu.org; 19 Aug 2021 14:49:00 +0000 Received: from localhost ([127.0.0.1]:60590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGjLo-0002gv-46 for submit@debbugs.gnu.org; Thu, 19 Aug 2021 10:49:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGjLk-0002gg-8y for 50111-done@debbugs.gnu.org; Thu, 19 Aug 2021 10:48:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48758) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGjLd-00058i-N5; Thu, 19 Aug 2021 10:48:49 -0400 Received: from [2a01:cb18:832e:5f00:3563:417e:2a38:86d8] (port=48128 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGjLa-0003TF-3h; Thu, 19 Aug 2021 10:48:49 -0400 From: Mathieu Othacehe To: Sarah Morgensen Subject: Re: bug#50111: [PATCH] cuirass: Allow filter-only searches. References: <20210818173740.17581-1-iskarian@mgsn.dev> Date: Thu, 19 Aug 2021 16:48:44 +0200 In-Reply-To: <20210818173740.17581-1-iskarian@mgsn.dev> (Sarah Morgensen's message of "Wed, 18 Aug 2021 10:37:39 -0700") Message-ID: <874kblebhv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50111-done Cc: 50111-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, Nice, applied as 082a477989cd6246a02c3e2ee661536ccc77cddb! I'll have to update the Guix Cuirass package and deploy it on Berlin before we all can enjoy this on https://ci.guix.gnu.org. > I haven't tested this, of course, because I don't have a cuirass instance ;) Note that running a small Cuirass instance using the dedicated Guix service as described here[1] should be relatively easy if you want to test further fixes :). Thanks, Mathieu [1]: https://guix.gnu.org/manual/en/html_node/Continuous-Integration.html From unknown Wed Aug 20 00:02:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 17 Sep 2021 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator