GNU bug report logs - #50091
[PATCH 00/21] Add riscv64 support

Previous Next

Full log

Message #116 received at 50091 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: Efraim Flashner <efraim <at> flashner.co.il>, 50091 <at> debbugs.gnu.org
Subject: Re: [bug#50091] [PATCH 20/21] gnu: lz4: Build on riscv64-linux
 without valgrind.
Date: Tue, 17 Aug 2021 12:26:33 -0300

Hello,

Em terça-feira, 17 de agosto de 2021, às 07:35:35 -03, Efraim Flashner 
escreveu:
> On Tue, Aug 17, 2021 at 01:19:18PM +0300, Efraim Flashner wrote:
> > * gnu/packages/compression.scm (lz4)[native-inputs]: Don't use valgrind
> > when building for riscv64-linux.
> > ---
> > 
> >  gnu/packages/compression.scm | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/gnu/packages/compression.scm
> > b/gnu/packages/compression.scm
> > index 93d517abd5..1803237e6e 100644
> > --- a/gnu/packages/compression.scm
> > +++ b/gnu/packages/compression.scm
> > @@ -819,7 +819,9 @@ decompression of some loosely related file formats
> > used by Microsoft.")> 
> >      (native-inputs
> >      
> >       `(;; For tests.
> >       
> >         ("python" ,python)
> > 
> > -       ("valgrind" ,valgrind)))
> > +       ,@(if (target-riscv?)
> > +           '()
> > +           `(("valgrind" ,valgrind)))))
> > 
> >      (arguments
> >      
> >       `(;; Not designed for parallel testing.
> >       
> >         ;; See
> >         https://github.com/lz4/lz4/issues/957#issuecomment-737419821
> 
> Valgrind added support for riscv64-linux after the last release, but the
> patch isn't easy to backport. I've thought about adding a valgrind-next
> and pulling from a recent commit but I'm not sure it's actually worth
> it.

IMHO, either the commit message or the code would benefit from a note 
mentioning that the current version of Valgrind doesn’t support
riscv64-linux.

-- 
Thanks,
Thiago

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.