Subject: Re: [bug#50091] [PATCH 01/21] utils: Define 'target-riscv?' predicate.

From: Maxime Devos <[email-masked]>
Date: Tue, 17 Aug 2021 12:27:17 +0200

Efraim Flashner schreef op di 17-08-2021 om 13:18 [+0300]:
> * guix/utils.scm (target-riscv?): New predicate.
> ---
>  guix/utils.scm | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/guix/utils.scm b/guix/utils.scm
> index 32fcff72ea..134879feb1 100644
> --- a/guix/utils.scm
> +++ b/guix/utils.scm
> @@ -96,6 +96,7 @@
>              target-arm?
>              target-ppc32?
>              target-powerpc?
> +            target-riscv?
>              target-64bit?
>              cc-for-target
>              cxx-for-target
> @@ -699,6 +700,11 @@ architecture (x86_64)?"
>                                                   (%current-system))))
>    (string-prefix? "powerpc" target))
>  
> +(define* (target-riscv? #:optional (target (or (%current-target-system)
> +                                               (%current-system))))
> +  "Is the architecture of TARGET a 'riscv' architecture variant?"
> +  (string-prefix? "riscv" target))
> +
>  (define* (target-64bit? #:optional (system (or (%current-target-system)
>                                                 (%current-system))))
>    (any (cut string-prefix? <> system) '("x86_64" "aarch64" "mips64" "powerpc64")))

The next patch adds a ‘riscv64-linux-gnu’ target.  riscv64 seems 64-bit to me.
It would seem riscv64 needs to be added to target-64bit?.

Greetings,
Maxime.