GNU bug report logs - #50087
[PATCH 0/2] Add csvdiff

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50087 in the body.
You can then email your comments to 50087 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: guix-patches <at> gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>
Subject: [PATCH 0/2] Add csvdiff
Date: Tue, 17 Aug 2021 08:47:43 +0300

Hi all. This patch adds a fast csv diffing utility written in go-lang.

BonfaceKilz (2):
  gn: Add go-github-com-oneofone-xxhash.
  gn: Add go-github-com-aswinkarthik-csvdiff.

 gnu/packages/golang.scm | 58 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

-- 
2.31.1

Message #8 received at 50087 <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: 50087 <at> debbugs.gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>
Subject: [PATCH 0/2] Add csvdiff
Date: Tue, 17 Aug 2021 08:50:40 +0300

Hi all. This patch adds a fast csv diffing utility written in go-lang.

BonfaceKilz (2):
  gn: Add go-github-com-oneofone-xxhash.
  gn: Add go-github-com-aswinkarthik-csvdiff.

 gnu/packages/golang.scm | 58 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

-- 
2.31.1

Message #11 received at 50087 <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: 50087 <at> debbugs.gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>
Subject: [PATCH 1/2] gn: Add go-github-com-oneofone-xxhash.
Date: Tue, 17 Aug 2021 08:50:41 +0300

* gnu/packages/golang.scm (go-github-com-oneofone-xxhash): New variable.
---
 gnu/packages/golang.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index f4cd30c662..7cdd94b7f0 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -29,6 +29,7 @@
 ;;; Copyright © 2021 Sarah Morgensen <iskarian <at> mgsn.dev>
 ;;; Copyright © 2021 Raghav Gururajan <rg <at> raghavgururajan.name>
 ;;; Copyright © 2021 jgart <jgart <at> dismail.de>
+;;; Copyright © 2021 Bonface Munyoki Kilyungi <me <at> bonfacemunyoki.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -8396,3 +8397,27 @@ zero round-trip encryption, and other advanced features.")
     (synopsis "Go compression library")
     (description "@code{compress} provides various compression algorithms.")
     (license license:bsd-3)))
+
+(define-public go-github-com-oneofone-xxhash
+  (package
+    (name "go-github-com-oneofone-xxhash")
+    (version "1.2.8")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/OneOfOne/xxhash")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0f98qk83l2fhpclvrgyxsa9b8m4pipf11fah85bnjl01wy4lvybw"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/OneOfOne/xxhash"))
+    (home-page "https://github.com/OneOfOne/xxhash")
+    (synopsis "Go implementation of xxhash")
+    (description "This is a native Go implementation of the
+@url{https://github.com/Cyan4973/xxHash, xxhash} algorithm, an extremely fast
+non-cryptographic Hash algorithm, working at speeds close to RAM limits.")
+    (license license:asl2.0)))
-- 
2.31.1

Message #14 received at 50087 <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: 50087 <at> debbugs.gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>
Subject: [PATCH 2/2] gn: Add go-github-com-aswinkarthik-csvdiff.
Date: Tue, 17 Aug 2021 08:50:42 +0300

* gnu/packages/golang.scm (go-github-com-aswinkarthik-csvdiff): New variable.
---
 gnu/packages/golang.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 7cdd94b7f0..3de07478c6 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8421,3 +8421,36 @@ zero round-trip encryption, and other advanced features.")
 @url{https://github.com/Cyan4973/xxHash, xxhash} algorithm, an extremely fast
 non-cryptographic Hash algorithm, working at speeds close to RAM limits.")
     (license license:asl2.0)))
+
+(define-public go-github-com-aswinkarthik-csvdiff
+  (package
+    (name "go-github-com-aswinkarthik-csvdiff")
+    (version "1.4.0")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/aswinkarthik/csvdiff")
+               (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32
+          "0cd1ikxsypjqisfnmr7zix3g7x8p892w77086465chyd39gpk97b"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/aswinkarthik/csvdiff"))
+    (propagated-inputs
+     `(("go-golang-org-x-sys" ,go-golang-org-x-sys)
+       ("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify)
+       ("go-github-com-spf13-cobra" ,go-github-com-spf13-cobra)
+       ("go-github-com-spf13-afero" ,go-github-com-spf13-afero)
+       ("go-github-com-spaolacci-murmur3" ,go-github-com-spaolacci-murmur3)
+       ("go-github-com-mattn-go-colorable" ,go-github-com-mattn-go-colorable)
+       ("go-github-com-fatih-color" ,go-github-com-fatih-color)
+       ("go-github-com-cespare-xxhash" ,go-github-com-cespare-xxhash)
+       ("go-github-com-oneofone-xxhash" ,go-github-com-oneofone-xxhash)))
+    (home-page "https://github.com/aswinkarthik/csvdiff")
+    (synopsis "csvdiff")
+    (description
+     "This package provides a fast diff tool for comparing csv files.")
+    (license license:expat)))
-- 
2.31.1

Message #19 received at 50087-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: BonfaceKilz <me <at> bonfacemunyoki.com>
Cc: 50087-done <at> debbugs.gnu.org
Subject: Re: [bug#50087] [PATCH 0/2] Add csvdiff
Date: Tue, 17 Aug 2021 14:01:38 +0530

[Message part 1 (text/plain, inline)]

Hi Bonface,

Thanks for contributing to Guix! I pushed with the following few
changes.

1. I replaced "gn" with "gnu" in the commit message.
2. I improved the synopsis and description of both the packages.

Cheers! :-)
Arun

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 50087-done <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, 50087-done <at> debbugs.gnu.org
Subject: Re: bug#50087: [PATCH 0/2] Add csvdiff
Date: Tue, 17 Aug 2021 13:02:22 -0400 (EDT)

On Tue, 17 Aug 2021, Arun Isaac wrote:

>
> Hi Bonface,
>
> Thanks for contributing to Guix! I pushed with the following few
> changes.
>
> 1. I replaced "gn" with "gnu" in the commit message.
> 2. I improved the synopsis and description of both the packages.
>
> Cheers! :-)
> Arun

Thanks to you both! I think I'll get a lot of use out of this package.

Best!
Jack

Message #25 received at 50087 <at> debbugs.gnu.org (full text, mbox):

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, 50087 <at> debbugs.gnu.org
Subject: Re: [bug#50087] [PATCH 0/2] Add csvdiff
Date: Tue, 17 Aug 2021 13:00:55 -0700

Hello,

On Tue, 17 Aug 2021, Arun Isaac wrote:

>
> Hi Bonface,
>
> Thanks for contributing to Guix! I pushed with the following few
> changes.
>
> 1. I replaced "gn" with "gnu" in the commit message.
> 2. I improved the synopsis and description of both the packages.
>
> Cheers! :-)
> Arun

Typically end-user Go packages will want inputs/native-inputs rather
than propagated inputs unless the input provides a binary used at
runtime, so user profiles are not cluttered (go-build-system needs
source from all transitive dependencies).  Also, a more friendly name
("csvdiff" is available) might be better for end-user packages like
this.

Apologies for not commenting sooner!

--
Sarah

Message #28 received at 50087 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Sarah Morgensen <iskarian <at> mgsn.dev>, BonfaceKilz <me <at> bonfacemunyoki.com>
Cc: 50087 <at> debbugs.gnu.org
Subject: Re: [bug#50087] [PATCH 0/2] Add csvdiff
Date: Wed, 18 Aug 2021 11:26:20 +0530

[Message part 1 (text/plain, inline)]

Hi Sarah,

> Typically end-user Go packages will want inputs/native-inputs rather
> than propagated inputs unless the input provides a binary used at
> runtime, so user profiles are not cluttered (go-build-system needs
> source from all transitive dependencies).  Also, a more friendly name
> ("csvdiff" is available) might be better for end-user packages like
> this.

I agree. csvdiff being an end-user package, maybe we should also move it
to some file other than golang.scm.

@Bonface: Could you send patches to this effect?

Regards,
Arun

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 50087 <at> debbugs.gnu.org (full text, mbox):

From: Bonface Munyoki K. <me <at> bonfacemunyoki.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: Sarah Morgensen <iskarian <at> mgsn.dev>, 50087 <at> debbugs.gnu.org
Subject: Re: [bug#50087] [PATCH 0/2] Add csvdiff
Date: Thu, 19 Aug 2021 10:23:29 +0300

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> anaandika:

> Hi Sarah,
>
>> Typically end-user Go packages will want inputs/native-inputs rather
>> than propagated inputs unless the input provides a binary used at
>> runtime, so user profiles are not cluttered (go-build-system needs
>> source from all transitive dependencies).  Also, a more friendly name
>> ("csvdiff" is available) might be better for end-user packages like
>> this.
>
> I agree. csvdiff being an end-user package, maybe we should also move it
> to some file other than golang.scm.
>
> @Bonface: Could you send patches to this effect?
>
> Regards,
> Arun
>

Thanks for your feedback. Submitted patches in:
bug#50117

-- 
Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 50087-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Jack Hill <jackhill <at> jackhill.us>
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, 50087-done <at> debbugs.gnu.org
Subject: Re: bug#50087: [PATCH 0/2] Add csvdiff
Date: Fri, 20 Aug 2021 16:00:20 +0530

[Message part 1 (text/plain, inline)]

> Thanks to you both! I think I'll get a lot of use out of this package.

You're welcome! :-)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.