Subject: Re: [PATCH] gnu: Add waypipe.

From: "Paul A. Patience" <[email-masked]>
Date: Wed, 18 Aug 2021 22:56:57 +0000

Hi,

> +         (add-after 'unpack 'fix-sleep-path
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out"))

out is not used anywhere, so you can remove it, along with the outputs
argument of the lambda.

> +                   (coreutils (assoc-ref inputs "coreutils")))
> +               (substitute* "./test/startup_failure.py"
> +                 (("sleep")
> +                  (string-append coreutils "/bin/sleep")))
> +               #t))))))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("scdoc" ,scdoc)))
> +    (inputs
> +     ;; For tests
> +     `(("python" ,python)
> +       ("coreutils" ,coreutils)))

I haven't tried building this or anything, but if python and coreutils
are really only needed for tests, then they need not be in inputs (and
the fact that the initial version of this patch didn't have them at all
supports this thesis).
In other words, I'd put everything in native-inputs.

Also (and this is really minor), arguments normally follows the inputs
sections.

Best regards,
Paul