GNU bug report logs - #50072
[PATCH WIP 0/4] Add upstream updater for git-fetch origins.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Sarah Morgensen <iskarian <at> mgsn.dev>
Subject: bug#50072: closed (Re: bug#50072: [PATCH WIP 0/4] Add upstream
 updater for git-fetch origins.)
Date: Thu, 06 Jan 2022 10:21:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#50072: [PATCH WIP 0/4] Add upstream updater for git-fetch origins.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 50072 <at> debbugs.gnu.org.

-- 
50072: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50072
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Sarah Morgensen <iskarian <at> mgsn.dev>, zimoun <zimon.toutoune <at> gmail.com>,
 50072-done <at> debbugs.gnu.org
Subject: Re: bug#50072: [PATCH WIP 0/4] Add upstream updater for git-fetch
 origins.
Date: Thu, 06 Jan 2022 11:20:36 +0100

Applied v5 of this patch series, thanks a lot Sarah, Maxime, and zimoun!
\o/

One thing we should eventually address IMO is how the <upstream-source>
abstraction could be made to better model both tarballs and checkouts:

  https://issues.guix.gnu.org/50072#29

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: guix-patches <at> gnu.org
Subject: [PATCH WIP 0/4] Add upstream updater for git-fetch origins.
Date: Sun, 15 Aug 2021 16:16:13 -0700

Hello Guix,

This is a proof-of-concept for extending `guix refresh -u` to support packages
with git-fetch origins.  The potential impact is large: approximately 4.5k
packages use git-fetch, although only some fraction would be supported.

Currently, this enables update support for (at least) any package where

* github-updater finds an update,
* origin-method is 'git-fetch', and
* the package version is a suffix of the 'commit' field.

Drawbacks currently include the fact that libgit2 doesn't (yet) support
shallow checkouts [0], so the entire repository must be cloned. There is also
no support for verifying commits.

There should probably also be a few tests added.

WDYT?

[0] https://github.com/libgit2/libgit2/issues/3058

--
Sarah Morgensen (4):
  guix hash: Extract file hashing procedures.
  import: Factorize file hashing.
  refresh: Support non-tarball sources.
  upstream: Support updating git-fetch origins.

 guix/git-download.scm    | 18 +++++++++++++-
 guix/hash.scm            | 51 ++++++++++++++++++++++++++++++++++++++++
 guix/import/cran.scm     | 32 +++----------------------
 guix/import/elpa.scm     | 28 ++++------------------
 guix/import/go.scm       | 26 +++-----------------
 guix/scripts/hash.scm    | 29 ++++++-----------------
 guix/scripts/refresh.scm | 10 ++++----
 guix/upstream.scm        | 41 +++++++++++++++++++++++++++++++-
 8 files changed, 130 insertions(+), 105 deletions(-)
 create mode 100644 guix/hash.scm


base-commit: 12099eac1b161d364be923451d27d7d739d0f14d
-- 
2.31.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.