GNU bug report logs - #50067
Context menus

Previous Next

Full log

Message #48 received at 50067 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: alan <at> idiocy.org, mattiase <at> acm.org, homeros.misasa <at> gmail.com,
 tkk <at> misasa.okayama-u.ac.jp, larsi <at> gnus.org, 50067 <at> debbugs.gnu.org
Subject: Re: bug#50067: Context menus
Date: Wed, 18 Aug 2021 21:06:11 +0300

>> diff --git a/lisp/mouse.el b/lisp/mouse.el
>> index 9b7d4c240f..5193994231 100644
>> --- a/lisp/mouse.el
>> +++ b/lisp/mouse.el
>> @@ -304,7 +304,7 @@ context-menu-filter-function
>>  (defun context-menu-map ()
>>    "Return composite menu map."
>> -  (let ((menu (make-sparse-keymap "Context Menu")))
>> +  (let ((menu (make-sparse-keymap)))
>>      (run-hook-wrapped 'context-menu-functions
>>                        (lambda (fun)
>>                          (setq menu (funcall fun menu))
>
> I see you already pushed this, but it's a bad idea: it makes ugly
> context menus on TTYs (and AFAIU also on non-toolkit X builds): these
> _require_ the menu name because they display a caption which looks bad
> with an empty name.

I guess the presence of the title should be platform-dependent.
For example, without a title it looks great on the GTK build.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.