Subject: Re: bug#50065: [PATCH] gnu: Add setroot.

From: Mathieu Othacehe <[email-masked]>
Date: Tue, 31 Aug 2021 16:04:22 +0200

Hello Brice,

> +    (source (origin

You should put origin on the next line to respect the 78 columns limit.

> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/ttzhou/setroot")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32 "0w95828v0splk7bj5kfacp4pq6wxpyamvyjmahyvn5hc3ycq21mq"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:make-flags
> +       (list (string-append "DESTDIR=" (assoc-ref %outputs "out"))
> +             "PREFIX="
> +             "xinerama=1")

The Makefile seems to hardcode CC to gcc which probably breaks
cross-compilation.

> +syntax without it's image viewing capabilities.  It supports multiple monitors
                    ^
                    its?

Thanks,

Mathieu