GNU bug report logs - #50054
[PATCH] gnu: Add bgfx

Previous Next

Package: guix-patches;

Reported by: Andy Tai <lichengtai <at> gmail.com>

Date: Sat, 14 Aug 2021 08:37:02 UTC

Severity: normal

Tags: patch

Full log


View this message in rfc822 format

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Andy Tai <lichengtai <at> gmail.com>
Cc: 50054 <at> debbugs.gnu.org
Subject: [bug#50054] [PATCH] gnu: Add bgfx
Date: Sun, 29 Aug 2021 13:41:35 +0200
Hi,

Am Samstag, den 28.08.2021, 21:29 -0700 schrieb Andy Tai:
> further update
> 
> building the examples and the tools from source
> 
> On Sat, Aug 28, 2021 at 8:25 PM Andy Tai <lichengtai <at> gmail.com>
> wrote:
> > updated patch attached:
> > 
> > directly checking out additional source repos rather than relying
> > on
> > git submodule
> > 
> > first attempt at removing "nasty" stuff, removing bx/tools/bin
> > [...]

First things first, this still does a build of everything at once
rather than one package per repo.  Have you looked into the one package
per repo thing and decided that it's not possible or do you simply
continue with the package as-is because it builds?

Even if you want to do a merged build, binaries, vendored dependencies,
etc. ought to be removed in the origins, not at build time.  I suggest
you use a computed origin to merge the three and remove all those
things.

Regards






This bug report was last modified 1 year and 116 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.