From unknown Sat Sep 20 08:01:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#50052 <50052@debbugs.gnu.org> To: bug#50052 <50052@debbugs.gnu.org> Subject: Status: [PATCH] Add prusa-slicer Reply-To: bug#50052 <50052@debbugs.gnu.org> Date: Sat, 20 Sep 2025 15:01:27 +0000 retitle 50052 [PATCH] Add prusa-slicer reassign 50052 guix-patches submitter 50052 Daniel Trujillo Viedma severity 50052 normal tag 50052 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 13 21:16:02 2021 Received: (at submit) by debbugs.gnu.org; 14 Aug 2021 01:16:02 +0000 Received: from localhost ([127.0.0.1]:43295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEiHG-0003BQ-7C for submit@debbugs.gnu.org; Fri, 13 Aug 2021 21:16:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:48476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEg8h-0008Mo-9n for submit@debbugs.gnu.org; Fri, 13 Aug 2021 18:59:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEg8g-0008Gv-VP for guix-patches@gnu.org; Fri, 13 Aug 2021 18:58:58 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:43696) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mEg8e-0007Pb-LH for guix-patches@gnu.org; Fri, 13 Aug 2021 18:58:58 -0400 Received: by mail-wr1-x42f.google.com with SMTP id z9so15168063wrh.10 for ; Fri, 13 Aug 2021 15:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:references:to:from:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=jCFNWYwVRM+Ro+IXVOT9flAmqogWOiwSsT04YzScvEY=; b=N6dtU3K6hEoZ497Wx5lQmcSrNUTdABPcWcp2EaBnXJ/ECFvgNho2yIeJwSHuiJmr0L 7DsB7hyI89FX4mm8wwvieVYXhbVyyK2piGZNV6GKXP+I31RhduDvFb4tdzWcUTg9H01V K7NqaaN5zRxHBet/nt1rAIC+Hx6zgdczZvbfICeYDuJmvBwH119SMRtAyIl8zxrat8iW oHJCZuTZd2MxLvsMnfJs4CWUkqnFv5/iUoLxZloh69k2NGhj+w9ct9yfQ8fLPDAD5k2X SR2e9WoFebVon+knnJA/VlXA73wGHXhnTEE6QdCOqquQMFy6ot189W3XklHDot5texdj h5nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:references:to:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=jCFNWYwVRM+Ro+IXVOT9flAmqogWOiwSsT04YzScvEY=; b=nLuow85IGPApkrzorivnt1Kgm5HaDfwN23tEgV71OXyBEGhr0jUrF5i3iHJKR/ue5t ildOYc2RCH8utSBZpgFGqRV0sxiGaJTNexZjOejSobMMS9MjkTfwV/xiB4tzHQiKy5Xx smPDniJ6DHWsp/mQB85lh2oKQ5WCI0V5dIrTGB8E6tksYdL0oi2CD5NTWGJa9Nkc3ZHk zc4DAVGMVQe8fTGOcr/MJws4qe57l8fYt/+BMyJkKfXSJIyAsAQ79gHlFsJyATkDek4q XMoAVpO9kARXSB+GTcE6NCKY3ITt4wPc5oNrOSNaijsirhXgjaJnsqD3tRJF+YUQB0Hy jN0w== X-Gm-Message-State: AOAM531kQbz7d8oGk6ySzOeZ0uu+CVbhIvuaTbQtpHNro3LgoCtxgOY1 Rh7espbnarqVRomMtYub3BCrPQKyUZMEZw== X-Google-Smtp-Source: ABdhPJxdtZesm4S6qDBfh+FmM4HFDFpfbgNIrmyfDxgLaj7Zu8Tcd8mu5uMn6yAUVRDWOHtPdWSPXw== X-Received: by 2002:a05:6000:128e:: with SMTP id f14mr5473328wrx.167.1628895533652; Fri, 13 Aug 2021 15:58:53 -0700 (PDT) Received: from [192.168.0.13] ([37.223.119.203]) by smtp.gmail.com with ESMTPSA id h8sm2608659wmb.35.2021.08.13.15.58.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Aug 2021 15:58:53 -0700 (PDT) Subject: [PATCH] Add prusa-slicer References: <0654f9e7-8c1d-aa4c-3240-54faf3defb2f@gmail.com> To: guix-patches@gnu.org From: Daniel Trujillo Viedma X-Forwarded-Message-Id: <0654f9e7-8c1d-aa4c-3240-54faf3defb2f@gmail.com> Message-ID: Date: Sat, 14 Aug 2021 00:58:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <0654f9e7-8c1d-aa4c-3240-54faf3defb2f@gmail.com> Content-Type: multipart/mixed; boundary="------------CB336E4D379709DB6379C835" Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=dtviedma@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 13 Aug 2021 21:15:56 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------CB336E4D379709DB6379C835 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi! I'm Daniel Trujillo, This is my first-time-ever contribution to GNU Guix, so please, don't hold any nitpick to yourself!! :) I don't know if these kind of packages are of interest, but this is PrusaSlicer [0], a software to prepare 3D printings (hence I put it in engineering.scm). The packaged version, 2.3.3 is the latest stable available at this moment. But this version has as important problem [1]: It cannot be invoked just naming the executable (through $PATH), because then, it can't locate the resources directory. I learned **the hard way** that the fix was applied *after* the release of the 2.3.3 version, so I decided to backport the fix adding a patch because it's a show-stopper to have to type the path to the executable in /gnu/store/... That's the reason why the patch attached to this email contains, not only the additions to engineering.scm, but also a patch that implements the solution in the version 2.3.3 codebase (It's quite simple, it uses a boost function to determine the path to the executable rather than relying on argv[0]). Known improvable things: * It's configured to use GTK3. After many attempts to compile it under GTK2 in a guix environment, sometimes it detected GTK right away, and some ether times I had to add more includes. It wasn't quite reliable and, according to the convention followed in gtk+ packages, probably it would be better that prusa-slicer uses GTK3, and a hypothetical future GTK2 version would be called prusa-slicer-gtk2. * In order for the above $PATH issue fix to work, it's crucial that the cmake variable SLIC3R_FHS is set to off. This is the default value according to the CMakeLists.txt, but because it's so important, probably it should have been included in the configure-flags argument? Just for clarity. * Currently, the version displayed in the title bar is "....2.3.3+UNKNOWN". This is because of another cmake option not set. It doesn't have any influence in the software, as far as I know, but it's arguably ugly. The version I currently use, doesn't display that in the title bar, but it does in the "About" window, and it says ".....2.3.3+linux-64". Maybe something like "GNU Guix" would be prettier. But if I have to include the arch, I would have to dig deeper into package definitions ^_^''' I hope everything is in order, I'm looking forward to see your comments, and hope I can start contributing more packages to Guix!! Cheers, Dani. [0] https://www.prusa3d.es/prusaslicer/ [1] https://github.com/prusa3d/PrusaSlicer/issues/5542 --------------CB336E4D379709DB6379C835 Content-Type: text/x-patch; charset=UTF-8; name="0001-Add-prusa-slicer.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Add-prusa-slicer.patch" >From 522c1904cf62afac25a9d974091211adac760c25 Mon Sep 17 00:00:00 2001 From: Daniel Trujillo Viedma Date: Sat, 14 Aug 2021 00:00:55 +0200 Subject: [PATCH] Add prusa-slicer --- gnu/packages/engineering.scm | 58 ++++++++++++++++++++++ .../patches/prusa-slicer-backport-fix-5542.patch | 31 ++++++++++++ 2 files changed, 89 insertions(+) create mode 100644 gnu/packages/patches/prusa-slicer-backport-fix-5542.patch diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index 33c124a2ea..047d99c0af 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -2863,3 +2863,61 @@ for hooking Linux system calls in user space. This is achieved by hot-patching the machine code of the standard C library in the memory of a process.") (license license:bsd-2)))) + +(define-public prusa-slicer + (package + (name "prusa-slicer") + (version "2.3.3") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/prusa3d/PrusaSlicer") + (commit (string-append "version_" version)))) + (sha256 + (base32 "0w0synqi3iz9aigsgv6x1c6sg123fasbx19h4w3ic1l48r8qmpwm")) + (patches (search-patches "prusa-slicer-backport-fix-5542.patch")))) + (build-system cmake-build-system) + (arguments + `(#:configure-flags `("-DSLIC3R_GTK=3"))) + (native-inputs + `(("pkg-config" ,pkg-config))) + (inputs + `(("perl" ,perl) + ("glibc-locales" ,glibc-locales) + ("adwaita-icon-theme" ,adwaita-icon-theme) + ("boost" ,boost) + ("tbb" ,tbb) + ("curl" ,curl) + ("zlib" ,zlib) + ("eigen" ,eigen) + ("expat" ,expat) + ("libpng" ,libpng) + ("mesa" ,mesa) + ("glew" ,glew) + ("cereal" ,cereal) + ("nlopt" ,nlopt) + ("openvdb" ,openvdb) + ("cgal" ,cgal) + ("gmp" ,gmp) + ("mpfr" ,mpfr) + ("qhull" ,qhull) + ("wxwidgets" ,wxwidgets-3.1) + ("coreutils" ,coreutils) + ("grep" ,grep) + ("sed" ,sed) + ("openexr" ,openexr) + ("glib" ,glib) + ("glibc" ,glibc) + ("gtk+" ,gtk+) + ("pango" ,pango) + ("dbus" ,dbus))) + (home-page "https://www.prusa3d.com/prusaslicer/") + (synopsis "G-code generator for 3D printers (RepRap, Makerbot, Ultimaker etc.)") + (description + "PrusaSlicer (formerly known as Slic3r Prusa Edition or Slic3r PE) is +our own in-house developed slicer software based on the open-source project +Slic3r. PrusaSlicer is an open-source, feature-rich, frequently updated +tool that contains everything you need to export the perfect print files +for your Original Prusa 3D printer.") + (license license:agpl3))) diff --git a/gnu/packages/patches/prusa-slicer-backport-fix-5542.patch b/gnu/packages/patches/prusa-slicer-backport-fix-5542.patch new file mode 100644 index 0000000000..63d2a45be1 --- /dev/null +++ b/gnu/packages/patches/prusa-slicer-backport-fix-5542.patch @@ -0,0 +1,31 @@ +This patch backports a solution for the issue: +https://github.com/prusa3d/PrusaSlicer/issues/5542 +that causes PrusaSlicer to crash when invoked +from the command line by means of the $PATH variable. +This fix is applied in: +https://github.com/prusa3d/PrusaSlicer/commit/293f85b6cf9b805af93b9f79f5ff878b6d673969 +quite after the release of 2.3.3, so this backport is needed. + +diff --git a/src/PrusaSlicer.cpp b/src/PrusaSlicer.cpp +index b0df2c99a..31e30af81 100644 +--- a/src/PrusaSlicer.cpp ++++ b/src/PrusaSlicer.cpp +@@ -28,6 +28,7 @@ + #include + #include + #include ++#include + + #include "unix/fhs.hpp" // Generated by CMake from ../platform/unix/fhs.hpp.in + +@@ -612,7 +613,9 @@ bool CLI::setup(int argc, char **argv) + // Detect the operating system flavor after SLIC3R_LOGLEVEL is set. + detect_platform(); + +- boost::filesystem::path path_to_binary = boost::filesystem::system_complete(argv[0]); ++ // See Invoking prusa-slicer from $PATH environment variable crashes #5542 ++ // boost::filesystem::path path_to_binary = boost::filesystem::system_complete(argv[0]); ++ boost::filesystem::path path_to_binary = boost::dll::program_location(); + + // Path from the Slic3r binary to its resources. + #ifdef __APPLE__ -- 2.11.0 --------------CB336E4D379709DB6379C835-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 15 07:03:09 2021 Received: (at 50052) by debbugs.gnu.org; 15 Aug 2021 11:03:09 +0000 Received: from localhost ([127.0.0.1]:45856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFDuy-0002ft-Bj for submit@debbugs.gnu.org; Sun, 15 Aug 2021 07:03:09 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:43644 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFDus-0002fF-7c for 50052@debbugs.gnu.org; Sun, 15 Aug 2021 07:03:03 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1629025368; bh=6DINk8Ek9SH/xh0t4PxIzLidQgkzbUq3oCPgAcT/Y2U=; h=From:To:Subject:In-Reply-To:References:Date; b=q7esBtxSp0tOx1nKkNDFaN3NLoP/hyvrSQjrOVtMhDoshXk0KvE95pvPx9gawtPMo txhF6B4L+G28iZMSEhpDbViw2xf8Ap1j4WCqwFeourYqq0HCqNvub40eHDimIeRe3m rrf7mxxv1mTtF3t+AT54MJsqZywumeKptybDVkeE= To: Daniel Trujillo Viedma , 50052@debbugs.gnu.org Subject: Re: [bug#50052] [PATCH] Add prusa-slicer In-Reply-To: References: <0654f9e7-8c1d-aa4c-3240-54faf3defb2f@gmail.com> Date: Sun, 15 Aug 2021 13:02:39 +0200 Message-ID: <878s139dio.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sat, Aug 14 2021, Daniel Trujillo Viedma wrote: > Hi! I'm Daniel Trujillo, > > > This is my first-time-ever contribution to GNU Guix, so please, don't > hold any nitpick to yourself!! :) > > > I don't know if these kind of packages are of interest, [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps X-Debbugs-Envelope-To: 50052 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sat, Aug 14 2021, Daniel Trujillo Viedma wrote: > Hi! I'm Daniel Trujillo, > > > This is my first-time-ever contribution to GNU Guix, so please, don't > hold any nitpick to yourself!! :) > > > I don't know if these kind of packages are of interest, [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Aug 14 2021, Daniel Trujillo Viedma wrote: > Hi! I'm Daniel Trujillo, > > > This is my first-time-ever contribution to GNU Guix, so please, don't=20 > hold any nitpick to yourself!! :) > > > I don't know if these kind of packages are of interest, but this is=20 > PrusaSlicer [0], a software to prepare 3D printings (hence I put it in=20 > engineering.scm). > > The packaged version, 2.3.3 is the latest stable available at this=20 > moment. But this version has as important problem [1]: It cannot be=20 > invoked just naming the executable (through $PATH), because then, it=20 > can't locate the resources directory. I learned **the hard way** that=20 > the fix was applied *after* the release of the 2.3.3 version, so I=20 > decided to backport the fix adding a patch because it's a show-stopper=20 > to have to type the path to the executable in /gnu/store/... That's the=20 > reason why the patch attached to this email contains, not only the=20 > additions to engineering.scm, but also a patch that implements the=20 > solution in the version 2.3.3 codebase (It's quite simple, it uses a=20 > boost function to determine the path to the executable rather than=20 > relying on argv[0]). > > > Known improvable things: > * It's configured to use GTK3. After many attempts to compile it under=20 > GTK2 in a guix environment, sometimes it detected GTK right away, and=20 > some ether times I had to add more includes. It wasn't quite reliable=20 > and, according to the convention followed in gtk+ packages, probably it=20 > would be better that prusa-slicer uses GTK3, and a hypothetical future=20 > GTK2 version would be called prusa-slicer-gtk2. > > * In order for the above $PATH issue fix to work, it's crucial that the=20 > cmake variable SLIC3R_FHS is set to off. This is the default value=20 > according to the CMakeLists.txt, but because it's so important, probably= =20 > it should have been included in the configure-flags argument? Just for=20 > clarity. That=E2=80=99s probably a good idea, in case upstream changes the default v= alue in the future. > * Currently, the version displayed in the title bar is=20 > "....2.3.3+UNKNOWN". This is because of another cmake option not set. It= =20 > doesn't have any influence in the software, as far as I know, but it's=20 > arguably ugly. The version I currently use, doesn't display that in the=20 > title bar, but it does in the "About" window, and it says=20 > ".....2.3.3+linux-64". Maybe something like "GNU Guix" would be=20 > prettier. But if I have to include the arch, I would have to dig deeper=20 > into package definitions ^_^''' > > > I hope everything is in order, I'm looking forward to see your comments,= =20 > and hope I can start contributing more packages to Guix!! > > > Cheers, > > Dani. > > > [0] https://www.prusa3d.es/prusaslicer/ > > [1] https://github.com/prusa3d/PrusaSlicer/issues/5542 > > > From 522c1904cf62afac25a9d974091211adac760c25 Mon Sep 17 00:00:00 2001 > From: Daniel Trujillo Viedma > Date: Sat, 14 Aug 2021 00:00:55 +0200 > Subject: [PATCH] Add prusa-slicer > > --- The commit message should be in the GNU ChangeLog format, see the commit log for examples, or check the manual. =20=20 > gnu/packages/engineering.scm | 58 ++++++++++++++++= ++++++ > .../patches/prusa-slicer-backport-fix-5542.patch | 31 ++++++++++++ This patch should also be added to the gnu/local.mk file. > 2 files changed, 89 insertions(+) > create mode 100644 gnu/packages/patches/prusa-slicer-backport-fix-5542.p= atch > > diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm > index 33c124a2ea..047d99c0af 100644 > --- a/gnu/packages/engineering.scm > +++ b/gnu/packages/engineering.scm > @@ -2863,3 +2863,61 @@ for hooking Linux system calls in user space. Thi= s is achieved by > hot-patching the machine code of the standard C library in the memory of > a process.") > (license license:bsd-2)))) > + > +(define-public prusa-slicer > + (package > + (name "prusa-slicer") > + (version "2.3.3") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/prusa3d/PrusaSlicer") > + (commit (string-append "version_" version)))) The =E2=80=98file-name=E2=80=99 field should be set to (file-name (git-file-name name version)) to give the git checkout, in the Guix store, a more descriptive name, otherwise its name is /gnu/store/hc1slayzjz8xrw24q8wzgcs6xrzfk74q-git-checkout which doesn=E2=80=99t really say much. This usually only applies if some k= ind of VCS repository is used, and not if =E2=80=98url-fetch=E2=80=99 is used. > + (sha256 > + (base32 "0w0synqi3iz9aigsgv6x1c6sg123fasbx19h4w3ic1l48r8qmpwm")) > + (patches (search-patches "prusa-slicer-backport-fix-5542.patch")))) > + (build-system cmake-build-system) > + (arguments > + `(#:configure-flags `("-DSLIC3R_GTK=3D3"))) > + (native-inputs > + `(("pkg-config" ,pkg-config))) > + (inputs > + `(("perl" ,perl) > + ("glibc-locales" ,glibc-locales) > + ("adwaita-icon-theme" ,adwaita-icon-theme) > + ("boost" ,boost) > + ("tbb" ,tbb) > + ("curl" ,curl) > + ("zlib" ,zlib) > + ("eigen" ,eigen) > + ("expat" ,expat) > + ("libpng" ,libpng) > + ("mesa" ,mesa) > + ("glew" ,glew) > + ("cereal" ,cereal) > + ("nlopt" ,nlopt) > + ("openvdb" ,openvdb) > + ("cgal" ,cgal) > + ("gmp" ,gmp) > + ("mpfr" ,mpfr) > + ("qhull" ,qhull) > + ("wxwidgets" ,wxwidgets-3.1) > + ("coreutils" ,coreutils) > + ("grep" ,grep) > + ("sed" ,sed) > + ("glibc" ,glibc) These packages are already included in the =E2=80=98cmake-build-system=E2= =80=99 by default, no need to add them explicitly. > + ("gtk+" ,gtk+) > + ("pango" ,pango) > + ("dbus" ,dbus))) > + (home-page "https://www.prusa3d.com/prusaslicer/") > + (synopsis "G-code generator for 3D printers (RepRap, Makerbot, Ultim= aker etc.)") > + (description > + "PrusaSlicer (formerly known as Slic3r Prusa Edition or Slic3r PE) = is > +our own in-house developed slicer software based on the open-source proj= ect > +Slic3r. PrusaSlicer is an open-source, feature-rich, frequently updated > +tool that contains everything you need to export the perfect print files Nit: =E2=80=9Cperfect=E2=80=9D sounds a bit too much like marketing speak; = instead of =E2=80=9Cto export the perfect print files=E2=80=9D, I suggest =E2=80=9Cto = export to print files=E2=80=9D. WDYT? > +for your Original Prusa 3D printer.") > + (license license:agpl3))) According the the LICENSE file, this should be agpl3+ (grep for =E2=80=9Cany later version=E2=80=9D). I didn=E2=80=99t manage to build the package because my machine ran out of memory, but I assume that it built fine for you. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmEY9E8VHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5tBAQALX7j4VFDC+kkWNwy8bSJwLN8lgn VCcHK6Y8uFmI0fMPNG8tKi0mzzc8Grpkn6nmByUM1CAFbZPrQa5MmzuT3wxG25+g zhZ0YGkDsB+wUk2Px9k1pD7GEEcNQBlRDvgpJP8mR62cH/LfZGKAzHv8rhk5c8Bs ymb+DX4VSCFPZsNQPNDIq+1fE2MXT+PZ9YBJBgmKoJ//BO3YF7DefoW1qaCFUOEE LtdyWkpXVSCkOFRbSuOlEEubkzgAtk+Q9Ey3qMh5dMF1eTV9vAXQOGmipiHySWiG TSaQkvSr4JaRJFlqNV8d+HDdHTZc+05/sPVU3TpiZFxDXOZKU+Ge+zvkK/Xvr6+g XX1/AdNKSSFrK/93eXTcXCgk9NAWELsrRHyatv4NU3iUQaG1Gd0arsgKKPEarRNn x4/85O/85jTBb5Z1eH2oEB2v3EfYeCXiHnVrNFjdtZsV9XgcwVAhmqI2qjnEAVh3 NuDWNu5YvzZb7NOkmccmDDngWb71dx+iImR3RoUHovoifWor3Pj2KPCmdYkmbEIW N4H/XJbhHzETZZqZwq8OoTz23Pzl+KVWaB7z2NPrIUAs17J3jF7BcJa6Pet9n6d3 y817Yjfcd7oXZHmg2GoWwOUrigLCDMHCbPbd7785ebJcPUHEMfXMvXCtq8ySzai6 rhsvECaXlbW1Rhll =odR0 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 16 03:49:35 2021 Received: (at 50052) by debbugs.gnu.org; 16 Aug 2021 07:49:35 +0000 Received: from localhost ([127.0.0.1]:48395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFXND-00021o-3d for submit@debbugs.gnu.org; Mon, 16 Aug 2021 03:49:35 -0400 Received: from mail.spbu.ru ([195.70.197.23]:53618 helo=cgp2.pu.ru) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFXN6-00021V-VD for 50052@debbugs.gnu.org; Mon, 16 Aug 2021 03:49:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=spbu.ru; s=20180812; bh=k+ZYF7VHJiCB5U0c+CFagZ8NtHuTaTa4y7ZK5P4cr68=; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; b=Mg1acIVItjoimkg 1JwqhwZG7qbupByEgVYJt6EZCNGorNUi4AwSOD2uiro3TCQsBLHFT5KvplHpKfvRK7JekD2mwH7OH FPXzbF4jFDI0bx7iovl76aFtK6Q/vtc3IjUnJexg1l8s5Fdbxvp6W/5kp3QqHCG3fwYLshuNXy1gj zGg8lTIcrWjdEgshU2+iUl9tFLnNv3mI0hkY8Ri0OIqWmH3ScmnsuGNL9qJQ+XLIWqc/tvJghabgT jrXjaOjzNX8ScaXp6T2JUJXJiylDhGP5PLboEaxmgoDxLtYExSZY3Lwe/fLvmyQzw1bq1xo3hZ4l0 +5qn6Xsl9ICG4GQKOCg== Received: from [172.27.221.159] (account st018947@spbu.ru HELO localhost) by spbu.ru (CommuniGate Pro SMTP 6.2.15) with ESMTPSA id 178567488; Mon, 16 Aug 2021 10:49:17 +0300 Date: Mon, 16 Aug 2021 10:49:17 +0300 From: Ivan Gankevich To: Daniel Trujillo Viedma Subject: Re: [bug#50052] [PATCH] Add prusa-slicer Message-ID: References: <0654f9e7-8c1d-aa4c-3240-54faf3defb2f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50052 Cc: 50052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >Hi! I'm Daniel Trujillo, Hello, Daniel! >I don't know if these kind of packages are of interest, but this is >PrusaSlicer [0], a software to prepare 3D printings (hence I put it in >engineering.scm). I have submitted “prusa-slicer” together with “libigl” on July 23 but did’t get any response: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49713 We should probably check prior submissions to not duplicate our effort. >The packaged version, 2.3.3 is the latest stable available at this >moment. But this version has as important problem [1]: It cannot be >invoked just naming the executable (through $PATH), because then, it >can't locate the resources directory. I learned **the hard way** that >the fix was applied *after* the release of the 2.3.3 version, so I >decided to backport the fix adding a patch because it's a show-stopper >to have to type the path to the executable in /gnu/store/... That's >the reason why the patch attached to this email contains, not only the >additions to engineering.scm, but also a patch that implements the >solution in the version 2.3.3 codebase (It's quite simple, it uses a >boost function to determine the path to the executable rather than >relying on argv[0]). This issue is fixed by adding “-DSLIC3R_FHS=1” to #:configure-flags. No need to patch the source code. >* In order for the above $PATH issue fix to work, it's crucial that >the cmake variable SLIC3R_FHS is set to off. This is the default value >according to the CMakeLists.txt, but because it's so important, >probably it should have been included in the configure-flags argument? >Just for clarity. Set it to ON and you don’t have to patch the code. >I hope everything is in order, I'm looking forward to see your >comments, and hope I can start contributing more packages to Guix!! Prusa slicer bundles a lot of third-party libraries. Most of them contain prusa-specific modifications, but some don’t. “libigl”, “eigen” and “hidapi” can be unbundled, so that we can use versions of these libraries provided by Guix. >+ ("cereal" ,cereal) You need to patch “cereal” library definition in order for Prusa slicer to find this library. I have included this in my patch as well. Regards, Ivan From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 16 15:24:23 2021 Received: (at 50052) by debbugs.gnu.org; 16 Aug 2021 19:24:23 +0000 Received: from localhost ([127.0.0.1]:51044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFiDe-0004gR-TB for submit@debbugs.gnu.org; Mon, 16 Aug 2021 15:24:23 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:45985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFi4i-0004Ry-MI for 50052@debbugs.gnu.org; Mon, 16 Aug 2021 15:15:10 -0400 Received: by mail-wr1-f51.google.com with SMTP id v4so17937474wro.12 for <50052@debbugs.gnu.org>; Mon, 16 Aug 2021 12:15:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:references:to:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=ioT0pKlHJBGmGSRjSqWILThesLH1nuIQbcFfIq4RQYQ=; b=V7PlGAkYL8ejCGO/U9hyuBjXcuSx7ndeUOS+EwBJK2EE8zqw9QTJoqSKqGWv6APGxn sZys3W/LVU56uJHP68iQkJd8pQVDsnZywoH7Kj1KJrT1m+whtEa5W5AB+e+jAfJnHlg5 xWmdwETTrOCw8bRDLX1UmZPcSeDlT/ForynvyOBj0vQ/AeiKDvmW87AvTeAfwQPc+11B o9zQd36YsCHtwaoAn0slkWqiayKmV2i8Wmq2LxFsTZwIovEMa16hjA01yYcNtDad6Geq WfmRegauI7LULxTgiBARKUAlznnyiZuQ04RmmgU9mix4eEy4WJH3xFukkvmDhY8ME1f3 JsZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:references:to:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ioT0pKlHJBGmGSRjSqWILThesLH1nuIQbcFfIq4RQYQ=; b=VTSEDFQ9q949jdw7tm9N4tCggI9JTFv2oBO5Yz1Ix0oNNoMSD75MOYqRgos+ksnawa pqdtjLn0W1xFonCZGqBVspjnb5eOKXU6R8hh3AbMqp0h4v5qPqXzJuJtbMSqRRhZb5dI KHMI/DbnLTb6SbUTpCfIYjx6WBC1pLGSy3dCSe6DQIUF+jMhMQ/bDqkDjOwa0ViD3fcz qlaFd/wOHqe0dgQRpjwGy921gqknk9dk/4tDXtXzEwYQsBMbuL9GEvpZNRShL7k1OV3D 2LCNUN8gxxmpbfzanyofNuWfXxNKRAgMQsc1JhsKy+zG6o+tW5tNHlk20f+SYJnctEug M0vQ== X-Gm-Message-State: AOAM532ekUfEIm4IPH6ZItdfGrZxKNDdpLDmPf6OcvjO9eFAQdvkhuCQ fqFRa8MZRSJ7CvhXygOl+v9MUDgeooKe8w== X-Google-Smtp-Source: ABdhPJxnSXHNHyZ2Nmz3WXsmXjZDSfl/muP69r3KbNAr5xcpZ1+7b/QRfaU0ADSsrqjk/61koiNX0Q== X-Received: by 2002:a5d:4c4e:: with SMTP id n14mr35477wrt.226.1629141302676; Mon, 16 Aug 2021 12:15:02 -0700 (PDT) Received: from [192.168.0.13] ([37.223.119.203]) by smtp.gmail.com with ESMTPSA id x18sm90781wrw.19.2021.08.16.12.15.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Aug 2021 12:15:01 -0700 (PDT) Subject: Fwd: Re: [bug#50052] [PATCH] Add prusa-slicer References: <3fe3d9c3-67c0-2749-808f-a5dc54f08b16@gmail.com> To: Xinglu Chen From: Daniel Trujillo Viedma X-Forwarded-Message-Id: <3fe3d9c3-67c0-2749-808f-a5dc54f08b16@gmail.com> Message-ID: Date: Mon, 16 Aug 2021 21:15:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <3fe3d9c3-67c0-2749-808f-a5dc54f08b16@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50052 X-Mailman-Approved-At: Mon, 16 Aug 2021 15:24:22 -0400 Cc: 50052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sorry, forgot to include debbugs... El 15/8/21 a las 13:02, Xinglu Chen escribió: > On Sat, Aug 14 2021, Daniel Trujillo Viedma wrote: > >> Hi! I'm Daniel Trujillo, >> >> >> This is my first-time-ever contribution to GNU Guix, so please, don't >> hold any nitpick to yourself!! :) >> >> >> I don't know if these kind of packages are of interest, but this is >> PrusaSlicer [0], a software to prepare 3D printings (hence I put it in >> engineering.scm). >> >> The packaged version, 2.3.3 is the latest stable available at this >> moment. But this version has as important problem [1]: It cannot be >> invoked just naming the executable (through $PATH), because then, it >> can't locate the resources directory. I learned **the hard way** that >> the fix was applied *after* the release of the 2.3.3 version, so I >> decided to backport the fix adding a patch because it's a show-stopper >> to have to type the path to the executable in /gnu/store/... That's the >> reason why the patch attached to this email contains, not only the >> additions to engineering.scm, but also a patch that implements the >> solution in the version 2.3.3 codebase (It's quite simple, it uses a >> boost function to determine the path to the executable rather than >> relying on argv[0]). >> >> >> Known improvable things: >> * It's configured to use GTK3. After many attempts to compile it under >> GTK2 in a guix environment, sometimes it detected GTK right away, and >> some ether times I had to add more includes. It wasn't quite reliable >> and, according to the convention followed in gtk+ packages, probably it >> would be better that prusa-slicer uses GTK3, and a hypothetical future >> GTK2 version would be called prusa-slicer-gtk2. >> >> * In order for the above $PATH issue fix to work, it's crucial that the >> cmake variable SLIC3R_FHS is set to off. This is the default value >> according to the CMakeLists.txt, but because it's so important, probably >> it should have been included in the configure-flags argument? Just for >> clarity. > That’s probably a good idea, in case upstream changes the default value > in the future. Great point, I'm doing it! > >> * Currently, the version displayed in the title bar is >> "....2.3.3+UNKNOWN". This is because of another cmake option not set. It >> doesn't have any influence in the software, as far as I know, but it's >> arguably ugly. The version I currently use, doesn't display that in the >> title bar, but it does in the "About" window, and it says >> ".....2.3.3+linux-64". Maybe something like "GNU Guix" would be >> prettier. But if I have to include the arch, I would have to dig deeper >> into package definitions ^_^''' >> >> >> I hope everything is in order, I'm looking forward to see your comments, >> and hope I can start contributing more packages to Guix!! >> >> >> Cheers, >> >> Dani. >> >> >> [0] https://www.prusa3d.es/prusaslicer/ >> >> [1] https://github.com/prusa3d/PrusaSlicer/issues/5542 >> >> >> From 522c1904cf62afac25a9d974091211adac760c25 Mon Sep 17 00:00:00 2001 >> From: Daniel Trujillo Viedma >> Date: Sat, 14 Aug 2021 00:00:55 +0200 >> Subject: [PATCH] Add prusa-slicer >> >> --- > The commit message should be in the GNU ChangeLog format, see the commit > log for examples, or check the manual. > > Sorry!!! I have yet to be familiarized with that format, I'll see this article and examples before submitting the fixes, thanks for notice! >> gnu/packages/engineering.scm | 58 ++++++++++++++++++++++ >> .../patches/prusa-slicer-backport-fix-5542.patch | 31 ++++++++++++ > This patch should also be added to the gnu/local.mk file. Thanks for noticing, it will be added in the next submission. > >> 2 files changed, 89 insertions(+) >> create mode 100644 >> gnu/packages/patches/prusa-slicer-backport-fix-5542.patch >> >> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm >> index 33c124a2ea..047d99c0af 100644 >> --- a/gnu/packages/engineering.scm >> +++ b/gnu/packages/engineering.scm >> @@ -2863,3 +2863,61 @@ for hooking Linux system calls in user space. >> This is achieved by >> hot-patching the machine code of the standard C library in the memory of >> a process.") >> (license license:bsd-2)))) >> + >> +(define-public prusa-slicer >> + (package >> + (name "prusa-slicer") >> + (version "2.3.3") >> + (source >> + (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/prusa3d/PrusaSlicer") >> + (commit (string-append "version_" version)))) > The ‘file-name’ field should be set to > > (file-name (git-file-name name version)) > > to give the git checkout, in the Guix store, a more descriptive name, > otherwise its name is > > /gnu/store/hc1slayzjz8xrw24q8wzgcs6xrzfk74q-git-checkout > > which doesn’t really say much. This usually only applies if some kind > of VCS repository is used, and not if ‘url-fetch’ is used. I thought the checkout directory was temporary, but yes, even in the "origin reference" section of the Manual it says that it's a good idea to set it up when working with VCS. Added! > >> + (sha256 >> + (base32 "0w0synqi3iz9aigsgv6x1c6sg123fasbx19h4w3ic1l48r8qmpwm")) >> + (patches (search-patches "prusa-slicer-backport-fix-5542.patch")))) >> + (build-system cmake-build-system) >> + (arguments >> + `(#:configure-flags `("-DSLIC3R_GTK=3"))) >> + (native-inputs >> + `(("pkg-config" ,pkg-config))) >> + (inputs >> + `(("perl" ,perl) >> + ("glibc-locales" ,glibc-locales) >> + ("adwaita-icon-theme" ,adwaita-icon-theme) >> + ("boost" ,boost) >> + ("tbb" ,tbb) >> + ("curl" ,curl) >> + ("zlib" ,zlib) >> + ("eigen" ,eigen) >> + ("expat" ,expat) >> + ("libpng" ,libpng) >> + ("mesa" ,mesa) >> + ("glew" ,glew) >> + ("cereal" ,cereal) >> + ("nlopt" ,nlopt) >> + ("openvdb" ,openvdb) >> + ("cgal" ,cgal) >> + ("gmp" ,gmp) >> + ("mpfr" ,mpfr) >> + ("qhull" ,qhull) >> + ("wxwidgets" ,wxwidgets-3.1) >> + ("coreutils" ,coreutils) >> + ("grep" ,grep) >> + ("sed" ,sed) >> + ("glibc" ,glibc) > These packages are already included in the ‘cmake-build-system’ by > default, no need to add them explicitly. Yes, I've verified that the package still builds successfully and the program launches. Thanks! > >> + ("gtk+" ,gtk+) >> + ("pango" ,pango) >> + ("dbus" ,dbus))) >> + (home-page "https://www.prusa3d.com/prusaslicer/") >> + (synopsis "G-code generator for 3D printers (RepRap, Makerbot, >> Ultimaker etc.)") >> + (description >> + "PrusaSlicer (formerly known as Slic3r Prusa Edition or Slic3r PE) is >> +our own in-house developed slicer software based on the open-source >> project >> +Slic3r. PrusaSlicer is an open-source, feature-rich, frequently updated >> +tool that contains everything you need to export the perfect print files > Nit: “perfect” sounds a bit too much like marketing speak; instead of > “to export the perfect print files”, I suggest “to export to print > files”. > > WDYT? Absolutely agree. "Perfect" slicer is far from the state-of-the-art. I took this description from their web page, but if we can adapt it to be more objective, I would say: "PrusaSlicer (formerly known as Slic3r Prusa Edition or Slic3r PE) is a slicer software based on the open-source project Slic3r. PrusaSlicer is an open-source, feature-rich, frequently updated tool that contains everything you need to export the print files for your 3D printer.". Is this OK? > >> +for your Original Prusa 3D printer.") >> + (license license:agpl3))) > According the the LICENSE file, this should be agpl3+ (grep for “any > later version”). > > I'm not sure. Probably you guys know more than me about licenses, but it seems to me that this is only AGPL3, because if I `rgrep "any later version"` the entire source code tree, I get 128 hits, mostly from dependencies. And the 3 matches from the LICENSE file are on a conditional voice (""If the Program specifies that a certain numbered version [...] "or any later version" applies to it, you have the option .......""), and the last match is just the instructions that says to put the notice at the start of every source code file (which I think they didn't do. rgrep "GNU Affero General Public" gives me 57 coincidences, mostly from resources, and no one of them mentions "or any later version", so I think it's only AGPL-3). > > > I didn’t manage to build the package because my machine ran out of > memory, but I assume that it built fine for you. :-) Yes, I have suffered this also. To build this in a 16GB RAM machine I had to low the number of cores to 2 (guix build -M1 -c2 prusa-slicer). This prevents more than 2 programs running at the same time, and the memory doesn't get full. I think the hardest part is at the end of the process, when the GUI executable is being linked. I've seen in some packages that there's a comment with the package size. Maybe I'll do the same as a warning that the build process can take up all the RAM available easily. Thank you for your feedback! From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 16 16:09:30 2021 Received: (at 50052) by debbugs.gnu.org; 16 Aug 2021 20:09:30 +0000 Received: from localhost ([127.0.0.1]:51087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFivG-0005qJ-Cx for submit@debbugs.gnu.org; Mon, 16 Aug 2021 16:09:30 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:36378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFivB-0005pz-24 for 50052@debbugs.gnu.org; Mon, 16 Aug 2021 16:09:24 -0400 Received: by mail-wr1-f43.google.com with SMTP id k8so6300145wrn.3 for <50052@debbugs.gnu.org>; Mon, 16 Aug 2021 13:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=6kGK5jiOx3Dy+KMebAi5MSl8UPsrI/AFYnQnlzt3SrA=; b=ALCcVB2Z6ryUgyoyVFARwz9SEKebo4Hemw51/J6ws4zDJiorBvEKkNQiJShf63SXN1 BuYAZGMhBfoz2hLlpuGJeB+p65/SEuzVPvdu/J7CarZ0k+W7ZCePuXG9IpZ7bypNwI4m 3AI7zcrPifXE3Fuh/ojInso5VxZbQXsaWUZOFpXGtmviA8wt13V/DEkvg68875uCnH+A L56ImofeuT7IjKTGYBMEIvh1Ks0Luor8bI6T8Ozja+Sm0tvabgLQDPYRuHBK8YmMDnSt fesbRSkZh4uLnzeaoD5XQeJSs/ZjimuIPfb/JESdsTQ0voe/Z/iBGJOWLxe7gs73QX+P cXgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=6kGK5jiOx3Dy+KMebAi5MSl8UPsrI/AFYnQnlzt3SrA=; b=AmvDj2KAZIwDChA4jJ+wRQVQw5521x5GnszwpuBULMspR9LQ4BOfRXeOyJC1IZh7S8 1D97zSXuX7PcXavhAIqlAF0YK7NtEJfplNxp/aVgNqG5ehcxalXfdv1nKaM6+A8yY46w vmV0LnK0PQr63P5aU/GS66oAk51NMEsxxL9fOnQgK1k0rsW9qZMleug1kZ3GoLKlsWWB TYa/JJ9wjomzrFVw8n+dnl04QIxOODs5m+gsaY0etyUTRexRb0SR4rNzEm11GoRWK6KY 1YbPtvDWak7tggXPizXsUueatiJ6JXYpXLOW+5t1GF0VoUmmTOybVzLAoUSQDb+TNUCK zdog== X-Gm-Message-State: AOAM531wpCEviN2eEfx1rA9JQVZgIbUYoSh+qcnd8yoBuUhshJFMZHgJ +6k44rgBig1FWvF75OO7+wM/mjX6LK/UXg== X-Google-Smtp-Source: ABdhPJzkAKLNHMVoqXSJlLYH1GMCyF8QSyUx29uZY1SlsqD1ufyOVXxgRD4RWA2rULk1DAJ6IiuPGg== X-Received: by 2002:adf:e588:: with SMTP id l8mr245894wrm.16.1629144555162; Mon, 16 Aug 2021 13:09:15 -0700 (PDT) Received: from [192.168.0.13] ([37.223.119.203]) by smtp.gmail.com with ESMTPSA id a9sm226870wrv.37.2021.08.16.13.09.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Aug 2021 13:09:14 -0700 (PDT) Subject: Re: [bug#50052] [PATCH] Add prusa-slicer To: Ivan Gankevich References: <0654f9e7-8c1d-aa4c-3240-54faf3defb2f@gmail.com> From: Daniel Trujillo Viedma Message-ID: <1e9213ed-4630-44a0-53c4-747f41f97ad7@gmail.com> Date: Mon, 16 Aug 2021 22:09:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 50052 Cc: 50052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) Hi, Ivan! You're completely right, I should have to searched more thoroughly any ongoing effort packaging prusa-slicer. At this point, the best thing I should do is to send an email to the list to discard my package and encourage to take a look at yours, since are way more advanced than mine. You are also right with the -DSLIC3R_FHS=1. I thought that that will make the executable look for the resources outside the /gnu/stare folder, where nothing would be found, but it works, can you briefly point me to what is happening? Thank you so much! El 16/8/21 a las 9:49, Ivan Gankevich escribió: >> Hi! I'm Daniel Trujillo, > > Hello, Daniel! > > >> I don't know if these kind of packages are of interest, but this is >> PrusaSlicer [0], a software to prepare 3D printings (hence I put it >> in engineering.scm). > > I have submitted “prusa-slicer” together with “libigl” on July 23 but > did’t get any > response: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49713 > > We should probably check prior submissions to not duplicate our effort. > > >> The packaged version, 2.3.3 is the latest stable available at this >> moment. But this version has as important problem [1]: It cannot be >> invoked just naming the executable (through $PATH), because then, it >> can't locate the resources directory. I learned **the hard way** that >> the fix was applied *after* the release of the 2.3.3 version, so I >> decided to backport the fix adding a patch because it's a >> show-stopper to have to type the path to the executable in >> /gnu/store/... That's the reason why the patch attached to this email >> contains, not only the additions to engineering.scm, but also a patch >> that implements the solution in the version 2.3.3 codebase (It's >> quite simple, it uses a boost function to determine the path to the >> executable rather than relying on argv[0]). > > This issue is fixed by adding “-DSLIC3R_FHS=1” to #:configure-flags. > No need to patch the source code. > > >> * In order for the above $PATH issue fix to work, it's crucial that >> the cmake variable SLIC3R_FHS is set to off. This is the default >> value according to the CMakeLists.txt, but because it's so important, >> probably it should have been included in the configure-flags >> argument? Just for clarity. > > Set it to ON and you don’t have to patch the code. > > >> I hope everything is in order, I'm looking forward to see your >> comments, and hope I can start contributing more packages to Guix!! > > Prusa slicer bundles a lot of third-party libraries. Most of them contain > prusa-specific modifications, but some don’t. “libigl”, “eigen” and > “hidapi” can be > unbundled, so that we can use versions of these libraries provided by > Guix. > >> +         ("cereal" ,cereal) > > You need to patch “cereal” library definition in order for Prusa > slicer to find > this library. I have included this in my patch as well. > > > Regards, > Ivan From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 17 03:19:11 2021 Received: (at 50052) by debbugs.gnu.org; 17 Aug 2021 07:19:11 +0000 Received: from localhost ([127.0.0.1]:51537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFtNP-0005Wu-6k for submit@debbugs.gnu.org; Tue, 17 Aug 2021 03:19:11 -0400 Received: from mail.spbu.ru ([195.70.197.23]:51886 helo=cgp2.pu.ru) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFtNL-0005WN-JW for 50052@debbugs.gnu.org; Tue, 17 Aug 2021 03:19:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=spbu.ru; s=20180812; bh=BSjFC6hAGvcZ6Cw6TbB80yf/p10OPtVg0ctLR5Co6bM=; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:References: In-Reply-To:Subject:CC:To:From:Date; b=hhGNMXWQvDvhIUYBfKrrKN2fkVbWPumxntYEZS KZymzLh7NCeSZBJPMfz4snE6LuXAXKtMLgvUwqZPPuokdN0D6r/aPLmxgdyDV4pdfuslUofnUnkm0 Zp3KGiHl2jzF2klEmvUwJNkdBBdZ2TXfpbAaRrvh5yMAL1bJbtBJpprFlaxo0p+SKAFtnSbJb61AF 2n8+uDSk6C7G5ka2dVSUShYjrxti9NcgFt7g5ED5w+6OFfPZkVVPVhknCDU7qoHUwa8grBQwcX/nv o6dtUexd2Bz5l9mK/xZN03AJFfvYFZOtF5UjdoNYpfJP+hE5sLl3eCjSKYjq0bFqmp7fLCe5g== Received: from [188.170.80.225] (account st018947@spbu.ru HELO [127.0.0.1]) by spbu.ru (CommuniGate Pro SMTP 6.2.15) with ESMTPSA id 178803349; Tue, 17 Aug 2021 10:18:59 +0300 Date: Tue, 17 Aug 2021 10:18:57 +0300 From: Ivan Gankevich To: Daniel Trujillo Viedma Subject: Re: [bug#50052] [PATCH] Add prusa-slicer User-Agent: K-9 Mail for Android In-Reply-To: <1e9213ed-4630-44a0-53c4-747f41f97ad7@gmail.com> References: <0654f9e7-8c1d-aa4c-3240-54faf3defb2f@gmail.com> <1e9213ed-4630-44a0-53c4-747f41f97ad7@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50052 Cc: 50052@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >You're completely right, I should have to searched more thoroughly any=20 >ongoing effort packaging prusa-slicer=2E At this point, the best thing I= =20 >should do is to send an email to the list to discard my package and=20 >encourage to take a look at yours, since are way more advanced than mine= =2E Thanks! Lets hope it will be accepted soon=2E >You are also right with the -DSLIC3R_FHS=3D1=2E I thought that that will= =20 >make the executable look for the resources outside the /gnu/stare=20 >folder, where nothing would be found, but it works, can you briefly=20 >point me to what is happening? Thank you so much! That is a good question for prusa slicer developers :-) My guess is that u= sing file system hierarchy standard (-DSLIC3R_FHS=3D1) means that the proje= ct uses default procedure to install the package which is modified by Guix = to install it to /gnu/store directory=2E But when this option is disabled t= he package is installed in the same directory using non standard procedure = about which Guix knows nothing=2E It could also be a bug in prusa slicer bu= ild files=2E From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 17 17:59:54 2021 Received: (at 50052-done) by debbugs.gnu.org; 17 Aug 2021 21:59:55 +0000 Received: from localhost ([127.0.0.1]:54345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mG77i-0003ma-QQ for submit@debbugs.gnu.org; Tue, 17 Aug 2021 17:59:54 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:44610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mG77g-0003mL-2Z for 50052-done@debbugs.gnu.org; Tue, 17 Aug 2021 17:59:53 -0400 Received: by mail-wr1-f48.google.com with SMTP id x12so211768wrr.11 for <50052-done@debbugs.gnu.org>; Tue, 17 Aug 2021 14:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=l4mL3SJkl1nd1o9I0wQmZerhLEeOkYc8m4n5DNzHeh0=; b=F9S7BimIQFEGwdPDyy7D7CxUClxyX/sleijSB3m16ip13pMW05fMfy9rM3CaAzegNf uT2Aho+MBBCTMVfyJnbNW+fWszMoRp6WIm/KTiLF/5GdbQdHXHxBu2wTOEMqOfMb2o0r 0xZbEEXO0CRIUCe+XA1Fn3dwNo3yg8uX6MGLtXsjK4+MHK0nKhBOg8E471wXbQ8Uls+D BaneefesdOu41QUHv8r3w1B/H1Ewg+ddQdCAqO2kEolhS58QjR4nJUKnnEusV7yK7DXf RAmnTd4E2HGwFTt01EWfU9lq4gArrasAjScwYAObcRs/Kcmw2DHVnvt9ct4elA8wlRJl nfAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=l4mL3SJkl1nd1o9I0wQmZerhLEeOkYc8m4n5DNzHeh0=; b=kh1BsVWubGOcaiF4uqccerz7onVUKfcWaKu6Y0oG6WWNgGLzDscCzVIFerrXjZKC4L 5rIihCp99FteDozxzmOVZVtZ6/zyQfS0DH8jpZtBTj7vrHPjBMF4g+vPKmX2JEhZAXMX 8LpiTRrPnHSpjiVYL+kjZDPaeeDyh9wKOHmN9pnu9+AZxG7jEoZec0LgneRieehxIj1/ DGERVoydwEnFmBVVtq+Ak4RdXV2RqcM4MJ0/8LWP/BaoJCnT7YNrMgYdTYoXXGETjEUB IXrT8OIBx6PIwvc3xOTkWWzeSd3hhb3Q0T/S1KJvu9cLsB+7vtnm3zptph1TKNgCP+if BwVQ== X-Gm-Message-State: AOAM532fWjMu+To9/STs6bWOAQIJXXEfB8WKl9PuKg95Wu2lHZOV8Gn+ yyRAy1zCU4Cn9vZre54j5luYlc5kokuuHg== X-Google-Smtp-Source: ABdhPJwR2NL7/TfgyngXp1gQfSYiFerF5FvaMlGEzvNnbR8VG8XfTYyXszNTSfiWO7adOWKRNMP3yw== X-Received: by 2002:a5d:45c9:: with SMTP id b9mr6774014wrs.395.1629237586127; Tue, 17 Aug 2021 14:59:46 -0700 (PDT) Received: from [192.168.0.13] ([37.223.119.203]) by smtp.gmail.com with ESMTPSA id e17sm3702184wrs.78.2021.08.17.14.59.45 for <50052-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Aug 2021 14:59:45 -0700 (PDT) Subject: Re: [bug#50052] [PATCH] Add prusa-slicer To: 50052-done@debbugs.gnu.org References: <0654f9e7-8c1d-aa4c-3240-54faf3defb2f@gmail.com> From: Daniel Trujillo Viedma Message-ID: Date: Tue, 17 Aug 2021 23:59:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 50052-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) Closing this in favor of Ivan's 49713 (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49713), which is more complete and advanced than mine. Thanks to Xinglu Chen and Ivan Gankevich (and everyone interested) for their time and their valuable feedback, I learned a lot. Hope to see you soon with a (hopefully not WIP) new package! Cheers, Dani. From unknown Sat Sep 20 08:01:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 15 Sep 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator