GNU bug report logs - #50042
26.3; Post-command hooks slow with M-x commands

Previous Next

Package: emacs;

Reported by: sk <at> nomistech.com

Date: Fri, 13 Aug 2021 11:54:01 UTC

Severity: normal

Found in version 26.3

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Simon Katz <sk <at> nomistech.com>
Cc: 50042 <at> debbugs.gnu.org
Subject: bug#50042: 26.3; Post-command hooks slow with M-x commands
Date: Fri, 13 Aug 2021 14:27:42 +0200
Simon Katz <sk <at> nomistech.com> writes:

> Here's a startup file that can be used to show this (also at

Simpler repro:

(add-hook 'post-command-hook
	  (lambda ()
	    (let ((inhibit-message t))
	      (message "foo: %s" this-command))))
(display-buffer "*Messages*")

M-x previous-line

I think this has something to do with the

You can run the command ‘previous-line’ with C-p

stuff -- if the `M-x' command in question isn't bound to anything,
`post-command-hook' is run immediately instead of after a two-second
timeout.

Hm...  yup:

`execute-extended-command' ends with

        (when binding
          (with-temp-message
              (format-message "You can run the command `%s' with %s"
                              function
                              (if (stringp binding)
                                  (concat "M-x " binding " RET")
                                (key-description binding)))
            (sit-for (if (numberp suggest-key-bindings)
                         suggest-key-bindings
                       2))))))))

So presumably `post-command-hook' isn't run after that timeout has
completed.

Uhm...  anybody got any ideas how to fix this?  I mean, in one way it's
behaving as it's supposed to -- the command really isn't finished after
this sit-for has finished.

On the other hand, it's pretty awkward.

Could we yank this out of the flow and run it from a timer (fired
immediately) instead?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 3 years and 331 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.