From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 10 17:04:46 2021 Received: (at submit) by debbugs.gnu.org; 10 Aug 2021 21:04:46 +0000 Received: from localhost ([127.0.0.1]:60930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDYvS-00004w-G4 for submit@debbugs.gnu.org; Tue, 10 Aug 2021 17:04:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:43702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDYvM-0008WQ-Oi for submit@debbugs.gnu.org; Tue, 10 Aug 2021 17:04:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDYvM-0000oH-HP for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 17:04:36 -0400 Received: from server.a16n.net ([178.33.238.77]:37724) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDYvJ-0004v8-SJ for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 17:04:36 -0400 Received: from ws.localdomain (arennes-662-1-84-172.w2-14.abo.wanadoo.fr [2.14.50.172]) by server.a16n.net (Postfix) with ESMTPSA id 8D59A43E09BD for ; Tue, 10 Aug 2021 23:04:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=a16n.net; s=a16n; t=1628629471; bh=RvHTVktlQLhxD+J8dANJFQM2am5fDgmG2WeOaNQ+9os=; h=From:To:Subject:Date; b=gMZDEoa7ljBodTMj2G9GaTXTfmwLd2syDQbZffx9CQxD9A54sitjyN/SkQnnEFpNE dn1nipIp8os2sHMq9/d4m2+wGSFZEvU8vWdqN7cIpw+8wN8XblhEmDhiIvH3pUregx pk6LtqIUcli6EZZNcpqtreyFuIkP+7dPjsSumw3FxBWMIskFQBjGY9/JdNU6tHcbff fvhvf+/J2n2Vfo9SGc3+KdpYw4LdfBP/BQpbr40g3BhQUH9iAa+A+SZKQ0ax//Nv0f WiwRRwwBc/zzmI6Pqqmr8FRzEMkmX6tAmutaoxv9aStqsrKe4ZoXlGHQhT9lFed7Lu fZceDgxBR8Lbg== Received: by ws.localdomain (Postfix, from userid 1000) id B78A374235E; Tue, 10 Aug 2021 23:04:30 +0200 (CEST) From: =?utf-8?Q?Peter_M=C3=BCnster?= To: bug-gnu-emacs@gnu.org Subject: 27.2; visible marks in the thumbnail buffer Date: Tue, 10 Aug 2021 23:04:30 +0200 Message-ID: <87fsvhko4h.fsf@a16n.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=178.33.238.77; envelope-from=pm@a16n.net; helo=server.a16n.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, It would be nice, if the marks were visible in image-dired-thumbnail-mode. Here is a patch, that uses a background color for the thumbnails: * lisp/image-dired.el (image-dired-thumb-update-marks): New function that makes the marks visible in the thumbnail buffer. diff --git a/lisp/image-dired.el b/lisp/image-dired.el index 8a065f2e6f..eb2b092059 100644 --- a/lisp/image-dired.el +++ b/lisp/image-dired.el @@ -460,6 +460,17 @@ This is where you see the cursor." :type 'integer :group 'image-dired) +(defcustom image-dired-thumb-visible-marks nil + "Make marks visible in thumbnail buffer. +If non-nil, apply `image-dired-thumb-mark-color' to background of marked images." + :type 'boolean + :group 'image-dired) + +(defcustom image-dired-thumb-mark-color "orange" + "Background-color for marked images in thumbnail buffer." + :type 'string + :group 'image-dired) + (defcustom image-dired-line-up-method 'dynamic "Default method for line-up of thumbnails in thumbnail buffer. Used by `image-dired-display-thumbs' and other functions that needs @@ -2311,6 +2322,32 @@ non-nil." (image-dired-track-original-file)) (image-dired-display-thumb-properties)) +(defun image-dired-thumb-file-marked-p () + "Check if file is marked in associated dired buffer." + (let ((file-name (image-dired-original-file-name)) + (dired-buf (image-dired-associated-dired-buffer))) + (if (and dired-buf file-name) + (with-current-buffer dired-buf + (if (dired-goto-file file-name) + (image-dired-dired-file-marked-p)))))) + +(defun image-dired-thumb-update-marks () + "Update the marks in the thumbnail buffer." + ;; TODO: only called by image-dired-mouse-toggle-mark but there are + ;; certainly other places, where it should be called too. + (when image-dired-thumb-visible-marks + (with-current-buffer image-dired-thumbnail-buffer + (save-excursion + (goto-char (point-min)) + (let ((inhibit-read-only t)) + (while (not (eobp)) + (if (image-dired-thumb-file-marked-p) + (add-face-text-property + (point) (1+ (point)) + (list :background image-dired-thumb-mark-color)) + (remove-text-properties (point) (1+ (point)) '(face nil))) + (forward-char))))))) + (defun image-dired-mouse-toggle-mark-1 () "Toggle dired mark for current thumbnail. Track this in associated dired buffer if `image-dired-track-movement' is @@ -2335,7 +2372,8 @@ non-nil." (forward-char)))) (mouse-set-point event) (goto-char (posn-point (event-end event))) - (image-dired-mouse-toggle-mark-1))) + (image-dired-mouse-toggle-mark-1)) + (image-dired-thumb-update-marks)) (defun image-dired-dired-display-properties () "Display properties for dired file in the echo area." What do think about that? -- Peter From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 11 08:04:04 2021 Received: (at 49988) by debbugs.gnu.org; 11 Aug 2021 12:04:04 +0000 Received: from localhost ([127.0.0.1]:33702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDmxn-0008U2-Sj for submit@debbugs.gnu.org; Wed, 11 Aug 2021 08:04:04 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDmxl-0008TU-Dk for 49988@debbugs.gnu.org; Wed, 11 Aug 2021 08:04:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=D+0+emzOVFDE0PI99wlfGBTB9j9aIMjQfh4Pk1/zyDk=; b=MhuCYnU/dAL2SP7rKaTDCrmkl0 WTdL5brnLnc4ngBkMWYEvzIi/9AmZKbm53Nr5W0uWiiN1rx4zdxEH9DzHcJ7CA5xIB2trb8OeLfmW Qjv1VUXjXAGgRENLKKizzwdPhbk0FmfvhBfR5oRkyZi7Ry0EKNck16XBzvT8s/dHwzAo=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDmxa-0007gR-60; Wed, 11 Aug 2021 14:03:54 +0200 From: Lars Ingebrigtsen To: Peter =?utf-8?Q?M=C3=BCnster?= Subject: Re: bug#49988: 27.2; visible marks in the thumbnail buffer References: <87fsvhko4h.fsf@a16n.net> Date: Wed, 11 Aug 2021 14:03:49 +0200 In-Reply-To: <87fsvhko4h.fsf@a16n.net> ("Peter =?utf-8?Q?M=C3=BCnster=22's?= message of "Tue, 10 Aug 2021 23:04:30 +0200") Message-ID: <875ywctcgq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Peter Münster writes: > Here is a patch, that uses a background color for the thumbnails: Thanks; applied to Emacs 28, but with some changes -- I made the colour into a face. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49988 Cc: 49988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Peter M=C3=BCnster writes: > Here is a patch, that uses a background color for the thumbnails: Thanks; applied to Emacs 28, but with some changes -- I made the colour into a face. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 11 08:04:09 2021 Received: (at control) by debbugs.gnu.org; 11 Aug 2021 12:04:09 +0000 Received: from localhost ([127.0.0.1]:33705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDmxt-0008UK-4D for submit@debbugs.gnu.org; Wed, 11 Aug 2021 08:04:09 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDmxr-0008U0-UZ for control@debbugs.gnu.org; Wed, 11 Aug 2021 08:04:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=f/0B5Ptv0+K5P4+xYfVHmRdnGDuGCfCo322wwMk6C7Q=; b=UvU9OIl6UTjwnRiStOo+xGxCY8 ncU2HZJru1QFqqGPr6mr3PbTgXVKoo1kfSdrhJRmpU/+m0uXFQOCFnW6XsR0b5OXhSuQ6MiwIhwF+ WxjUQ9ojTz6DXXoC4d8DbrB8w+WiNguDOUVosq8wEHMX0eqeUzf34j+XXCwtkcCdxsAE=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDmxk-0007gZ-2v for control@debbugs.gnu.org; Wed, 11 Aug 2021 14:04:02 +0200 Date: Wed, 11 Aug 2021 14:03:57 +0200 Message-Id: <874kbwtcgi.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #49988 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 49988 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 49988 28.1 quit From unknown Sun Jun 22 08:07:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 09 Sep 2021 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator