GNU bug report logs - #49978
28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH]

Previous Next

Full log

Message #8 received at 49978 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: 49978 <at> debbugs.gnu.org
Subject: Re: bug#49978: 28.0.50;
 grep-highlight-matches auto-detection broken on macOS [PATCH]
Date: Tue, 10 Aug 2021 16:23:05 +0300

> From: Mattias Engdegård <mattiase <at> acm.org>
> Date: Tue, 10 Aug 2021 14:54:43 +0200
> 
> The auto-detection of colourised grep fails on macOS (and presumably BSD in general) because grep --help exits with a nonzero status (while still printing a useful option summary).
> 
> We should just ignore the exit status. Anyone against the attached patch?

Not me (this time ;-).  Although perhaps we should strengthen the
search string to be sure we don't hit some false positive: "--color"
sounds a bit too general, no?  Or do you think it's good enough even
if "--help" causes a non-zero exit code?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.