GNU bug report logs - #49978
28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH]

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#49978: closed (28.0.50; grep-highlight-matches auto-detection
 broken on macOS [PATCH])
Date: Tue, 10 Aug 2021 15:12:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 10 Aug 2021 17:11:42 +0200
with message-id <1DA84CE4-E882-4DF1-B2C3-674FDF1B5D78 <at> acm.org>
and subject line Re: bug#49978: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH]
has caused the debbugs.gnu.org bug report #49978,
regarding 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH]
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
49978: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49978
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mattias Engdegård <mattiase <at> acm.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH]
Date: Tue, 10 Aug 2021 14:54:43 +0200

[Message part 3 (text/plain, inline)]

The auto-detection of colourised grep fails on macOS (and presumably BSD in general) because grep --help exits with a nonzero status (while still printing a useful option summary).

We should just ignore the exit status. Anyone against the attached patch?

[grep-highlight-matches-autodetect.diff (application/octet-stream, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Mattias Engdegård <mattiase <at> acm.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 49978-done <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#49978: 28.0.50; grep-highlight-matches auto-detection broken
 on macOS [PATCH]
Date: Tue, 10 Aug 2021 17:11:42 +0200

10 aug. 2021 kl. 15.57 skrev Eli Zaretskii <eliz <at> gnu.org>:

> I think just looking for "--color[[]?=" should go a long way towards
> avoiding false positives.

Right, pushed something like that. Thank you!

> Btw, is this usage message translatable?  If so, perhaps we should
> inject LC_ALL=C when running the probe?

I don't think we need to bother -- even if the message is translated the options themselves are not.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.