GNU bug report logs - #49978
28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH]

Previous Next

Full log

Message #14 received at 49978 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mattias Engdegård <mattiase <at> acm.org>,
 Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 49978 <at> debbugs.gnu.org
Subject: Re: bug#49978: 28.0.50; grep-highlight-matches auto-detection broken
 on macOS [PATCH]
Date: Tue, 10 Aug 2021 16:57:41 +0300

> From: Mattias Engdegård <mattiase <at> acm.org>
> Date: Tue, 10 Aug 2021 15:39:04 +0200
> Cc: 49978 <at> debbugs.gnu.org
> 
> 10 aug. 2021 kl. 15.23 skrev Eli Zaretskii <eliz <at> gnu.org>:
> 
> > Although perhaps we should strengthen the
> > search string to be sure we don't hit some false positive: "--color"
> > sounds a bit too general, no?  Or do you think it's good enough even
> > if "--help" causes a non-zero exit code?
> 
> I honestly don't know. The patch works here (obviously) but strengthening it using a regexp to avoid matching "--colorise", say, probably won't hurt. Not that it's very likely that this would ever make a difference, but if you think that it's better safe then sorry then I'll do that.

I think just looking for "--color[[]?=" should go a long way towards
avoiding false positives.  WDYT?

Lars, any comments?

Btw, is this usage message translatable?  If so, perhaps we should
inject LC_ALL=C when running the probe?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.