From unknown Wed Aug 20 01:18:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#49978 <49978@debbugs.gnu.org> To: bug#49978 <49978@debbugs.gnu.org> Subject: Status: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH] Reply-To: bug#49978 <49978@debbugs.gnu.org> Date: Wed, 20 Aug 2025 08:18:05 +0000 retitle 49978 28.0.50; grep-highlight-matches auto-detection broken on macO= S [PATCH] reassign 49978 emacs submitter 49978 Mattias Engdeg=C3=A5rd severity 49978 normal tag 49978 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 10 08:55:09 2021 Received: (at submit) by debbugs.gnu.org; 10 Aug 2021 12:55:09 +0000 Received: from localhost ([127.0.0.1]:58683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDRHh-0005dp-Bb for submit@debbugs.gnu.org; Tue, 10 Aug 2021 08:55:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:34436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDRHe-0005dg-9b for submit@debbugs.gnu.org; Tue, 10 Aug 2021 08:55:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDRHd-0006ac-ME for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 08:55:06 -0400 Received: from mail1444c50.megamailservers.eu ([91.136.14.44]:48924 helo=mail264c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDRHa-0002um-V7 for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 08:55:05 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1628600086; bh=Xqjzt2q/FE4X16V3bEOdYDSK48TqB6msytT6nK+FWGg=; h=From:Subject:Date:To:From; b=b8fbdWVsMwapgiwkuQ0W4PdT4L8hiI4y75/Zu5hdj1vuHX0ShlxX8EbpoqFOJDlSw AqX9PlCNiIbHG25qtEg+s2WT9d9CSyev1c7xEjAo4Sjn99xPVTYuoYYnikycLW2nXD Hg8ZG7Ne7LuYg/HG26cimNATjFEQcDrSVZ22cjjA= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail264c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17ACsiI6007684 for ; Tue, 10 Aug 2021 12:54:46 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_B99AD926-A9B5-4046-8AED-4A6B574B9BCD" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH] Message-Id: <6D6B9A78-50EC-4AEC-80AA-EB12C608EB48@acm.org> Date: Tue, 10 Aug 2021 14:54:43 +0200 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F16.61127716.0023, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Xdb3M7x5 c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=M51BFTxLslgA:10 a=-McoaDol7z_dJMetT8AA:9 a=CjuIK1q_8ugA:10 a=jTK3ahojEUwcQVQlomkA:9 a=De_Ol2h6w80A:10 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.14.44; envelope-from=mattiase@acm.org; helo=mail264c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --Apple-Mail=_B99AD926-A9B5-4046-8AED-4A6B574B9BCD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii The auto-detection of colourised grep fails on macOS (and presumably BSD = in general) because grep --help exits with a nonzero status (while still = printing a useful option summary). We should just ignore the exit status. Anyone against the attached = patch? --Apple-Mail=_B99AD926-A9B5-4046-8AED-4A6B574B9BCD Content-Disposition: attachment; filename=grep-highlight-matches-autodetect.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="grep-highlight-matches-autodetect.diff" Content-Transfer-Encoding: 7bit diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el index 8f0a5acf70..a33a247d9b 100644 --- a/lisp/progmodes/grep.el +++ b/lisp/progmodes/grep.el @@ -696,11 +696,11 @@ grep-compute-defaults (when (eq grep-highlight-matches 'auto-detect) (setq grep-highlight-matches (with-temp-buffer - (and (grep-probe grep-program '(nil t nil "--help")) - (progn - (goto-char (point-min)) - (search-forward "--color" nil t)) - ;; Windows and DOS pipes fail `isatty' detection in Grep. + ;; The "grep --help" exit status varies; pay no attention to it. + (grep-probe grep-program '(nil t nil "--help")) + (goto-char (point-min)) + (and (search-forward "--color" nil t) + ;; Windows and DOS pipes fail `isatty' detection in Grep. (if (memq system-type '(windows-nt ms-dos)) 'always 'auto))))) --Apple-Mail=_B99AD926-A9B5-4046-8AED-4A6B574B9BCD-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 10 09:23:03 2021 Received: (at 49978) by debbugs.gnu.org; 10 Aug 2021 13:23:04 +0000 Received: from localhost ([127.0.0.1]:58738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDRih-0006MS-Ng for submit@debbugs.gnu.org; Tue, 10 Aug 2021 09:23:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDRif-0006Ll-K0 for 49978@debbugs.gnu.org; Tue, 10 Aug 2021 09:23:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48820) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDRia-0001mY-1A; Tue, 10 Aug 2021 09:22:56 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4204 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDRiZ-0000CX-Kn; Tue, 10 Aug 2021 09:22:55 -0400 Date: Tue, 10 Aug 2021 16:23:05 +0300 Message-Id: <83tujxfn7q.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <6D6B9A78-50EC-4AEC-80AA-EB12C608EB48@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Tue, 10 Aug 2021 14:54:43 +0200) Subject: Re: bug#49978: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH] References: <6D6B9A78-50EC-4AEC-80AA-EB12C608EB48@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49978 Cc: 49978@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Tue, 10 Aug 2021 14:54:43 +0200 > > The auto-detection of colourised grep fails on macOS (and presumably BSD in general) because grep --help exits with a nonzero status (while still printing a useful option summary). > > We should just ignore the exit status. Anyone against the attached patch? Not me (this time ;-). Although perhaps we should strengthen the search string to be sure we don't hit some false positive: "--color" sounds a bit too general, no? Or do you think it's good enough even if "--help" causes a non-zero exit code? From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 10 09:39:14 2021 Received: (at 49978) by debbugs.gnu.org; 10 Aug 2021 13:39:14 +0000 Received: from localhost ([127.0.0.1]:58760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDRyL-0006l8-Pv for submit@debbugs.gnu.org; Tue, 10 Aug 2021 09:39:14 -0400 Received: from mail235c50.megamailservers.eu ([91.136.10.245]:37010 helo=mail56c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDRyH-0006kv-RH for 49978@debbugs.gnu.org; Tue, 10 Aug 2021 09:39:12 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1628602747; bh=VA4bjuGptcpQRegoo5vjo8hocZxJblLu09SRxmJ6ta4=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=VwPbXLIBWpTUOyoJGeAbCTP+mE1gLx5Gzm950csDRu9wmRwl9yJjyPyUB4cuHYaXO n4DI7V6VFJ9LDMOdfzkVtfy0F0Kd/TqoWqCr5Py4r8kHR9Egf+pTYxiT57nZEhhXjL 2IbayM/kInbpQtMAqSM5MuhtXv+5IzxAO8dyCRs0= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17ADd5Yv023063; Tue, 10 Aug 2021 13:39:07 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#49978: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH] From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83tujxfn7q.fsf@gnu.org> Date: Tue, 10 Aug 2021 15:39:04 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <3E02EB6C-A3F9-482B-AEF3-50D68DAFAA0A@acm.org> References: <6D6B9A78-50EC-4AEC-80AA-EB12C608EB48@acm.org> <83tujxfn7q.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F15.6112817B.004C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=F5gpiZpN c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=7juiuxWHQv7IaK6hktsA:9 a=PIRxba_xLfsokdVT:21 a=gt-EmsutlMfiVp--:21 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 10 aug. 2021 kl. 15.23 skrev Eli Zaretskii : > Although perhaps we should strengthen the > search string to be sure we don't hit some false positive: "--color" > sounds a bit too general, no? Or do you think it's good enough even > if "--help" c [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 49978 Cc: 49978@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 10 aug. 2021 kl. 15.23 skrev Eli Zaretskii : > Although perhaps we should strengthen the > search string to be sure we don't hit some false positive: "--color" > sounds a bit too general, no? Or do you think it's good enough even > if "--help" causes a non-zero exit code? I honestly don't know. The patch works here (obviously) but = strengthening it using a regexp to avoid matching "--colorise", say, = probably won't hurt. Not that it's very likely that this would ever make = a difference, but if you think that it's better safe then sorry then = I'll do that. For the record, on this Mac I get: $ grep --help usage: grep [-abcDEFGHhIiJLlmnOoqRSsUVvwxZ] [-A num] [-B num] [-C[num]] [-e pattern] [-f file] [--binary-files=3Dvalue] [--color=3Dwhen] [--context[=3Dnum]] [--directories=3Daction] [--label] = [--line-buffered] [--null] [pattern] [file ...] $ grep --version grep (BSD grep) 2.5.1-FreeBSD The exit status is probably a red herring; we do not seem to gain any = useful information from it. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 10 09:57:41 2021 Received: (at 49978) by debbugs.gnu.org; 10 Aug 2021 13:57:41 +0000 Received: from localhost ([127.0.0.1]:60133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDSGD-0007Z9-4F for submit@debbugs.gnu.org; Tue, 10 Aug 2021 09:57:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDSGB-0007Yx-9U for 49978@debbugs.gnu.org; Tue, 10 Aug 2021 09:57:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50056) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDSG5-0004W1-NI; Tue, 10 Aug 2021 09:57:33 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2369 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDSG4-0007Ur-Fa; Tue, 10 Aug 2021 09:57:33 -0400 Date: Tue, 10 Aug 2021 16:57:41 +0300 Message-Id: <83pmulflm2.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , Lars Ingebrigtsen In-Reply-To: <3E02EB6C-A3F9-482B-AEF3-50D68DAFAA0A@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Tue, 10 Aug 2021 15:39:04 +0200) Subject: Re: bug#49978: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH] References: <6D6B9A78-50EC-4AEC-80AA-EB12C608EB48@acm.org> <83tujxfn7q.fsf@gnu.org> <3E02EB6C-A3F9-482B-AEF3-50D68DAFAA0A@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49978 Cc: 49978@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Tue, 10 Aug 2021 15:39:04 +0200 > Cc: 49978@debbugs.gnu.org > > 10 aug. 2021 kl. 15.23 skrev Eli Zaretskii : > > > Although perhaps we should strengthen the > > search string to be sure we don't hit some false positive: "--color" > > sounds a bit too general, no? Or do you think it's good enough even > > if "--help" causes a non-zero exit code? > > I honestly don't know. The patch works here (obviously) but strengthening it using a regexp to avoid matching "--colorise", say, probably won't hurt. Not that it's very likely that this would ever make a difference, but if you think that it's better safe then sorry then I'll do that. I think just looking for "--color[[]?=" should go a long way towards avoiding false positives. WDYT? Lars, any comments? Btw, is this usage message translatable? If so, perhaps we should inject LC_ALL=C when running the probe? From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 10 10:03:16 2021 Received: (at 49978) by debbugs.gnu.org; 10 Aug 2021 14:03:16 +0000 Received: from localhost ([127.0.0.1]:60159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDSLb-0001TV-VF for submit@debbugs.gnu.org; Tue, 10 Aug 2021 10:03:16 -0400 Received: from quimby.gnus.org ([95.216.78.240]:48178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDSLa-0001T5-1s for 49978@debbugs.gnu.org; Tue, 10 Aug 2021 10:03:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1TOh5+KT2DC6SUOWL650mwUHh8ZTYIwN54ZYGB65ACs=; b=HMjlVzxxCnPD5ArI3UIcFbEDil tpKU5TaNzS1RH+oi7UdAB1isZBKaxTlbpvE1YBw7uLrnChD+DuJIWB6VsbPG/782kwjQUD90+/j/M dvusJA1IHBbGKWHPDnNq2G9Uqm1BW5PA8eHxcDACCrAXh8Ey7LO5lHeI7wOaIljJlu74=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDSLO-0002pr-Cp; Tue, 10 Aug 2021 16:03:06 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#49978: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH] References: <6D6B9A78-50EC-4AEC-80AA-EB12C608EB48@acm.org> <83tujxfn7q.fsf@gnu.org> <3E02EB6C-A3F9-482B-AEF3-50D68DAFAA0A@acm.org> <83pmulflm2.fsf@gnu.org> Date: Tue, 10 Aug 2021 16:03:01 +0200 In-Reply-To: <83pmulflm2.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 10 Aug 2021 16:57:41 +0300") Message-ID: <875ywdz9be.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I think just looking for "--color[[]?=" should go a long way towards > avoiding false positives. WDYT? > > Lars, any comments? No, I'm not really that familiar with this code. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49978 Cc: 49978@debbugs.gnu.org, Mattias =?utf-8?Q?Engdeg=C3=A5rd?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > I think just looking for "--color[[]?=" should go a long way towards > avoiding false positives. WDYT? > > Lars, any comments? No, I'm not really that familiar with this code. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 10 11:12:01 2021 Received: (at 49978-done) by debbugs.gnu.org; 10 Aug 2021 15:12:01 +0000 Received: from localhost ([127.0.0.1]:60428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDTQ5-0007hl-CX for submit@debbugs.gnu.org; Tue, 10 Aug 2021 11:12:01 -0400 Received: from mail1472c50.megamailservers.eu ([91.136.14.72]:35330 helo=mail102c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDTQ0-0007hS-A2 for 49978-done@debbugs.gnu.org; Tue, 10 Aug 2021 11:11:57 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1628608305; bh=IdelqKFPj+iICLVxpdgn7WqXDbU75x3zK7G3GUfM8SU=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=EcJcOPgBUetX/va0GCQ+SJ7THljoaLmVQHfjIqv/TmM2BTeKo4HGoWx2bwTiog5Sj ZMWvTrInnC8r/AzSQaQ9phaxUmVR7VKBLJ6wMcCUSfpy1p4XJ61lWE7MV5Lr7Vs4T/ GXOTHwhTA/vx/cHTYdcxmjpCeC/W6rkjYs6c2cLM= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail102c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17AFBhLR009790; Tue, 10 Aug 2021 15:11:44 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#49978: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH] From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83pmulflm2.fsf@gnu.org> Date: Tue, 10 Aug 2021 17:11:42 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <1DA84CE4-E882-4DF1-B2C3-674FDF1B5D78@acm.org> References: <6D6B9A78-50EC-4AEC-80AA-EB12C608EB48@acm.org> <83tujxfn7q.fsf@gnu.org> <3E02EB6C-A3F9-482B-AEF3-50D68DAFAA0A@acm.org> <83pmulflm2.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F27.61129731.004F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Z/WS40ZA c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=0bc2urYvu2G4EkrN-bEA:9 a=CjuIK1q_8ugA:10 a=M91JV_wKSCcA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 10 aug. 2021 kl. 15.57 skrev Eli Zaretskii : > I think just looking for "--color[[]?=" should go a long way towards > avoiding false positives. Right, pushed something like that. Thank you! Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 49978-done Cc: 49978-done@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 10 aug. 2021 kl. 15.57 skrev Eli Zaretskii : > I think just looking for "--color[[]?=3D" should go a long way towards > avoiding false positives. Right, pushed something like that. Thank you! > Btw, is this usage message translatable? If so, perhaps we should > inject LC_ALL=3DC when running the probe? I don't think we need to bother -- even if the message is translated the = options themselves are not. From unknown Wed Aug 20 01:18:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 08 Sep 2021 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator