Subject: bug#49978: closed (Re: bug#49978: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH])

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 10 Aug 2021 15:12:02 +0000

Your bug report

#49978: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH]

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
49978: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49978
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#49978: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH]
From: Mattias Engdegård <[email-masked]>
To: Eli Zaretskii <[email-masked]>
Cc: [email-masked], Lars Ingebrigtsen <[email-masked]>
Date: Tue, 10 Aug 2021 17:11:42 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

10 aug. 2021 kl. 15.57 skrev Eli Zaretskii <[email-masked]>:

> I think just looking for "--color[[]?=" should go a long way towards
> avoiding false positives.

Right, pushed something like that. Thank you!

> Btw, is this usage message translatable?  If so, perhaps we should
> inject LC_ALL=C when running the probe?

I don't think we need to bother -- even if the message is translated the options themselves are not.

Subject: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH]
From: Mattias Engdegård <[email-masked]>
To: [email-masked]
Date: Tue, 10 Aug 2021 14:54:43 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

The auto-detection of colourised grep fails on macOS (and presumably BSD in general) because grep --help exits with a nonzero status (while still printing a useful option summary).

We should just ignore the exit status. Anyone against the attached patch?