From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 09 16:54:22 2021 Received: (at submit) by debbugs.gnu.org; 9 Aug 2021 20:54:22 +0000 Received: from localhost ([127.0.0.1]:57895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDCHp-0006zd-QV for submit@debbugs.gnu.org; Mon, 09 Aug 2021 16:54:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:43684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDCHj-0006zO-VS for submit@debbugs.gnu.org; Mon, 09 Aug 2021 16:54:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDCHj-00010i-Bk for guix-patches@gnu.org; Mon, 09 Aug 2021 16:54:11 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:34019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDCHg-0006af-RI for guix-patches@gnu.org; Mon, 09 Aug 2021 16:54:10 -0400 Date: Mon, 09 Aug 2021 20:54:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1628542446; bh=4kjxu7GFajDKmrA/dfNvpr5uFSG4QVG7VU2Vr0EWFyY=; h=Date:To:From:Reply-To:Subject:From; b=ed8EQVXQWSSYkLB3RomWhRBQ7d1/NraP9p0MWFrArLr8HUjLrOubUlUCQbNMk2YXc b675uj2ufVPwleYcKZz3vUUD+MYuo0tMjVSVo4XiimRWzT3kvOXz7Kp9o13pt/1lab uE9xq2y3QWU3fFv/84ql01qOW3+bfZX2D+Nf2iJA= To: "guix-patches@gnu.org" From: phodina Subject: [PATCH] gnu: Add librealsense. Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.40.134; envelope-from=phodina@protonmail.com; helo=mail-40134.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: phodina Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/video.scm (librealsense): New variable. diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 399327741f..1d4a8ad3df 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -53,6 +53,7 @@ ;;; Copyright =C2=A9 2021 Maxim Cournoyer ;;; Copyright =C2=A9 2020 Hartmut Goebel ;;; Copyright =C2=A9 2021 Raghav Gururajan +;;; Copyright =C2=A9 2021 Petr Hodina ;;; ;;; This file is part of GNU Guix. ;;; @@ -145,6 +146,7 @@ #:use-module (gnu packages mp3) #:use-module (gnu packages ncurses) #:use-module (gnu packages networking) + #:use-module (gnu packages ninja) #:use-module (gnu packages ocr) #:use-module (gnu packages pcre) #:use-module (gnu packages perl) @@ -577,6 +579,53 @@ other software.") ;; Library. license:lgpl3+)))) +(define-public librealsense + (package + (name "librealsense") + (version "2.45.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/IntelRealSense/librealsense") + (commit (string-append "v" version)))) + (patches + (search-patches "librealsense-remove-network-connectivity.patc= h")) + (file-name (git-file-name name version)) + (modules '((guix build utils))) + (sha256 + (base32 + "0aqf48zl7825v7x8c3x5w4d17m4qq377f1mn6xyqzf9b0dnk4i1j")))) + (build-system cmake-build-system) + (arguments + `(#:tests? #f + #:configure-flags (list "-DBUILD_EXAMPLES=3DON" + "-DBUILD_GRAPHICAL_EXAMPLES=3DON" + "-DINTERNET_CONNECTION=3DOFF" + "-DCHECK_FOR_UPDATES=3DOFF") + #:phases + (modify-phases %standard-phases + ;; more convenient than manually invoking setup_udev_rules.sh + ;; and substituting the path in the script + (add-after 'install 'copy-udev-rules + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (mkdir-p (string-append out "/etc/udev/rules.d")) + (copy-file "config/99-realsense-libusb.rules" + (string-append out + "/etc/udev/rules.d/99-realsense-libusb.rules"))= )))))) + (native-inputs `(("pkg-config" ,pkg-config) + ("ninja" ,ninja))) + (inputs `(("glfw" ,glfw) + ("gtk+" ,gtk+) + ("libusb" ,libusb) + ("glu" ,glu))) + (synopsis "Intel RealSense SDK") + (description "Intel RealSense SDK 2.0 is a cross-platform library for +Intel RealSense depth cameras (D400 & L500 series and the SR300) and the +T265 tracking camera.") + (home-page "https://github.com/IntelRealSense/librealsense") + (license license:gpl3))) + (define-public tslib (package (name "tslib") -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 10 04:01:24 2021 Received: (at 49970) by debbugs.gnu.org; 10 Aug 2021 08:01:24 +0000 Received: from localhost ([127.0.0.1]:58386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDMhP-0004i6-TJ for submit@debbugs.gnu.org; Tue, 10 Aug 2021 04:01:24 -0400 Received: from mail-4316.protonmail.ch ([185.70.43.16]:51627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDMhO-0004ht-6e for 49970@debbugs.gnu.org; Tue, 10 Aug 2021 04:01:23 -0400 Date: Tue, 10 Aug 2021 08:01:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1628582474; bh=f4BTwpjzaUfdTQ/ZEn+BOC3v3mAKlVqMdPWgap8GUmc=; h=Date:To:From:Reply-To:Subject:From; b=ptIyT8W7dKkltSk1F1zY0p+kYTY10WkgGF9Fva0LxxY7IvPNAeRW8oaVb2S7RykwC wMWYA7BBi2TMhwC9vaxtbPn3MDJkhFt/KJheqMJa3XPl1ujkWiVvNGDZ/FEXhTMPV2 MGOk1ltwuDUF58zaeizMfQkx4PLfDErSg9ztvk+s= To: "49970@debbugs.gnu.org" <49970@debbugs.gnu.org> From: phodina Subject: [PATCH v2] gnu: Add librealsense. Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49970 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: phodina Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/video.scm (librealsense): New variable. * gnu/packages/patches/librealsense-remove-network-connectivity.patch: New = file. diff --git a/gnu/packages/patches/librealsense-remove-network-connectivity.= patch b/gnu/packages/patches/librealsense-remove-network-connectivity.patch new file mode 100644 index 0000000000..73926587ff --- /dev/null +++ b/gnu/packages/patches/librealsense-remove-network-connectivity.patch @@ -0,0 +1,68 @@ +From cfc87289d7636f439e2b91d88e35430949b29c0f Mon Sep 17 00:00:00 2001 +From: Petr Hodina +Date: Sat, 31 Jul 2021 05:58:40 +0200 +Subject: [PATCH] Remove network connectivity + + +diff --git a/CMakeLists.txt b/CMakeLists.txt +index 0c15d9510..a4d891444 100644 +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -3,7 +3,6 @@ cmake_minimum_required(VERSION 3.1.0) + project(librealsense2 LANGUAGES CXX C) + + include(CMake/lrs_options.cmake) +-include(CMake/connectivity_check.cmake) + + #Deprecation message, should be removed in future releases + if(${FORCE_LIBUVC} OR ${FORCE_WINUSB_UVC} OR ${ANDROID_USB_HOST_UVC}) +@@ -12,14 +11,12 @@ if(${FORCE_LIBUVC} OR ${FORCE_WINUSB_UVC} OR ${ANDROID= _USB_HOST_UVC}) + endif() + + # Checking Internet connection, as TM2 needs to download the FW from amaz= on cloud +-if(BUILD_WITH_TM2 AND NOT INTERNET_CONNECTION) +- message(WARNING "No internet connection, disabling BUILD_WITH_TM2") ++if(BUILD_WITH_TM2) + set(BUILD_WITH_TM2 OFF) + endif() + + # Checking Internet connection, as DEPTH CAM needs to download the FW fro= m amazon cloud +-if(IMPORT_DEPTH_CAM_FW AND NOT INTERNET_CONNECTION) +- message(WARNING "No internet connection, disabling IMPORT_DEPTH_CAM_F= W") ++if(IMPORT_DEPTH_CAM_FW) + set(IMPORT_DEPTH_CAM_FW OFF) + endif() + +diff --git a/common/fw/CMakeLists.txt b/common/fw/CMakeLists.txt +index 32b1dd29a..9961e4d1d 100644 +--- a/common/fw/CMakeLists.txt ++++ b/common/fw/CMakeLists.txt +@@ -6,8 +6,6 @@ project(fw) + + file(READ "firmware-version.h" ver) + +-message(STATUS "Fetching recommended firmwares:") +- + set(REALSENSE_FIRMWARE_URL "https://librealsense.intel.com" CACHE STRING + "URL to download firmware binaries from") + +@@ -51,16 +49,6 @@ set_target_properties (${PROJECT_NAME} PROPERTIES FOLDE= R Resources) + + function(target_binary url version sha1 symbol ext) + set(binary "${CMAKE_CURRENT_BINARY_DIR}/${symbol}-${version}${ext}") +- message(STATUS "${url}/${symbol}-${version}${ext}") +- file(DOWNLOAD "${url}/${symbol}-${version}${ext}" "${binary}" +- EXPECTED_HASH SHA1=3D${sha1} +- STATUS status) +- list(GET status 0 error_code) +- if (NOT ${error_code} EQUAL 0) +- message(FATAL_ERROR "Download firmwnare (${status}) - ${url}") +- else() +- message(STATUS "Download firmware ${status} for ${symbol}-${version}$= {ext}") +- endif() + string(TOUPPER ${symbol} SYMBOL) + string(REPLACE "." "," version_commas ${version}) + string(REPLACE "\\" "\\\\" binary_escaped "${binary}") +-- +2.32.0 + diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 399327741f..73009e97d5 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -53,6 +53,7 @@ ;;; Copyright =C2=A9 2021 Maxim Cournoyer ;;; Copyright =C2=A9 2020 Hartmut Goebel ;;; Copyright =C2=A9 2021 Raghav Gururajan +;;; Copyright =C2=A9 2021 Petr Hodina ;;; ;;; This file is part of GNU Guix. ;;; @@ -145,6 +146,7 @@ #:use-module (gnu packages mp3) #:use-module (gnu packages ncurses) #:use-module (gnu packages networking) + #:use-module (gnu packages ninja) #:use-module (gnu packages ocr) #:use-module (gnu packages pcre) #:use-module (gnu packages perl) @@ -577,6 +579,54 @@ other software.") ;; Library. license:lgpl3+)))) +(define-public librealsense + (package + (name "librealsense") + (version "2.47.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/IntelRealSense/librealsense") + (commit (string-append "v" version)))) + (patches + (search-patches "librealsense-remove-network-connectivity.patc= h")) + (file-name (git-file-name name version)) + (modules '((guix build utils))) + (sha256 + (base32 + "1jshhcnvbaa3xm5jr1s5m6z62wn1cspb7wkfdc1w88kp9j02ss8w")))) + (build-system cmake-build-system) + (arguments + `(#:tests? #f ; no tests + #:configure-flags (list "-DBUILD_EXAMPLES=3DON" + "-DBUILD_GRAPHICAL_EXAMPLES=3DON" + "-DINTERNET_CONNECTION=3DOFF" + "-DCHECK_FOR_UPDATES=3DOFF") + #:phases + (modify-phases %standard-phases + ;; more convenient than manually invoking setup_udev_rules.sh + ;; and substituting the path in the script + (add-after 'unpack 'copy-udev-rules + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (string-append (assoc-ref outputs "out") + "/etc/udev/rules.d"))) + (mkdir-p (string-append out)) + (copy-file "config/99-realsense-libusb.rules" + (string-append out + "/99-realsense-libusb.rules")))))))) + (native-inputs `(("pkg-config" ,pkg-config) + ("ninja" ,ninja))) + (inputs `(("glfw" ,glfw) + ("gtk+" ,gtk+) + ("libusb" ,libusb) + ("glu" ,glu))) + (synopsis "Intel RealSense SDK") + (description "Intel RealSense SDK 2.0 is a cross-platform library for +Intel RealSense depth cameras (D400 & L500 series and the SR300) and the +T265 tracking camera.") + (home-page "https://github.com/IntelRealSense/librealsense") + (license license:gpl3))) + (define-public tslib (package (name "tslib") -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 18 04:05:25 2021 Received: (at 49970) by debbugs.gnu.org; 18 Sep 2021 08:05:25 +0000 Received: from localhost ([127.0.0.1]:33476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRVLh-0007zX-9O for submit@debbugs.gnu.org; Sat, 18 Sep 2021 04:05:25 -0400 Received: from mail-40136.protonmail.ch ([185.70.40.136]:23308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRVLf-0007zG-DK for 49970@debbugs.gnu.org; Sat, 18 Sep 2021 04:05:24 -0400 Date: Sat, 18 Sep 2021 08:05:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1631952317; bh=6DVcem60HEsklwAGxp9SfV6ztIEuElbX+wym3n7fz1Y=; h=Date:To:From:Reply-To:Subject:From; b=EFGLHVgFKId1SWub7OIj9ZPRc9EpFxsDgX+QX0F7WBJd9HZwB6kiW/G1CbID8tpRl 6DEeov3Qp9K7U9r3oNokO8Y51a7vHQgLnfpu+2WAWBXKqmXUbSB4KCupVAQVe0BDSU sjTOcdOOlbrpTKVH+5Otm18NSI3qYqUpkFjHa2zA= To: "49970@debbugs.gnu.org" <49970@debbugs.gnu.org> From: phodina Subject: Patch status Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49970 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: phodina Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! Is there anything to be improved to upstream this patch? From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 18 07:12:24 2021 Received: (at 49970) by debbugs.gnu.org; 18 Sep 2021 11:12:24 +0000 Received: from localhost ([127.0.0.1]:33701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRYGe-00021c-Hv for submit@debbugs.gnu.org; Sat, 18 Sep 2021 07:12:24 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:46671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRYGc-00021P-Ng for 49970@debbugs.gnu.org; Sat, 18 Sep 2021 07:12:23 -0400 Received: by mail-wr1-f65.google.com with SMTP id x6so19422464wrv.13 for <49970@debbugs.gnu.org>; Sat, 18 Sep 2021 04:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=W6pVq3lxPSRxjMSg/E0uIj3BT/qFiTEkGjsOrk2y22Q=; b=HgNeXY9AXwNRj45jQibOZeeZtl3Bwa3F1uxPG4dFNFNG2t61nF0eIyntwG6zcOJnqC KZ198IRg+Zc5qPkaL9n5JF5C0CWcYSsqEVo2CvuiuW2PDLouC1Yf7I2G4wrKpA0IRbKe qksRMFF/AQvS322xDl7r6Va/X6Q5Z2TAbt+H3nZfuS6Eu2Wvt1jsfNzOB7H8h7l7cll3 6BZrR8kry7fVxmrHK9wDJx91/LTiKy64sIiplZb/DmX7EXmN4yFnXBlNbokuOuQIUV7/ mvUoNaCWdpTsnhP65A6Hgz/ym3/yaRINsQNqKdSkVEOMeVYDBa+uuK9W6cNMbuLIi1FZ LSBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=W6pVq3lxPSRxjMSg/E0uIj3BT/qFiTEkGjsOrk2y22Q=; b=GGsmDywWpkdPezoAp2gBgeXsqmU9Eu9uXt6Kvv67uCQcS3QDS9f1CGL7MCdKx+zlbF zx5yPPU1MqKK2RMT3Ct5Y36Epl/szgvNwyNHOMyzfAhKs7eGqRVH56uUE76rmhlTrS4E 8LH/3Kz90KlZMLbL/LssKAtXY5GNynbXXS2QhQrYRUAU3DwINbGz1b052XnVdx6lenBJ rs76stmk3Zx2g4HOkSbk38M9rOyYoltTwzfBsj13BO4trqq8UK3k+dRgnytq9kxvkcMu LtuHC1D+LdYRebsd65FwMTuLEHKVMvTt1TQa9dlcvcD/jQuj7mwkzUfs4KkmhMYfxPxB if3Q== X-Gm-Message-State: AOAM530a7ju598IMOhn3fvYA/AjcCe4QllD2LLzRCSCxwvtqHSm6ommN yPP/RFZqERpy6ltCToRvfHA= X-Google-Smtp-Source: ABdhPJzwVqzxDDFgptJUJs0srPwzfrrltZNP4asDbWxk0vlxDhZcNOJz4eDtN4EHz6yzZePlrM4V8Q== X-Received: by 2002:a5d:64e6:: with SMTP id g6mr2293582wri.151.1631963536850; Sat, 18 Sep 2021 04:12:16 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id k4sm9303792wrv.24.2021.09.18.04.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Sep 2021 04:12:16 -0700 (PDT) Message-ID: Subject: Re: [PATCH] gnu: Add librealsense. From: Liliana Marie Prikler To: phodina , 49970@debbugs.gnu.org Date: Sat, 18 Sep 2021 13:12:15 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49970 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Am Montag, den 09.08.2021, 20:54 +0000 schrieb phodina: > * gnu/packages/video.scm (librealsense): New variable. > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index 399327741f..1d4a8ad3df 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -53,6 +53,7 @@ > ;;; Copyright © 2021 Maxim Cournoyer > ;;; Copyright © 2020 Hartmut Goebel > ;;; Copyright © 2021 Raghav Gururajan > +;;; Copyright © 2021 Petr Hodina > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -145,6 +146,7 @@ > #:use-module (gnu packages mp3) > #:use-module (gnu packages ncurses) > #:use-module (gnu packages networking) > + #:use-module (gnu packages ninja) > #:use-module (gnu packages ocr) > #:use-module (gnu packages pcre) > #:use-module (gnu packages perl) > @@ -577,6 +579,53 @@ other software.") > ;; Library. > license:lgpl3+)))) > > +(define-public librealsense > + (package > + (name "librealsense") > + (version "2.45.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url " > https://github.com/IntelRealSense/librealsense") > + (commit (string-append "v" version)))) > + (patches > + (search-patches "librealsense-remove-network- > connectivity.patch")) > + (file-name (git-file-name name version)) > + (modules '((guix build utils))) > + (sha256 > + (base32 > + "0aqf48zl7825v7x8c3x5w4d17m4qq377f1mn6xyqzf9b0dnk4i1j" > )))) > + (build-system cmake-build-system) > + (arguments > + `(#:tests? #f Always explain why you're disabling tests. > + #:configure-flags (list "-DBUILD_EXAMPLES=ON" > + "-DBUILD_GRAPHICAL_EXAMPLES=ON" > + "-DINTERNET_CONNECTION=OFF" > + "-DCHECK_FOR_UPDATES=OFF") > + #:phases > + (modify-phases %standard-phases > + ;; more convenient than manually invoking > setup_udev_rules.sh > + ;; and substituting the path in the script > + (add-after 'install 'copy-udev-rules > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (mkdir-p (string-append out "/etc/udev/rules.d")) > + (copy-file "config/99-realsense-libusb.rules" > + (string-append out > + "/etc/udev/rules.d/99-realsense- > libusb.rules")))))))) Note that udev-service-type only searches /lib/udev, not /etc/udev. > + (native-inputs `(("pkg-config" ,pkg-config) > + ("ninja" ,ninja))) > + (inputs `(("glfw" ,glfw) > + ("gtk+" ,gtk+) > + ("libusb" ,libusb) > + ("glu" ,glu))) > + (synopsis "Intel RealSense SDK") > + (description "Intel RealSense SDK 2.0 is a cross-platform library > for > +Intel RealSense depth cameras (D400 & L500 series and the SR300) and > the > +T265 tracking camera.") > + (home-page "https://github.com/IntelRealSense/librealsense") > + (license license:gpl3))) This package seems to be covered under an Apache license, not the GPL. Regards From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 18 07:48:07 2021 Received: (at 49970) by debbugs.gnu.org; 18 Sep 2021 11:48:07 +0000 Received: from localhost ([127.0.0.1]:33732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRYpC-00053K-M6 for submit@debbugs.gnu.org; Sat, 18 Sep 2021 07:48:07 -0400 Received: from mail-4322.protonmail.ch ([185.70.43.22]:11925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRYpA-00052n-EY for 49970@debbugs.gnu.org; Sat, 18 Sep 2021 07:48:05 -0400 Date: Sat, 18 Sep 2021 11:47:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1631965676; bh=XwPcsVyq1lqiHt2TUR6ivT+MVm7YgLoVxyjNJ5doh5g=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=s14Rs7LD65ewbrmaE2jdYCbv9xDRcUaYFBmqkKTG022ctIcIL/Exit7cRvbEXO0ou qb37NhlOa1IGH7MKmBiFzj9Xx4pjxjqnerQ/vmTWWtREkfIh3Fcrke+PdJL0v+b3a1 1icHs0Wl8j+m6l+i/I16mfx8D9mzpb5m3mHRac5g= To: Liliana Marie Prikler From: phodina Subject: Re: [PATCH] gnu: Add librealsense. Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49970 Cc: 49970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: phodina Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Liliana, thanks for the comment! My appology for the licence. --8<---------------cut here---------------start------------->8--- * gnu/packages/video.scm (librealsense): New variable. * gnu/packages/patches/librealsense-remove-network-connectivity.patch: New = file. diff --git a/gnu/packages/patches/librealsense-remove-network-connectivity.= patch b/gnu/packages/patches/librealsense-remove-network-connectivity.patch new file mode 100644 index 0000000000..73926587ff --- /dev/null +++ b/gnu/packages/patches/librealsense-remove-network-connectivity.patch @@ -0,0 +1,68 @@ +From cfc87289d7636f439e2b91d88e35430949b29c0f Mon Sep 17 00:00:00 2001 +From: Petr Hodina +Date: Sat, 31 Jul 2021 05:58:40 +0200 +Subject: [PATCH] Remove network connectivity + + +diff --git a/CMakeLists.txt b/CMakeLists.txt +index 0c15d9510..a4d891444 100644 +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -3,7 +3,6 @@ cmake_minimum_required(VERSION 3.1.0) + project(librealsense2 LANGUAGES CXX C) + + include(CMake/lrs_options.cmake) +-include(CMake/connectivity_check.cmake) + + #Deprecation message, should be removed in future releases + if(${FORCE_LIBUVC} OR ${FORCE_WINUSB_UVC} OR ${ANDROID_USB_HOST_UVC}) +@@ -12,14 +11,12 @@ if(${FORCE_LIBUVC} OR ${FORCE_WINUSB_UVC} OR ${ANDROID= _USB_HOST_UVC}) + endif() + + # Checking Internet connection, as TM2 needs to download the FW from amaz= on cloud +-if(BUILD_WITH_TM2 AND NOT INTERNET_CONNECTION) +- message(WARNING "No internet connection, disabling BUILD_WITH_TM2") ++if(BUILD_WITH_TM2) + set(BUILD_WITH_TM2 OFF) + endif() + + # Checking Internet connection, as DEPTH CAM needs to download the FW fro= m amazon cloud +-if(IMPORT_DEPTH_CAM_FW AND NOT INTERNET_CONNECTION) +- message(WARNING "No internet connection, disabling IMPORT_DEPTH_CAM_F= W") ++if(IMPORT_DEPTH_CAM_FW) + set(IMPORT_DEPTH_CAM_FW OFF) + endif() + +diff --git a/common/fw/CMakeLists.txt b/common/fw/CMakeLists.txt +index 32b1dd29a..9961e4d1d 100644 +--- a/common/fw/CMakeLists.txt ++++ b/common/fw/CMakeLists.txt +@@ -6,8 +6,6 @@ project(fw) + + file(READ "firmware-version.h" ver) + +-message(STATUS "Fetching recommended firmwares:") +- + set(REALSENSE_FIRMWARE_URL "https://librealsense.intel.com" CACHE STRING + "URL to download firmware binaries from") + +@@ -51,16 +49,6 @@ set_target_properties (${PROJECT_NAME} PROPERTIES FOLDE= R Resources) + + function(target_binary url version sha1 symbol ext) + set(binary "${CMAKE_CURRENT_BINARY_DIR}/${symbol}-${version}${ext}") +- message(STATUS "${url}/${symbol}-${version}${ext}") +- file(DOWNLOAD "${url}/${symbol}-${version}${ext}" "${binary}" +- EXPECTED_HASH SHA1=3D${sha1} +- STATUS status) +- list(GET status 0 error_code) +- if (NOT ${error_code} EQUAL 0) +- message(FATAL_ERROR "Download firmwnare (${status}) - ${url}") +- else() +- message(STATUS "Download firmware ${status} for ${symbol}-${version}$= {ext}") +- endif() + string(TOUPPER ${symbol} SYMBOL) + string(REPLACE "." "," version_commas ${version}) + string(REPLACE "\\" "\\\\" binary_escaped "${binary}") +-- +2.32.0 + diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 1b9179c6a8..ee783338f4 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -53,6 +53,7 @@ ;;; Copyright =C2=A9 2021 Maxim Cournoyer ;;; Copyright =C2=A9 2020 Hartmut Goebel ;;; Copyright =C2=A9 2021 Raghav Gururajan +;;; Copyright =C2=A9 2021 Petr Hodina ;;; ;;; This file is part of GNU Guix. ;;; @@ -145,6 +146,7 @@ #:use-module (gnu packages mp3) #:use-module (gnu packages ncurses) #:use-module (gnu packages networking) + #:use-module (gnu packages ninja) #:use-module (gnu packages ocr) #:use-module (gnu packages pcre) #:use-module (gnu packages perl) @@ -577,6 +579,54 @@ other software.") ;; Library. license:lgpl3+)))) +(define-public librealsense + (package + (name "librealsense") + (version "2.47.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/IntelRealSense/librealsense") + (commit (string-append "v" version)))) + (patches + (search-patches "librealsense-remove-network-connectivity.patc= h")) + (file-name (git-file-name name version)) + (modules '((guix build utils))) + (sha256 + (base32 + "1jshhcnvbaa3xm5jr1s5m6z62wn1cspb7wkfdc1w88kp9j02ss8w")))) + (build-system cmake-build-system) + (arguments + `(#:tests? #f ; tests require camera hardware + #:configure-flags (list "-DBUILD_EXAMPLES=3DON" + "-DBUILD_GRAPHICAL_EXAMPLES=3DON" + "-DINTERNET_CONNECTION=3DOFF" + "-DCHECK_FOR_UPDATES=3DOFF") + #:phases + (modify-phases %standard-phases + ;; more convenient than manually invoking setup_udev_rules.sh + ;; and substituting the path in the script + (add-after 'unpack 'copy-udev-rules + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (string-append (assoc-ref outputs "out") + "/lib/udev/rules.d"))) + (mkdir-p (string-append out)) + (copy-file "config/99-realsense-libusb.rules" + (string-append out + "/99-realsense-libusb.rules")))))))) + (native-inputs `(("pkg-config" ,pkg-config) + ("ninja" ,ninja))) + (inputs `(("glfw" ,glfw) + ("gtk+" ,gtk+) + ("libusb" ,libusb) + ("glu" ,glu))) + (synopsis "Intel RealSense SDK") + (description "Intel RealSense SDK 2.0 is a cross-platform library for +Intel RealSense depth cameras (D400 & L500 series and the SR300) and the +T265 tracking camera.") + (home-page "https://github.com/IntelRealSense/librealsense") + (license license:asl2.0))) + (define-public tslib (package (name "tslib") -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 18 08:03:08 2021 Received: (at 49970) by debbugs.gnu.org; 18 Sep 2021 12:03:08 +0000 Received: from localhost ([127.0.0.1]:33752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRZ3g-0005Qa-BY for submit@debbugs.gnu.org; Sat, 18 Sep 2021 08:03:08 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:35482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRZ3e-0005Q5-E0 for 49970@debbugs.gnu.org; Sat, 18 Sep 2021 08:03:03 -0400 Received: by mail-wm1-f65.google.com with SMTP id z184-20020a1c7ec1000000b003065f0bc631so11949453wmc.0 for <49970@debbugs.gnu.org>; Sat, 18 Sep 2021 05:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=f4DGc9rnYzbaNTAIiQIw1vV1ryZn4TxsQz7LPo7Tp9k=; b=UkfvsmieLcR4BC/MjwGpk6asR6mehsr6zVBHWOIJCovU72gdFXdpBfexbhTgIHnf9C TzDNG5qnkKppEwNyisCsnWzF4OOoxXxKTxUMuDqmDQkm9ulfn9fSX8w5xkppX/Do6yXf dwuWKOBg3VvdEZ/CY2tkX+NPWISn4Ik+TNRymX5Cb9HiCI+/lkkH4wCv+4Y5iXKLuvDl +0tZzUsFCD/byGiYy75nQqRkbFUjaAI4V/mBjYY0UuU/Asrg9YAIBaUfYTByPfbq992T +TqBE9O2wpTFkIhUhkr3gB+PPb9tXDScKkM3jIuU/zUJq+JPklxFhCzCvHvV3SxqpTQe PkNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=f4DGc9rnYzbaNTAIiQIw1vV1ryZn4TxsQz7LPo7Tp9k=; b=w6WCdH9l5NieeamV39rgcUsfR5HRqr5CMfcIJEm2qZGVC4JXC82YAwMaOAtJqhd3MH HVVsb9ROFSUVQf1Z/R4MHlCD5/L2TwnLBGh/MaEjqO7xX//VMsWXt5cjC+YzKMtKBYdc cIUC5fEsSh4MvhmBB6nRmIydPOhY0RY2g00MZ+lySyLCVjX5e2bTNl/Nfso804WLTfUW +Adf2NAdSJhOt9xzV043sj6LI8QPFRtEYreJjyaTr0UzQZuXfVYC5Y1i7WmzgeOREmFw p5ZNMM6SMDeQIcEguPrNQl2S0swwOEJXS2H42kHdWneODmlefAHQDaqNItPOCCo+mIEX +fFQ== X-Gm-Message-State: AOAM532jRJYA9bfJJ5A/ANrw3OqQ7mnlRtsZq9vq66fBVTDgcKtVlh3M EYPTMt3exfn0U5KKsHEyLjE= X-Google-Smtp-Source: ABdhPJwCO0QJXDlxP07xNwzjlcvNCrj3hzWmkFD5bPnB93pMm+8N1JvgLa22bX6OEaJYO77oldvTyA== X-Received: by 2002:a1c:228b:: with SMTP id i133mr20108485wmi.179.1631966576500; Sat, 18 Sep 2021 05:02:56 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id u2sm9320674wmj.29.2021.09.18.05.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Sep 2021 05:02:55 -0700 (PDT) Message-ID: <77c3dd2d26f0497f83800ae56bd2e2ca87c17867.camel@gmail.com> Subject: Re: [PATCH] gnu: Add librealsense. From: Liliana Marie Prikler To: phodina Date: Sat, 18 Sep 2021 14:02:54 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49970 Cc: 49970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Petr, Am Samstag, den 18.09.2021, 11:47 +0000 schrieb phodina: > Hi Liliana, > > thanks for the comment! My appology for the licence. > --8<---------------cut here---------------start------------->8--- > * gnu/packages/video.scm (librealsense): New variable. > * gnu/packages/patches/librealsense-remove-network- > connectivity.patch: New file. Looking at this patch, it only seems to disable some warnings, which frankly we can choose to ignore. Is this really required to build librealsense? > diff --git a/gnu/packages/patches/librealsense-remove-network- > connectivity.patch b/gnu/packages/patches/librealsense-remove- > network-connectivity.patch > new file mode 100644 > index 0000000000..73926587ff > --- /dev/null > +++ b/gnu/packages/patches/librealsense-remove-network- > connectivity.patch > @@ -0,0 +1,68 @@ > +From cfc87289d7636f439e2b91d88e35430949b29c0f Mon Sep 17 00:00:00 > 2001 > +From: Petr Hodina > +Date: Sat, 31 Jul 2021 05:58:40 +0200 > +Subject: [PATCH] Remove network connectivity > + > + > +diff --git a/CMakeLists.txt b/CMakeLists.txt > +index 0c15d9510..a4d891444 100644 > +--- a/CMakeLists.txt > ++++ b/CMakeLists.txt > +@@ -3,7 +3,6 @@ cmake_minimum_required(VERSION 3.1.0) > + project(librealsense2 LANGUAGES CXX C) > + > + include(CMake/lrs_options.cmake) > +-include(CMake/connectivity_check.cmake) > + > + #Deprecation message, should be removed in future releases > + if(${FORCE_LIBUVC} OR ${FORCE_WINUSB_UVC} OR > ${ANDROID_USB_HOST_UVC}) > +@@ -12,14 +11,12 @@ if(${FORCE_LIBUVC} OR ${FORCE_WINUSB_UVC} OR > ${ANDROID_USB_HOST_UVC}) > + endif() > + > + # Checking Internet connection, as TM2 needs to download the FW > from amazon cloud > +-if(BUILD_WITH_TM2 AND NOT INTERNET_CONNECTION) > +- message(WARNING "No internet connection, disabling > BUILD_WITH_TM2") > ++if(BUILD_WITH_TM2) > + set(BUILD_WITH_TM2 OFF) > + endif() > + > + # Checking Internet connection, as DEPTH CAM needs to download the > FW from amazon cloud > +-if(IMPORT_DEPTH_CAM_FW AND NOT INTERNET_CONNECTION) > +- message(WARNING "No internet connection, disabling > IMPORT_DEPTH_CAM_FW") > ++if(IMPORT_DEPTH_CAM_FW) > + set(IMPORT_DEPTH_CAM_FW OFF) > + endif() > + > +diff --git a/common/fw/CMakeLists.txt b/common/fw/CMakeLists.txt > +index 32b1dd29a..9961e4d1d 100644 > +--- a/common/fw/CMakeLists.txt > ++++ b/common/fw/CMakeLists.txt > +@@ -6,8 +6,6 @@ project(fw) > + > + file(READ "firmware-version.h" ver) > + > +-message(STATUS "Fetching recommended firmwares:") > +- > + set(REALSENSE_FIRMWARE_URL "https://librealsense.intel.com" CACHE > STRING > + "URL to download firmware binaries from") > + > +@@ -51,16 +49,6 @@ set_target_properties (${PROJECT_NAME} PROPERTIES > FOLDER Resources) > + > + function(target_binary url version sha1 symbol ext) > + set(binary "${CMAKE_CURRENT_BINARY_DIR}/${symbol}- > ${version}${ext}") > +- message(STATUS "${url}/${symbol}-${version}${ext}") > +- file(DOWNLOAD "${url}/${symbol}-${version}${ext}" "${binary}" > +- EXPECTED_HASH SHA1=${sha1} > +- STATUS status) > +- list(GET status 0 error_code) > +- if (NOT ${error_code} EQUAL 0) > +- message(FATAL_ERROR "Download firmwnare (${status}) - ${url}") > +- else() > +- message(STATUS "Download firmware ${status} for ${symbol}- > ${version}${ext}") > +- endif() > + string(TOUPPER ${symbol} SYMBOL) > + string(REPLACE "." "," version_commas ${version}) > + string(REPLACE "\\" "\\\\" binary_escaped "${binary}") > +-- > +2.32.0 > + > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index 1b9179c6a8..ee783338f4 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -53,6 +53,7 @@ > ;;; Copyright © 2021 Maxim Cournoyer > ;;; Copyright © 2020 Hartmut Goebel > ;;; Copyright © 2021 Raghav Gururajan > +;;; Copyright © 2021 Petr Hodina > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -145,6 +146,7 @@ > #:use-module (gnu packages mp3) > #:use-module (gnu packages ncurses) > #:use-module (gnu packages networking) > + #:use-module (gnu packages ninja) > #:use-module (gnu packages ocr) > #:use-module (gnu packages pcre) > #:use-module (gnu packages perl) > @@ -577,6 +579,54 @@ other software.") > ;; Library. > license:lgpl3+)))) > > +(define-public librealsense > + (package > + (name "librealsense") > + (version "2.47.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url " > https://github.com/IntelRealSense/librealsense") > + (commit (string-append "v" version)))) > + (patches > + (search-patches "librealsense-remove-network- > connectivity.patch")) > + (file-name (git-file-name name version)) > + (modules '((guix build utils))) > + (sha256 > + (base32 > + "1jshhcnvbaa3xm5jr1s5m6z62wn1cspb7wkfdc1w88kp9j02ss8w" > )))) > + (build-system cmake-build-system) > + (arguments > + `(#:tests? #f ; tests require camera hardware > + #:configure-flags (list "-DBUILD_EXAMPLES=ON" > + "-DBUILD_GRAPHICAL_EXAMPLES=ON" > + "-DINTERNET_CONNECTION=OFF" > + "-DCHECK_FOR_UPDATES=OFF") > + #:phases > + (modify-phases %standard-phases > + ;; more convenient than manually invoking > setup_udev_rules.sh > + ;; and substituting the path in the script > + (add-after 'unpack 'copy-udev-rules > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (string-append (assoc-ref outputs "out") > + "/lib/udev/rules.d"))) > + (mkdir-p (string-append out)) > + (copy-file "config/99-realsense-libusb.rules" > + (string-append out > + "/99-realsense-libusb.rules")))))))) > + (native-inputs `(("pkg-config" ,pkg-config) > + ("ninja" ,ninja))) > + (inputs `(("glfw" ,glfw) > + ("gtk+" ,gtk+) > + ("libusb" ,libusb) > + ("glu" ,glu))) > + (synopsis "Intel RealSense SDK") > + (description "Intel RealSense SDK 2.0 is a cross-platform library > for > +Intel RealSense depth cameras (D400 & L500 series and the SR300) and > the > +T265 tracking camera.") > + (home-page "https://github.com/IntelRealSense/librealsense") > + (license license:asl2.0))) > + > (define-public tslib > (package > (name "tslib") librealsense also seems to bundle a bunch of software in its third- party directory. How much of that could we unbundle? From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 18 08:47:08 2021 Received: (at 49970) by debbugs.gnu.org; 18 Sep 2021 12:47:08 +0000 Received: from localhost ([127.0.0.1]:33814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRZkK-0000Eo-FE for submit@debbugs.gnu.org; Sat, 18 Sep 2021 08:47:08 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:34961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRZkJ-0000ER-D7 for 49970@debbugs.gnu.org; Sat, 18 Sep 2021 08:47:07 -0400 Date: Sat, 18 Sep 2021 12:46:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1631969217; bh=lEEMLeIzGntSUmgkIpoGjcZlReTMjJL0Tx7SvsbPyB4=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=L1l879S3zUAvgNTw9VCMAxccHTCfWgkL+EAHbjsbBeT4WqK7VoqtxNLSlYEFeItig fqnxuO9VCloLvQCO0u0GZ9hYHwV5/lXHFmVbKKtQ37m2CFubhdFf6Wg8hABh0VjO11 /5SJ6Zh0gRX4vz3gjRNXxXCxYtvTYiKh4XPk/FKM= To: Liliana Marie Prikler From: phodina Subject: Re: [PATCH] gnu: Add librealsense. Message-ID: In-Reply-To: <77c3dd2d26f0497f83800ae56bd2e2ca87c17867.camel@gmail.com> References: <77c3dd2d26f0497f83800ae56bd2e2ca87c17867.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49970 Cc: 49970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: phodina Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) You're right Liliana the patch is indeed not neccessary. I'll try to unbundle as much as possible of the third party code. Regards Petr