GNU bug report logs - #49953
28.0.50; tmm is broken on compiled menus

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, Stefan Monnier <monnier <at> iro.umontreal.ca> 
Cc: 49953 <at> debbugs.gnu.org, juri <at> linkov.net
Subject: bug#49953: 28.0.50; tmm is broken on compiled menus
Date: Mon, 09 Aug 2021 20:09:52 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Mon, 09 Aug 2021 15:20:58 +0200
> Cc: 49953 <at> debbugs.gnu.org
> 
> Juri Linkov <juri <at> linkov.net> writes:
> 
> > This regression began to occur after merging native-compilation.
> > It seems the problem is that tmm-get-keymap does very strange things:
> >
> > 	(cond ((if (listp elt)
> > 		   (or (keymapp elt) (eq (car elt) 'lambda))
> > 		 (and (symbolp elt) (fboundp elt)))
> >
> > I don't know why it checks for 'lambda' and 'symbolp',
> > but such checks fail on a compiled function.
> 
> Yeah, or why the listp at all...  I think the correct test in all these
> cases are (or (keymapp elt) (functionp elt))?  So I've now done that on
> the trunk, and that seems to make things work.  But there may be
> something subtle here, so I guess we'll see...

I have a vague recollection that at least some of those are used, so I
brought Stefan on-board this discussion, in the hope that he could
show us the light.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.