GNU bug report logs - #49946
[PATCH 00/31] Tree-sitter, node-gyp addon support and emacs-tree-sitter

Previous Next

Full log

View this message in rfc822 format

From: "(" <paren <at> disroot.org>
To: "Pierre Langlois" <pierre.langlois <at> gmx.com>, <49946 <at> debbugs.gnu.org>
Subject: [bug#49946] [PATCH v7 32/32] gnu: Add emacs-tree-sitter-langs.
Date: Fri, 25 Nov 2022 07:29:28 +0000

On Fri Nov 25, 2022 at 1:21 AM GMT, Pierre Langlois wrote:
> * gnu/packages/tree-sitter.scm (make-emacs-tree-sitter-langs-grammar-bundle):
> New procedure.

Doesn't look like a procedure to me :) It probably should also be
a hidden-package, no?

> (emacs-tree-sitter-langs): New variable.

> --- a/gnu/packages/tree-sitter.scm
> +++ b/gnu/packages/tree-sitter.scm

> @@ -849,3 +850,152 @@ (define-public emacs-tree-sitter

> +    (synopsis #f)
> +    (description #f)

Please add a description and synopsis.

> +     (list
> +      #:tests? #t

Superfluous newline; please use:

  (list #:tests? #t ...)

> +          (add-after 'install 'install-queries
> +            (lambda* (#:key outputs #:allow-other-keys)
> +              (let ((elpa (elpa-directory (assoc-ref outputs "out"))))
> +                (copy-recursively "queries" (string-append elpa "/queries"))))))))

Please use #$output here.

    -- (

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.