GNU bug report logs - #49943
[PATCH] gnu: Add openboard

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#49943: closed ([PATCH] gnu: Add openboard)
Date: Tue, 22 Mar 2022 20:17:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 22 Mar 2022 16:16:50 -0400
with message-id <871qyt3fpp.fsf_-_ <at> gmail.com>
and subject line Re: bug#49943: [PATCH] gnu: Add openboard
has caused the debbugs.gnu.org bug report #49943,
regarding [PATCH] gnu: Add openboard
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
49943: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49943
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add openboard
Date: Sun, 08 Aug 2021 16:47:04 +0200

[Message part 3 (text/plain, inline)]

Hello,

This patch provides openboard package definition. 

I tested it a bit, it mostly works but crashes (segmentation fault) on
some functions (e.g., when pressing the "Web" button or opening the
online tutorial). It is usable, tho.

Feedback and improvements welcome.

Regards,
-- 
Nicolas Goaziou

[0001-gnu-Add-openboard.patch (text/x-diff, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>, 49943-done <at> debbugs.gnu.org
Subject: Re: bug#49943: [PATCH] gnu: Add openboard
Date: Tue, 22 Mar 2022 16:16:50 -0400

Hello,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hi Nicolas and Maxime,
>
> Maxime Devos <maximedevos <at> telenet.be> writes:
>
>> Nicolas Goaziou schreef op zo 06-03-2022 om 00:16 [+0100]:
>>> +            (add-after 'unpack 'fix-hard-coded-env
>>> +              (lambda* (#:key inputs #:allow-other-keys)
>>> +                (substitute*
>>> "src/frameworks/UBPlatformUtils_linux.cpp"
>>> +                  (("/usr/bin/env") (search-input-file inputs
>>> "/bin/env")))))
>>
>> You have to add 'coreutils-minimal' (or 'coreutils') to 'inputs',
>> otherwise 'search-input-file' will fail when cross-compiling because
>> 'bin/env' (from 'coreutils') is not among the inputs, whereas it is in
>> the (implicit) native-inputs when compiling natively and native-inputs
>> are merged into inputs when compiling natively.
>
> I've tested it, and it was for the most part functional (only the
> "games" add-on that I could integrate to the main screen didn't render
> fully, perhaps because my WebGL support was marked as blacklisted (I use
> the nouveau driver)).
>
> LGTM, with the above comment from Maxime addressed!

I went ahead and adjusted the version string to be monotonic, added
coreutils-minimal as an input, and pushed as 96b2da8cde.

Thanks,

Closing.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.