GNU bug report logs - #4994
23.1.50; reftex-isearch-minor-mode does not restore to the original point

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4994 in the body.
You can then email your comments to 4994 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.1.50; reftex-isearch-minor-mode does not restore to the original point
Date: Fri, 20 Nov 2009 17:34:46 +0000

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

1. (reftex-isearch-minor-mode t)

2. now search a string in a LaTeX project that is split (via \input
or \include) into many files

3. C-g to quit

and you will see point can be left in a new buffer.

For example, from the master file I initialised an isearch and when the
point jumped to chap1.tex, I hit C-g. Point was left in chap1.tex
instead of the original buffer where the command started.

I am surprised by this behaviour so I'm wondering whether this is a bug.

Best wishes,

Leo

================================

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/Applications/Emacs.app/Contents/Resources/etc/DEBUG for instructions.


In GNU Emacs 23.1.50.1 (i386-apple-darwin9.8.0, NS apple-appkit-949.54)
 of 2009-09-22 on neutron.local
Windowing system distributor `Apple', version 10.3.949
configured using `configure  '--with-ns''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default enable-multibyte-characters: t

Message #10 received at 4994 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 4994 <at> debbugs.gnu.org
Subject: Re: bug#4994: 23.1.50; reftex-isearch-minor-mode does not restore to the original point
Date: Fri, 20 Nov 2009 21:08:07 +0200

> 1. (reftex-isearch-minor-mode t)
>
> 2. now search a string in a LaTeX project that is split (via \input
> or \include) into many files
>
> 3. C-g to quit
>
> and you will see point can be left in a new buffer.
>
> For example, from the master file I initialised an isearch and when the
> point jumped to chap1.tex, I hit C-g. Point was left in chap1.tex
> instead of the original buffer where the command started.
>
> I am surprised by this behaviour so I'm wondering whether this is a bug.

Thanks, good point.  It seems C-g doesn't return to the initial search state.
I'll try a solution.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #15 received at 4994 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: 4994 <at> debbugs.gnu.org
Cc: Leo <sdl.web <at> gmail.com>
Subject: Re: bug#4994: 23.1.50; reftex-isearch-minor-mode does not restore to the original point
Date: Fri, 20 Nov 2009 21:32:08 +0200

>> 1. (reftex-isearch-minor-mode t)
>>
>> 2. now search a string in a LaTeX project that is split (via \input
>> or \include) into many files
>>
>> 3. C-g to quit
>>
>> and you will see point can be left in a new buffer.
>>
>> For example, from the master file I initialised an isearch and when the
>> point jumped to chap1.tex, I hit C-g. Point was left in chap1.tex
>> instead of the original buffer where the command started.
>>
>> I am surprised by this behaviour so I'm wondering whether this is a bug.
>
> Thanks, good point.  It seems C-g doesn't return to the initial search state.
> I'll try to find a solution.

Multi-buffer isearch has no chance to save the initial state because
its setup is called too late - after the initial state (without
additional information about the original buffer) is pushed to the stack.

IOW, in `isearch-mode', `(isearch-push-state)' is called earlier than
(run-hooks 'isearch-mode-hook) that sets up multi-buffer specific
`isearch-push-state-function'.

Changing the order of these lines fixes this bug.  However, this change has
a risk of breaking other things.  So I need more time to test this fix.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #20 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#4994: 23.1.50; reftex-isearch-minor-mode does not restore to the original point
Date: Fri, 20 Nov 2009 22:44:15 +0000

Hi Juri,

On 2009-11-20 19:32 +0000, Juri Linkov wrote:
> Multi-buffer isearch has no chance to save the initial state because
> its setup is called too late - after the initial state (without
> additional information about the original buffer) is pushed to the stack.
>
> IOW, in `isearch-mode', `(isearch-push-state)' is called earlier than
> (run-hooks 'isearch-mode-hook) that sets up multi-buffer specific
> `isearch-push-state-function'.
>
> Changing the order of these lines fixes this bug.  However, this change has
> a risk of breaking other things.  So I need more time to test this fix.

Thank you for fixing the issue. I will wait for your final patch ;)

Best wishes,
Leo

Message #25 received at 4994 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 4994 <at> debbugs.gnu.org
Subject: Re: 23.1.50; reftex-isearch-minor-mode does not restore to the original point
Date: Mon, 07 Dec 2009 19:30:31 +0200

> 1. (reftex-isearch-minor-mode t)
>
> 2. now search a string in a LaTeX project that is split (via \input
> or \include) into many files
>
> 3. C-g to quit
>
> and you will see point can be left in a new buffer.
>
> For example, from the master file I initialised an isearch and when the
> point jumped to chap1.tex, I hit C-g. Point was left in chap1.tex
> instead of the original buffer where the command started.
>
> I am surprised by this behaviour so I'm wondering whether this is a bug.

This is fixed now in CVS.  Please try the fix.

Thank you for reporting the bug.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #30 received at 4994 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Leo <sdl.web <at> googlemail.com>
To: Juri Linkov <juri <at> jurta.org>
Cc: 4994 <at> debbugs.gnu.org
Subject: Re: 23.1.50; reftex-isearch-minor-mode does not restore to the 
	original point
Date: Mon, 7 Dec 2009 19:29:20 +0000

Hi Juri,

2009/12/7 Juri Linkov <juri <at> jurta.org>:
>> 1. (reftex-isearch-minor-mode t)
>>
>> 2. now search a string in a LaTeX project that is split (via \input
>> or \include) into many files
>>
>> 3. C-g to quit
>>
>> and you will see point can be left in a new buffer.
>>
>> For example, from the master file I initialised an isearch and when the
>> point jumped to chap1.tex, I hit C-g. Point was left in chap1.tex
>> instead of the original buffer where the command started.
>>
>> I am surprised by this behaviour so I'm wondering whether this is a bug.
>
> This is fixed now in CVS.  Please try the fix.

I can confirm this is fixed. Thank you very much.

> Thank you for reporting the bug.
>
> --
> Juri Linkov
> http://www.jurta.org/emacs/

Leo

Message #35 received at 4994-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: 4994-done <at> debbugs.gnu.org
Subject: Re: 23.1.50; reftex-isearch-minor-mode does not restore to the  original point
Date: Mon, 07 Dec 2009 22:48:50 +0200

Bug closed.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.