From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 07 00:46:14 2021 Received: (at submit) by debbugs.gnu.org; 7 Aug 2021 04:46:14 +0000 Received: from localhost ([127.0.0.1]:51715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mCEDu-0003jV-2d for submit@debbugs.gnu.org; Sat, 07 Aug 2021 00:46:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:47290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mCEDr-0003jM-Gl for submit@debbugs.gnu.org; Sat, 07 Aug 2021 00:46:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCEDr-0002dF-3N for guix-patches@gnu.org; Sat, 07 Aug 2021 00:46:11 -0400 Received: from out2.migadu.com ([188.165.223.204]:48009) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCEDn-0002aA-Jy for guix-patches@gnu.org; Sat, 07 Aug 2021 00:46:10 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1628311559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ncq1rgTxWepT4X2v4FVZYP2awS2un/g0tB6sJz5sjRI=; b=hQWOjlsnOH2KcPem3jQjSlyarpT1l02WDW+ivIhZhh7IM5LvZ6mLqeVWdLPNW8EmBSP2Ug /mAvE+RZ0i2FhiY+9CUvRNRwOstSY9P22wqdwIYQLAI9QzUz1haLKTnb/R+FuZJoXB9Wa2 g0PAamoOGgimyv2o/vlCpTSRnKGS4cE= From: Sarah Morgensen To: guix-patches@gnu.org Subject: [PATCH core-updates 0/2] build-system/go: Enable parallelism. Date: Fri, 6 Aug 2021 21:45:57 -0700 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=188.165.223.204; envelope-from=iskarian@mgsn.dev; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hello Guix, These patches give the Go build system the standard parallelism levers. I would have thought that Go was already detecting the correct number for GOMAXPROCS, but after I made this same change for the bootstrapping Go compiler, Efraim found that it cut the build time nearly in half [0]. [0] https://issues.guix.gnu.org/49616 -- Sarah Morgensen (2): build-system/go: Honor #:parallel-build?. build-system/go: Honor #:parallel-tests?. guix/build-system/go.scm | 5 +++++ guix/build/go-build-system.scm | 12 ++++++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) base-commit: 693d75e859150601145b7f7303f61d4f48e76927 -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 07 00:48:45 2021 Received: (at 49919) by debbugs.gnu.org; 7 Aug 2021 04:48:45 +0000 Received: from localhost ([127.0.0.1]:51726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mCEGG-0003oQ-UO for submit@debbugs.gnu.org; Sat, 07 Aug 2021 00:48:45 -0400 Received: from out1.migadu.com ([91.121.223.63]:22470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mCEGE-0003oB-Jv for 49919@debbugs.gnu.org; Sat, 07 Aug 2021 00:48:39 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1628311716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZFXTMOVwI9WfCW8BL/IfOOcxRplp/nyZwLe1WUkVOWc=; b=Cgd1aWZ1vvBD/RoL/JzMB1hUd4HSYwZfX3EyZtXOPW/QTslsL1Kpy+OUH95OW1r9oQ7MDc zsyk4TrNt1wU6RGoydGZMrgO2NI7Zsk5fIGRNWkKu0QsbhUPZgSf3nM0Ej+JxyEnRSYK+8 WGydeaZ8JJtZew2PM0CUjce4s1Ym1wQ= From: Sarah Morgensen To: 49919@debbugs.gnu.org Subject: [PATCH core-updates 1/2] build-system/go: Honor #:parallel-build?. Date: Fri, 6 Aug 2021 21:48:33 -0700 Message-Id: <1ea32faddea717239b3d56cfa7e647fc1d48faa7.1628309588.git.iskarian@mgsn.dev> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49919 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) guix/build/go-build-system.scm (build): Honor #:parallel-build?. guix/build-system/go.scm (go-build): Add PARALLEL-BUILD? parameter. [builder]: Use it. --- guix/build-system/go.scm | 3 +++ guix/build/go-build-system.scm | 7 ++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/guix/build-system/go.scm b/guix/build-system/go.scm index 100d1db4b6..a5aa21b99e 100644 --- a/guix/build-system/go.scm +++ b/guix/build-system/go.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2017 Leo Famulari ;;; Copyright © 2020 Jakub Kądziołka ;;; Copyright © 2021 Ludovic Courtès +;;; Copyright © 2021 Sarah Morgensen ;;; ;;; This file is part of GNU Guix. ;;; @@ -129,6 +130,7 @@ commit hash and its date rather than a proper release tag." (unpack-path "") (build-flags ''()) (tests? #t) + (parallel-build? #t) (allow-go-reference? #f) (system (%current-system)) (guile #f) @@ -153,6 +155,7 @@ commit hash and its date rather than a proper release tag." #:unpack-path #$unpack-path #:build-flags #$build-flags #:tests? #$tests? + #:parallel-build? #$parallel-build? #:allow-go-reference? #$allow-go-reference? #:inputs #$(input-tuples->gexp inputs))))) diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm index 227df820db..521bad9667 100644 --- a/guix/build/go-build-system.scm +++ b/guix/build/go-build-system.scm @@ -5,6 +5,7 @@ ;;; Copyright © 2020 Jack Hill ;;; Copyright © 2020 Jakub Kądziołka ;;; Copyright © 2020 Efraim Flashner +;;; Copyright © 2021 Sarah Morgensen ;;; ;;; This file is part of GNU Guix. ;;; @@ -216,8 +217,12 @@ unpacking." (_ #f)) inputs)))) -(define* (build #:key import-path build-flags #:allow-other-keys) +(define* (build #:key import-path build-flags (parallel-build? #t) + #:allow-other-keys) "Build the package named by IMPORT-PATH." + (let* ((njobs (if parallel-build? (parallel-job-count) 1))) + (setenv "GOMAXPROCS" (number->string njobs))) + (with-throw-handler #t (lambda _ -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 07 00:48:46 2021 Received: (at 49919) by debbugs.gnu.org; 7 Aug 2021 04:48:47 +0000 Received: from localhost ([127.0.0.1]:51728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mCEGM-0003oY-N9 for submit@debbugs.gnu.org; Sat, 07 Aug 2021 00:48:46 -0400 Received: from out1.migadu.com ([91.121.223.63]:22481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mCEGF-0003oE-IL for 49919@debbugs.gnu.org; Sat, 07 Aug 2021 00:48:39 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1628311719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jqqJTupahqpcZ9mq9+Q/+b1DXjcF3CEX0RrnivWcaUk=; b=WtUev9DoV4vMLRxjdR6oD9EFZKdrlX2cgQr4sw2MQWH31BT1z6L9SYw1P3yYMhWCkhHA4D jrf6btEUCP69APuxrJafZwQ7yRUxLtSs5+XORjEtsXZiLQNtZ57MWtWlf1xKnanH7YQFra 7Yse8IMYH69BIPwP63ySzGJt16k3/50= From: Sarah Morgensen To: 49919@debbugs.gnu.org Subject: [PATCH core-updates 2/2] build-system/go: Honor #:parallel-tests?. Date: Fri, 6 Aug 2021 21:48:34 -0700 Message-Id: <0ec3e2c95c5be19dd9c07dd21f7f55283ebdc9da.1628309588.git.iskarian@mgsn.dev> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49919 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) guix/build/go-build-system.scm (build): Honor #:parallel-tests?. guix/build-system/go.scm (go-build): Add PARALLEL-TESTS? parameter. [builder]: Use it. --- guix/build-system/go.scm | 2 ++ guix/build/go-build-system.scm | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/guix/build-system/go.scm b/guix/build-system/go.scm index a5aa21b99e..7b66163779 100644 --- a/guix/build-system/go.scm +++ b/guix/build-system/go.scm @@ -131,6 +131,7 @@ commit hash and its date rather than a proper release tag." (build-flags ''()) (tests? #t) (parallel-build? #t) + (parallel-tests? #t) (allow-go-reference? #f) (system (%current-system)) (guile #f) @@ -156,6 +157,7 @@ commit hash and its date rather than a proper release tag." #:build-flags #$build-flags #:tests? #$tests? #:parallel-build? #$parallel-build? + #:parallel-tests? #$parallel-tests? #:allow-go-reference? #$allow-go-reference? #:inputs #$(input-tuples->gexp inputs))))) diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm index 521bad9667..0ad580a484 100644 --- a/guix/build/go-build-system.scm +++ b/guix/build/go-build-system.scm @@ -239,9 +239,12 @@ unpacking." (invoke "go" "env")))) ;; Can this also install commands??? -(define* (check #:key tests? import-path #:allow-other-keys) +(define* (check #:key tests? import-path (parallel-tests? #t) + #:allow-other-keys) "Run the tests for the package named by IMPORT-PATH." (when tests? + (let* ((njobs (if parallel-tests? (parallel-job-count) 1))) + (setenv "GOMAXPROCS" (number->string njobs))) (invoke "go" "test" import-path)) #t) -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 19 11:14:02 2021 Received: (at 49919) by debbugs.gnu.org; 19 Aug 2021 15:14:02 +0000 Received: from localhost ([127.0.0.1]:60645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGjk1-0005Ux-QN for submit@debbugs.gnu.org; Thu, 19 Aug 2021 11:14:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGjk0-0005UX-3N for 49919@debbugs.gnu.org; Thu, 19 Aug 2021 11:14:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49806) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGjju-0001sO-7v; Thu, 19 Aug 2021 11:13:54 -0400 Received: from [2a01:cb18:832e:5f00:3563:417e:2a38:86d8] (port=48132 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGjjt-0001oE-Ul; Thu, 19 Aug 2021 11:13:54 -0400 From: Mathieu Othacehe To: Sarah Morgensen Subject: Re: bug#49919: [PATCH core-updates 0/2] build-system/go: Enable parallelism. References: Date: Thu, 19 Aug 2021 17:13:52 +0200 In-Reply-To: (Sarah Morgensen's message of "Fri, 6 Aug 2021 21:45:57 -0700") Message-ID: <87wnohcvrj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49919 Cc: 49919@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Sarah, > These patches give the Go build system the standard parallelism levers. I would > have thought that Go was already detecting the correct number for GOMAXPROCS, > but after I made this same change for the bootstrapping Go compiler, Efraim > found that it cut the build time nearly in half [0]. This looks good, but I'd rather have Cuirass fixed before pushing this series so that we can evaluate the impact on all Go packages and potentially find some regressions. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 31 06:16:10 2021 Received: (at 49919) by debbugs.gnu.org; 31 Aug 2021 10:16:10 +0000 Received: from localhost ([127.0.0.1]:33113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mL0oM-0003Av-9b for submit@debbugs.gnu.org; Tue, 31 Aug 2021 06:16:10 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:38866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mL0oH-0003AA-RX for 49919@debbugs.gnu.org; Tue, 31 Aug 2021 06:16:08 -0400 Received: by mail-wr1-f45.google.com with SMTP id u16so26802083wrn.5 for <49919@debbugs.gnu.org>; Tue, 31 Aug 2021 03:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version :content-transfer-encoding; bh=MpLfZiL8BNOD2jp61l2ce7gyTHitRSeCjVJDlyRZBzk=; b=rZR0HzY0mmpPb9vjcWxCH29Bzz5HiyOFPSS06Xegf6wxgQJ4qdQFW2qYd8EI7MAA9c mxOKzV+2Xlf6ga9JOFxr9f038HLJ/uHvnumZ5euK+Qm4gd9tqgUBHTM1jXj9IEhj36Or qS2wEtwZ8tQSOmaHIXaKQFLbXpvy5AOH0TVQt3ilK+0clILsEOiVfQeVbbgOJNJvn6+s AeKRvK+sKY+467/VDkseD7htDz2mbZqOzXUu9EXZtu52L+apl3BVvDthJ5DzsTeZ71TM j0yzj0gnZYmAu4hayrvBrkA2LYRctfXADcmerf+h9QvGuREVWi8QvljN4+imX8U9W8Je EdJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=MpLfZiL8BNOD2jp61l2ce7gyTHitRSeCjVJDlyRZBzk=; b=JFBEVtAfiHcfIoLS4e4pwPB9tq6fqcNmu/BBpy8SvXJQ9Oj1vwdapSYlN+iLMgtNEj KGBdntThcSPdHPhgFb0bbqV9kaYBLTpDpf2kPZoyjSiDOcDbyLhIo1vRDQo47HlH2rdA oE1CD2Y6i0v4oFv9ipTKUs7MhIMbWKh52S1aX0mKMDT3+8dTfNcfV6dxymjSbSLX0q0U M/XiGEqEo5gRh2SVHnu2TE0EW2jmZ5pWn29O48IT4po/QfkuXdeVqNBgM+TXEqR+Nv42 cmee2b6xbY9jhjVihn9y3LO/cMdM4rZWvHJNOGetjYI/Y9lopQSLu0flf+fQCQBs5amm silA== X-Gm-Message-State: AOAM531B7UxFVICPxbXz/2s59vAofTxKGsUIk3N0IgXopYcRwM1jjsYL pkAX1+qofBOJelMp2PetH+V0xs2QM6UoHg== X-Google-Smtp-Source: ABdhPJyU/c+go7nkjtmavG5yN+X88GTV/070N4HibEeX12PaZyNTqeZs2sFRKviFFkuSN5CrKzILIg== X-Received: by 2002:adf:9003:: with SMTP id h3mr13193701wrh.75.1630404960107; Tue, 31 Aug 2021 03:16:00 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id l15sm1893197wms.38.2021.08.31.03.15.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 03:15:59 -0700 (PDT) From: zimoun To: Sarah Morgensen , 49919@debbugs.gnu.org Subject: Re: [bug#49919] [PATCH core-updates 0/2] build-system/go: Enable parallelism. In-Reply-To: References: Date: Tue, 31 Aug 2021 12:03:19 +0200 Message-ID: <8635qqorrs.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49919 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Fri, 06 Aug 2021 at 21:45, Sarah Morgensen wrote: > These patches give the Go build system the standard parallelism levers. I= would > have thought that Go was already detecting the correct number for GOMAXPR= OCS, > but after I made this same change for the bootstrapping Go compiler, Efra= im > found that it cut the build time nearly in half [0]. > > [0] https://issues.guix.gnu.org/49616 Honoring the parallelism, do the Go packages still build deterministically? If not, the default should be still non parallel, as it is for Haskell packages, IIRC. However, maybe there is room for a package transformation =E2=80=99--with-parallelism=E2=80=99 to easily turn = on when speed matters more than reproducibility. All the best, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 31 12:06:32 2021 Received: (at 49919) by debbugs.gnu.org; 31 Aug 2021 16:06:32 +0000 Received: from localhost ([127.0.0.1]:35240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mL6HM-0006dM-4e for submit@debbugs.gnu.org; Tue, 31 Aug 2021 12:06:32 -0400 Received: from out1.migadu.com ([91.121.223.63]:45487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mL6HF-0006d9-Vs for 49919@debbugs.gnu.org; Tue, 31 Aug 2021 12:06:27 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1630425979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to; bh=9WIOgJyqw0qPMw1X2uIyHkn8zpvk07vmFGwbR16LA60=; b=KOh9uuGeaIi9RD46PdOFNWGdmkndUi3vhqKETBgNt/DMyVSwr4SGWeikxvGR80diAuPTPI HK+ysTJ5dib1I8V0BNIV/fek3JtTKrUbyDVSMz6AVL4XCUvD7Eb4frX9torai/dt9oRQAS BbhwWV/8iacnFaO67WsrDXDsq9jcrZA= From: Sarah Morgensen To: zimoun Subject: Re: [bug#49919] [PATCH core-updates 0/2] build-system/go: Enable parallelism. Date: Tue, 31 Aug 2021 09:06:17 -0700 In-Reply-To: zimoun's message of "Tue, 31 Aug 2021 12:03:19 +0200 (5 hours, 56 minutes, 10 seconds ago)" Message-ID: <86fsup1tvq.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49919 Cc: 49919@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, zimoun writes: > Hi, > > On Fri, 06 Aug 2021 at 21:45, Sarah Morgensen wrote: > >> These patches give the Go build system the standard parallelism levers. = I would >> have thought that Go was already detecting the correct number for GOMAXP= ROCS, >> but after I made this same change for the bootstrapping Go compiler, Efr= aim >> found that it cut the build time nearly in half [0]. >> >> [0] https://issues.guix.gnu.org/49616 > > Honoring the parallelism, do the Go packages still build > deterministically? If not, the default should be still non parallel, as > it is for Haskell packages, IIRC. However, maybe there is room for a > package transformation =E2=80=99--with-parallelism=E2=80=99 to easily tur= n on when speed > matters more than reproducibility. I haven't personally tested this aside from a few casual runs with --check, but from everything I understand about Go, parallelism does not affect build determinism. Each build unit should still be compiled by a single worker sequentially, but parallelism enables separate build units to be compiled in parallel. -- Sarah From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 15 05:36:04 2021 Received: (at 49919) by debbugs.gnu.org; 15 Dec 2021 10:36:04 +0000 Received: from localhost ([127.0.0.1]:60324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxRdk-0000fX-KC for submit@debbugs.gnu.org; Wed, 15 Dec 2021 05:36:04 -0500 Received: from flashner.co.il ([178.62.234.194]:54892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxRdj-0000ef-ID for 49919@debbugs.gnu.org; Wed, 15 Dec 2021 05:36:03 -0500 Received: from localhost (unknown [94.230.83.253]) by flashner.co.il (Postfix) with ESMTPSA id AC9DC4018B; Wed, 15 Dec 2021 10:35:57 +0000 (UTC) Date: Wed, 15 Dec 2021 12:35:25 +0200 From: Efraim Flashner To: Mathieu Othacehe Subject: Re: [bug#49919] [PATCH core-updates 0/2] build-system/go: Enable parallelism. Message-ID: Mail-Followup-To: Efraim Flashner , Mathieu Othacehe , Sarah Morgensen , 49919@debbugs.gnu.org References: <87wnohcvrj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GeTglt5Pgu11yBrE" Content-Disposition: inline In-Reply-To: <87wnohcvrj.fsf@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49919 Cc: Sarah Morgensen , 49919@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --GeTglt5Pgu11yBrE Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 19, 2021 at 05:13:52PM +0200, Mathieu Othacehe wrote: >=20 > Hello Sarah, >=20 > > These patches give the Go build system the standard parallelism levers.= I would > > have thought that Go was already detecting the correct number for GOMAX= PROCS, > > but after I made this same change for the bootstrapping Go compiler, Ef= raim > > found that it cut the build time nearly in half [0]. >=20 > This looks good, but I'd rather have Cuirass fixed before pushing this > series so that we can evaluate the impact on all Go packages and > potentially find some regressions. >=20 Friendly ping to see if Cuirass is ready for these patches to be pushed. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --GeTglt5Pgu11yBrE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmG5xO0ACgkQQarn3Mo9 g1GflA/9G2WUlly3Yqa7YVYLsykPKPd9fXwTr6LYhwQTdM8EunVPrDTnPPG50hA+ uzvs+ZbDR+rHD3Yo9DtWKCaekaSU7WeaQjJVOLQCz92JpYzAvhq8luniDHY7rZaR QpSPdgC3NofNZUI/SRpqcutH10rUZ/Ecrov1sES4N6/+NM/Lvewgz01EsSFEyJ3I yO1ETiK/TriyiNMwdoVdtiWTTt/RKrnvmI6Wv5qsGFdRmLVDNrxcakmAce2xKhz3 ky+NqMyePw0rpr7GCJbZh6OmVLRAg+eMaBgZvHqzLjsbtrhC5YuNwY9DLYJZKVbx +5zL1NcvQAOwv7Z25f35XSUQq0pev86E0q63gve0xOtir9YuAeflhOsrgOlU3cF6 o/FE8Cxk7fD0lz7XVAeLVvy3S0GplfWFOZDyaHbMYiNHBcgCNJ+FXPMZDwGvo87j HTM+lISs8tP2oW3vJ5oFft0gJ2jVLqRdyXJA7/CyhW26y07PeVKXx1Rv/5A9Wr7w izmnNjUOsy+JE9Ol93cXjI8FWd1S+Tryhwp9tRQDJJspl3Qr2N2WuVspjsopzRgd 8GX9gGggs3a2ICL9QrbIX+Hcw8g9d/Toiv8Dhp2BB5wgzYByik1DdAULwxV87NNw aSUsK0lo6H80J7qQtZAcWkVeINe76BHB/XvhKCmA/rpTC8FqLvk= =kEkm -----END PGP SIGNATURE----- --GeTglt5Pgu11yBrE-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 15 05:43:37 2021 Received: (at 49919) by debbugs.gnu.org; 15 Dec 2021 10:43:38 +0000 Received: from localhost ([127.0.0.1]:60334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxRl3-0000qP-Mr for submit@debbugs.gnu.org; Wed, 15 Dec 2021 05:43:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxRl0-0000qC-Rk for 49919@debbugs.gnu.org; Wed, 15 Dec 2021 05:43:36 -0500 Received: from [2001:470:142:3::e] (port=44162 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxRku-0003kI-Qg; Wed, 15 Dec 2021 05:43:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=KPagkPKHzD+gsw0yAVnf1Jz0OQxuPyrX4CQ1ReTCb1c=; b=T1pH8xkgo21H5F1M1JPB gqQpfwIbJz/Kf0kzZ9GqN/uLSw9ALJuQEaTyIQ3k1EMxbvrdfZuALAd6gPioKIAFQBu/yHjRYEqTu 8OF89kMhZDkbDJTYn8xe1dabbzTKpbPf+dDkGV1UE+yjDD10jpoCqM7gdV9q/5E841RxUqu2zwJvB vRa/UzSOdymuTLjmjeEyu7KAtnkWrtwLV9KJ6lXswvhvzoH/fg2zWqU7z80QgX60WgVpnhBGsgnQr JOQy4WNQclThyCMPiOsY+4oVCu27ONgUsv9camgFMbbCphIBUVq/1/ZtoG8xT1hSjGhjldQ67IrRg I28hrTqOKCx9lw==; Received: from lfbn-lyo-1-236-245.w86-202.abo.wanadoo.fr ([86.202.80.245]:48378 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxRku-00033U-PM; Wed, 15 Dec 2021 05:43:28 -0500 From: Mathieu Othacehe To: Efraim Flashner Subject: Re: [bug#49919] [PATCH core-updates 0/2] build-system/go: Enable parallelism. References: <87wnohcvrj.fsf@gnu.org> Date: Wed, 15 Dec 2021 11:43:25 +0100 In-Reply-To: (Efraim Flashner's message of "Wed, 15 Dec 2021 12:35:25 +0200") Message-ID: <87wnk6jghe.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49919 Cc: Sarah Morgensen , 49919@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, > Friendly ping to see if Cuirass is ready for these patches to be pushed. Not really, I need to reconfigure Berlin and I'm hitting multiple issues, such as a php build failure :(. Mathieu From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 20 15:50:06 2024 Received: (at 49919-done) by debbugs.gnu.org; 20 Jan 2024 20:50:06 +0000 Received: from localhost ([127.0.0.1]:35932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRII1-0004gJ-Vj for submit@debbugs.gnu.org; Sat, 20 Jan 2024 15:50:06 -0500 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]:48168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRII0-0004fa-II for 49919-done@debbugs.gnu.org; Sat, 20 Jan 2024 15:50:05 -0500 Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-4298b23abffso12417841cf.0 for <49919-done@debbugs.gnu.org>; Sat, 20 Jan 2024 12:50:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705783795; x=1706388595; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=U5M1MThCFqbHr84FMaCNrmMuQGCxl2eQMmSZy6Lo2tE=; b=kNe+9lri77Ehpsi2ElFc8ljVyOYMOMOaMWCgrcwpDPwj76jhle1Fk7QZ+sWC9krObO AKiWwdgsS7dzEcGpxjT2BbSspvPZWrZv/77ic9udk8NmaLd+3Py+B3ThQ+bH6U6BxMHG yGoUSlpaev4WpgNcKNeqHyNCqVSlUx0yuulu9+CMlbckUYO3K0lGnxHTtPUgE3umf68r 2IXoO3yRCguxcvyEhFr9nAAfRpksfNMR7aPD1hML6x06ZBi9/fdfZzyyF+2dzyjz93gh z+mCTCBJ9M6eAF36OX08OD9fQ9+yRlwpPY+FbWWFMU3ORVwDtYnn+wmSVYn1lof29Ugb nETA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705783795; x=1706388595; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U5M1MThCFqbHr84FMaCNrmMuQGCxl2eQMmSZy6Lo2tE=; b=REFeCY0gAElUR8wCDnL/zgCo9UfQmeGYqj5x0wjUBLhzW+bIqEBEHd4sNkr5juNVKx fso27SZscZqALSD/odX/OA/JOMM8nNxGVbtppYgT3vqpmwmCKMUAjse7Qkuwxf3ANetz MyVuhUoBfZX//nsLYJnZeZ6B2lqb7rwjcnlWssKo3Ano/wBd9jNJ6FngYuoCcTnC2KEk 8Wk/wByhKhRHJOsUX34ogziFM2l8kbBORUyX5P+SpNbHEOPEVhlQw8r3klHmKptoIgpM OYPkDgQ1ymaslcrujXfrIz4G9pxo4Nizab5Q/bW7oN68ybk3p/jyFHFAGZXN+V0NngNX +Pew== X-Gm-Message-State: AOJu0YygsGG3UtEXhubQzaGruVjxZrK3wHy8KltWu2xeO3vfuLTQmNrI 8QvIYWB8GV5NubMYesiYljecXHSbuweSy3c3T5uNzRAIFs9aecIHYKGKliZ3N0g= X-Google-Smtp-Source: AGHT+IGSr1N6drFQ7FfTnU0uVWQt9XOHbIOeAsl/KrGVYP7aeWItohp4kGP5IB6Tu8GY7d4xdf7U9A== X-Received: by 2002:a05:622a:1188:b0:42a:1e7e:55cb with SMTP id m8-20020a05622a118800b0042a1e7e55cbmr2447179qtk.8.1705783795585; Sat, 20 Jan 2024 12:49:55 -0800 (PST) Received: from hurd (dsl-10-128-232.b2b2c.ca. [72.10.128.232]) by smtp.gmail.com with ESMTPSA id bp44-20020a05622a1bac00b004299f09e3aesm962722qtb.51.2024.01.20.12.49.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jan 2024 12:49:55 -0800 (PST) From: Maxim Cournoyer To: Mathieu Othacehe Subject: Re: [bug#49919] [PATCH core-updates 0/2] build-system/go: Enable parallelism. In-Reply-To: <87wnk6jghe.fsf@gnu.org> (Mathieu Othacehe's message of "Wed, 15 Dec 2021 11:43:25 +0100") References: <87wnohcvrj.fsf@gnu.org> <87wnk6jghe.fsf@gnu.org> Date: Sat, 20 Jan 2024 15:49:53 -0500 Message-ID: <871qabenm6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49919-done Cc: 49919-done@debbugs.gnu.org, Sarah Morgensen , Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Mathieu Othacehe writes: > Hey, > >> Friendly ping to see if Cuirass is ready for these patches to be pushed. > > Not really, I need to reconfigure Berlin and I'm hitting multiple > issues, such as a php build failure :(. Queued for applying locally, at last. Closing. -- Thanks, Maxim From unknown Sun Jun 22 13:37:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 18 Feb 2024 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator