From unknown Thu Aug 14 22:22:23 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49917] [PATCH core-updates-frozen] gnu: go-1.14: Fix test failure with GCC 9+. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 06 Aug 2021 21:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49917 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49917@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162828603231907 (code B ref -1); Fri, 06 Aug 2021 21:41:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Aug 2021 21:40:32 +0000 Received: from localhost ([127.0.0.1]:51466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mC7Zw-0008IZ-0V for submit@debbugs.gnu.org; Fri, 06 Aug 2021 17:40:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:55586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mC7Zs-0008IQ-GR for submit@debbugs.gnu.org; Fri, 06 Aug 2021 17:40:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC7Zr-0001ol-IS for guix-patches@gnu.org; Fri, 06 Aug 2021 17:40:28 -0400 Received: from out1.migadu.com ([91.121.223.63]:54515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC7Zo-0006OX-Qb for guix-patches@gnu.org; Fri, 06 Aug 2021 17:40:27 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1628286021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=twJLBptFYPKNoDWVKi8UaiP3gZI6+AliXPXEQaPLYok=; b=BnT6Fz0nurMv2ui6LDswUAeikkoRB8HYvX7vOLm1/kROx5eNzUoke4UaGPaJ+UTtDeJp3w mEZGzNman0bbbUh7kVrr/UYAla5gTCl9kHNsxbe4ces2gOnyv+Cbu+Lhkc0gDHVRYeonuX 0QxOIANgwdfGhpC6+hGtdSkQnQ6turA= From: Sarah Morgensen Date: Fri, 6 Aug 2021 14:40:17 -0700 Message-Id: <5018c60ab22041bac940e7828fe197efcf8167e7.1628285642.git.iskarian@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=91.121.223.63; envelope-from=iskarian@mgsn.dev; helo=out1.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) With GCC 9+, go-1.14 fails a test when the gold linker is not available (https://github.com/golang/go/issues/39157). Backport the fix for that from https://github.com/golang/go/commit/4ec4a79. gnu/packages/golang.scm (go-1.14)[arguments]<#:phases>{prebuild}: Fix test failure with GCC 9+. --- Hello Guix, This fixes the CI failure at https://ci.guix.gnu.org/build/725502/details and probably for other platforms as well. This should also probably go to core-updates. -- Sarah gnu/packages/golang.scm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index d3ef39a2e6..cbcd9adb4c 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -1247,6 +1247,11 @@ in the style of communicating sequential processes (@dfn{CSP}).") (("/bin/pwd") (which "pwd")) (("/bin/sh") (which "sh"))) + ;; Backport fix for go-1.14 with GCC 9+ + ;; https://github.com/golang/go/issues/39157 + (substitute* "cmd/go/note_test.go" + (("cannot find 'ld'") "cannot find [‘']ld[’']")) + ;; Add libgcc to runpath (substitute* "cmd/link/internal/ld/lib.go" (("!rpath.set") "true")) base-commit: b2a5a180cfa56e55bc8078d606a971e34e326967 -- 2.31.1 From unknown Thu Aug 14 22:22:23 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Sarah Morgensen Subject: bug#49917: closed (Re: [bug#49917] [PATCH core-updates-frozen] gnu: go-1.14: Fix test failure with GCC 9+.) Message-ID: References: <5018c60ab22041bac940e7828fe197efcf8167e7.1628285642.git.iskarian@mgsn.dev> X-Gnu-PR-Message: they-closed 49917 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 49917@debbugs.gnu.org Date: Sun, 08 Aug 2021 12:17:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1628425022-6280-1" This is a multi-part message in MIME format... ------------=_1628425022-6280-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #49917: [PATCH core-updates-frozen] gnu: go-1.14: Fix test failure with GCC= 9+. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 49917@debbugs.gnu.org. --=20 49917: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D49917 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1628425022-6280-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 49917-done) by debbugs.gnu.org; 8 Aug 2021 12:16:47 +0000 Received: from localhost ([127.0.0.1]:53772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mChjT-0001cn-AG for submit@debbugs.gnu.org; Sun, 08 Aug 2021 08:16:47 -0400 Received: from flashner.co.il ([178.62.234.194]:58988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mChjP-0001cW-Fy for 49917-done@debbugs.gnu.org; Sun, 08 Aug 2021 08:16:46 -0400 Received: from localhost (unknown [141.226.169.107]) by flashner.co.il (Postfix) with ESMTPSA id 4D33B4027B; Sun, 8 Aug 2021 12:16:37 +0000 (UTC) Date: Sun, 8 Aug 2021 15:14:40 +0300 From: Efraim Flashner To: Sarah Morgensen Subject: Re: [bug#49917] [PATCH core-updates-frozen] gnu: go-1.14: Fix test failure with GCC 9+. Message-ID: Mail-Followup-To: Efraim Flashner , Sarah Morgensen , 49917-done@debbugs.gnu.org References: <5018c60ab22041bac940e7828fe197efcf8167e7.1628285642.git.iskarian@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DszZQ6jf+O+P0XP/" Content-Disposition: inline In-Reply-To: <5018c60ab22041bac940e7828fe197efcf8167e7.1628285642.git.iskarian@mgsn.dev> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49917-done Cc: 49917-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --DszZQ6jf+O+P0XP/ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thanks. Patch pushed. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --DszZQ6jf+O+P0XP/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmEPyq8ACgkQQarn3Mo9 g1EinRAAvbY5lMDRZkOZHpCyo7c5y5CIyCy1VZQ7cZRMepJwqUmARk8Vbnq+M+2D 08zMdKuT0msEyCZx26NOWDLiqHomN4jkIObsXUciPtlu5QwqiQz7Asuk3ejWxViu GG4yFlc7rg4lAR3IVGIwnvwpS/NtLeWOA0gO6OBO2fpcRSIc7JhgYOatlzJxUZJk i1fFNGGGaIDVaZ1SXQe1V/YwVkkhg++IMvXt18EBYLg65h/NgcTjA9bMj8zFexI+ eCBeZYGIEWLWOspfqlJLI9eS67sK0Gg8YjKwOb5JM9r2aQdUl4V9OC+Tvq/NkV1w KQXdPTAAWdFi6uOFNw+a1fiKayRAo5YBBTYSUYk8Wl0TaZKHyQqU888AUo8Bd0TH r2+JYz60yIfo1DZtd9CNIBamQvX3iVxYGm56G6OgQvBOohu52b8OsfuLog50bDei fiKb1t+LjFFqQMMdpxaf00uZFfWO5C+UUXLg0ckVior5zmfCD3W8FNtbrHZN+CpQ FFa/4WZbbeAAjbXvZYtjZuUtRllEyahmTgyScCbU5mEQZVbMtutUxTSi3SZ2/e5r SsFAEaoFF5udsMqDLRSZ8QplsXUmyMJYTAMj04pFCIsAgSYQaRiERuWh4n7Cdt+E DEOUbUtzGtbgDOIZNW0MJLtG7iUH2lP6JNhf18s85eQvblpo7bo= =y0iC -----END PGP SIGNATURE----- --DszZQ6jf+O+P0XP/-- ------------=_1628425022-6280-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Aug 2021 21:40:32 +0000 Received: from localhost ([127.0.0.1]:51466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mC7Zw-0008IZ-0V for submit@debbugs.gnu.org; Fri, 06 Aug 2021 17:40:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:55586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mC7Zs-0008IQ-GR for submit@debbugs.gnu.org; Fri, 06 Aug 2021 17:40:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC7Zr-0001ol-IS for guix-patches@gnu.org; Fri, 06 Aug 2021 17:40:28 -0400 Received: from out1.migadu.com ([91.121.223.63]:54515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC7Zo-0006OX-Qb for guix-patches@gnu.org; Fri, 06 Aug 2021 17:40:27 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1628286021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=twJLBptFYPKNoDWVKi8UaiP3gZI6+AliXPXEQaPLYok=; b=BnT6Fz0nurMv2ui6LDswUAeikkoRB8HYvX7vOLm1/kROx5eNzUoke4UaGPaJ+UTtDeJp3w mEZGzNman0bbbUh7kVrr/UYAla5gTCl9kHNsxbe4ces2gOnyv+Cbu+Lhkc0gDHVRYeonuX 0QxOIANgwdfGhpC6+hGtdSkQnQ6turA= From: Sarah Morgensen To: guix-patches@gnu.org Subject: [PATCH core-updates-frozen] gnu: go-1.14: Fix test failure with GCC 9+. Date: Fri, 6 Aug 2021 14:40:17 -0700 Message-Id: <5018c60ab22041bac940e7828fe197efcf8167e7.1628285642.git.iskarian@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=91.121.223.63; envelope-from=iskarian@mgsn.dev; helo=out1.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) With GCC 9+, go-1.14 fails a test when the gold linker is not available (https://github.com/golang/go/issues/39157). Backport the fix for that from https://github.com/golang/go/commit/4ec4a79. gnu/packages/golang.scm (go-1.14)[arguments]<#:phases>{prebuild}: Fix test failure with GCC 9+. --- Hello Guix, This fixes the CI failure at https://ci.guix.gnu.org/build/725502/details and probably for other platforms as well. This should also probably go to core-updates. -- Sarah gnu/packages/golang.scm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index d3ef39a2e6..cbcd9adb4c 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -1247,6 +1247,11 @@ in the style of communicating sequential processes (@dfn{CSP}).") (("/bin/pwd") (which "pwd")) (("/bin/sh") (which "sh"))) + ;; Backport fix for go-1.14 with GCC 9+ + ;; https://github.com/golang/go/issues/39157 + (substitute* "cmd/go/note_test.go" + (("cannot find 'ld'") "cannot find [‘']ld[’']")) + ;; Add libgcc to runpath (substitute* "cmd/link/internal/ld/lib.go" (("!rpath.set") "true")) base-commit: b2a5a180cfa56e55bc8078d606a971e34e326967 -- 2.31.1 ------------=_1628425022-6280-1--