GNU bug report logs - #49905
xref-find-references doesn't change directory to match relative filenames

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49905 in the body.
You can then email your comments to 49905 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: xref-find-references doesn't change directory to match relative
 filenames
Date: Fri, 06 Aug 2021 02:52:57 +0300

>> I have the same problem.  When calling xref-find-references
>> from a subdirectory, not from the project root, it creates
>> an*xref*  buffer where file names are relative to the
>> project root (when xref-file-name-display is 'project-relative'),
>> but the default directory is not the project root.
>> So using file-at-point fails to find the relative file.
>
> That sounds different. Could you file a separate report with exact
> reproduction steps? Try to make sure you're using the latest master first
> (I fixed bug ~like that a couple of months ago).
>
> FWIW, I'm cannot reproduce.

Why not?  Here is the reproduction steps:

0. run `emacs -Q`
1. open xref.el
2. type 'M-? xref-find-references RET'
3. check that default-directory of the output *xref* buffer
   with relative file names is not project's root.

Message #8 received at 49905 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Juri Linkov <juri <at> linkov.net>, 49905 <at> debbugs.gnu.org
Subject: Re: bug#49905: xref-find-references doesn't change directory to match
 relative filenames
Date: Fri, 6 Aug 2021 03:14:58 +0300

On 06.08.2021 02:52, Juri Linkov wrote:
> 3. check that default-directory of the output*xref*  buffer
>     with relative file names is not project's root.

But does that lead to you not being able to visit the references by 
pressing RET (or C-o)?

Message #11 received at 49905 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 49905 <at> debbugs.gnu.org
Subject: Re: bug#49905: xref-find-references doesn't change directory to
 match relative filenames
Date: Fri, 06 Aug 2021 03:36:51 +0300

>> 3. check that default-directory of the output*xref*  buffer
>>     with relative file names is not project's root.
>
> But does that lead to you not being able to visit the references by
> pressing RET (or C-o)?

No problem with RET and C-o, but e.g. using 'find-file-at-point'
on the file name fails to find the relative file name.

Message #14 received at 49905 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Juri Linkov <juri <at> linkov.net>
Cc: 49905 <at> debbugs.gnu.org
Subject: Re: bug#49905: xref-find-references doesn't change directory to match
 relative filenames
Date: Fri, 6 Aug 2021 11:55:45 +0300

On 06.08.2021 03:36, Juri Linkov wrote:
> No problem with RET and C-o, but e.g. using 'find-file-at-point'
> on the file name fails to find the relative file name.

Is that a real problem? Do you often use find-file-at-point in those 
buffers?

Perhaps the way to solve it is to finally make the groups "clickable" 
(as was requested at one point in that other report).

Changing default-directory to the project root might not be so easy: the 
part of the code that know about the current project, and the one that 
can be responsible for setting default-directory, are separate.

Message #17 received at 49905 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 49905 <at> debbugs.gnu.org
Subject: Re: bug#49905: xref-find-references doesn't change directory to
 match relative filenames
Date: Tue, 10 Aug 2021 10:10:07 +0300

>> No problem with RET and C-o, but e.g. using 'find-file-at-point'
>> on the file name fails to find the relative file name.
>
> Is that a real problem? Do you often use find-file-at-point in
> those buffers?
>
> Perhaps the way to solve it is to finally make the groups "clickable" (as
> was requested at one point in that other report).
>
> Changing default-directory to the project root might not be so easy: the
> part of the code that know about the current project, and the one that can
> be responsible for setting default-directory, are separate.

I thought the fix could be just adding setting default-directory in the
right place.  But if this is not easy then please close this request
since I don't use find-file-at-point often.

Message #22 received at 49905-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Juri Linkov <juri <at> linkov.net>
Cc: 49905-done <at> debbugs.gnu.org
Subject: Re: bug#49905: xref-find-references doesn't change directory to match
 relative filenames
Date: Sat, 14 Aug 2021 02:55:37 +0300

On 10.08.2021 10:10, Juri Linkov wrote:
> I thought the fix could be just adding setting default-directory in the
> right place.  But if this is not easy then please close this request
> since I don't use find-file-at-point often.

Yes. Sorry.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.