GNU bug report logs - #49897
28.0.50; [PATCH] Make sense of url-retrieve-synchronously

Previous Next

Full log

Message #8 received at 49897 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: dick.r.chiang <at> gmail.com
Cc: 49897 <at> debbugs.gnu.org
Subject: Re: bug#49897: 28.0.50; [PATCH] Make sense of
 url-retrieve-synchronously
Date: Fri, 06 Aug 2021 13:27:43 +0200

dick.r.chiang <at> gmail.com writes:

> It's impossible to reason about this function without the
> conveniences of throw-catch and unwind-protect.  Related bug#49861.

Well, that's a big change here, and the code had a lot of special-casing
to handle various edge cases with quit-ing and stuff...  which...  I
agree with you shouldn't be necessary, so I've done some tests and
applied your patch (with some trivial changes):

> +    (if-let ((start-time (current-time))

Doing if-lets on things that can't be nil is mildly confusing, so I
moved that up to the surrounding let...

> +             (proc-buffer (url-retrieve url callback nil silent inhibit-cookies)))

... and the same here, which allowed for less indentation.

So now I guess we'll wait for the bug reports to arrive about something
subtle not working any more here.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.