GNU bug report logs - #49881
[PATCH] gnu: mpfr-boot: Use gmp-boot as a dependency

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#49882: closed ([PATCH] gnu: mpc-boot: Use gmp-boot and
 mpfr-boot as dependencies)
Date: Thu, 12 Aug 2021 22:16:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 13 Aug 2021 00:14:46 +0200
with message-id <87o8a2gvjd.fsf_-_ <at> gnu.org>
and subject line Re: bug#49881: [PATCH] gnu: mpfr-boot: Use gmp-boot as a dependency
has caused the debbugs.gnu.org bug report #49881,
regarding [PATCH] gnu: mpc-boot: Use gmp-boot and mpfr-boot as dependencies
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
49881: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49881
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: guix-patches <at> gnu.org
Cc: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH] gnu: mpc-boot: Use gmp-boot and mpfr-boot as dependencies
Date: Wed,  4 Aug 2021 19:16:41 -0300

MPC 1.0 is incompatible with current versions of GMP and MPFR so use the
older ‘gmp-boot’ and ‘mpfr-boot’ packages as dependencies.

* gnu/packages/commencement.scm (mpc-boot)[propagated-inputs]: Add gmp-boot
and mpfr-boot.
---

Hello,

This fixes the build of mpc-boot on powerpc64le-linux on both master
and core-updates-frozen.  The patch applies cleanly on both branches.

I believe it will also do the same for x86_64-linux and i686-linux but
I wasn’t able to verify because guix was consuming too much memory for
my laptop.

I’ve been suggesting that these patches for gmp-boot, mpfr-boot and
mpc-boot be applied to the master branch because
`guix refresh -l $PACKAGE` shows that there are no dependants on these
packages.  But it just occurred to me that perhaps this may be a
limitation in ‘guix refresh’?


 gnu/packages/commencement.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm
index f8973392262f..c49428515eae 100644
--- a/gnu/packages/commencement.scm
+++ b/gnu/packages/commencement.scm
@@ -1882,7 +1882,9 @@ ac_cv_c_float_format='IEEE (little-endian)'
                     "mirror://gnu/mpc/mpc-" version ".tar.gz"))
               (sha256
                (base32
-                "1hzci2zrrd7v3g1jk35qindq05hbl0bhjcyyisq9z209xb3fqzb1"))))))
+                "1hzci2zrrd7v3g1jk35qindq05hbl0bhjcyyisq9z209xb3fqzb1"))))
+    (propagated-inputs `(("gmp" ,gmp-boot)              ; <mpc.h> refers to both
+                         ("mpfr" ,mpfr-boot)))))
 
 (define gcc-core-mesboot1
   ;; GCC 4.6.4 is the latest modular distribution.  This package is not

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Cc: 49881-done <at> debbugs.gnu.org
Subject: Re: bug#49881: [PATCH] gnu: mpfr-boot: Use gmp-boot as a dependency
Date: Fri, 13 Aug 2021 00:14:46 +0200

Hi,

Thiago Jung Bauermann <bauermann <at> kolabnow.com> skribis:

> Em quarta-feira, 11 de agosto de 2021, às 18:49:03 -03, Ludovic Courtès 
> escreveu:

[...]

>> Indeed.  However, it turns out that ‘gmp-boot’, ‘mpfr-boot’, and
>> ‘mpc-boot’ are not actually used as dependencies; we only ever use their
>> source.
>> 
>> I propose to instead make that explicit with the patch below.  WDYT?
>
> I think it’s a great solution! Much simpler than my patches for this issue 
> and also 49880 and 49882. Thank you very much for working on it.
>
> I also confirmed that with your patch, ‘gmp-boot’, ‘mpfr-boot’, and ‘mpc-
> boot’ “build” correctly on powerpc64le-linux (not that it really matters), 
> and they also “build” correctly on i686-linux. The latter system also 
> builds ‘gcc-core-mesboot1’ correctly.

Awesome, pushed as b417dde293080184dae9098e408849a237903a84.

> Out of curiosity, why did the CI even try to build ‘gmp-boot’, ‘mpfr-boot’, 
> and ‘mpc-boot’ on powerpc64le-linux? They’re not public packages, and 
> moreover they are only dependencies of ‘gcc-core-mesboot1’ which is only 
> relevant on i686-linux…

That comes from commit 37861f6c293d7ed1033050b2b0597885ba65186f.  The
motivation was to ensure that substitutes for these intermediate
packages would be available on the ci.guix front-end node.  Failing to
do that, Cuirass would not attempt fetch them from build nodes on the
front-end node.

Sorry that this caused a false alarm!

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.