From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 04 14:35:23 2021 Received: (at submit) by debbugs.gnu.org; 4 Aug 2021 18:35:24 +0000 Received: from localhost ([127.0.0.1]:45108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBLjf-0004pz-LJ for submit@debbugs.gnu.org; Wed, 04 Aug 2021 14:35:23 -0400 Received: from lists.gnu.org ([209.51.188.17]:41736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBLjd-0004pq-BQ for submit@debbugs.gnu.org; Wed, 04 Aug 2021 14:35:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBLjc-00045u-2p for guix-patches@gnu.org; Wed, 04 Aug 2021 14:35:20 -0400 Received: from mx.kolabnow.com ([95.128.36.41]:38576) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBLjY-0006zY-8g for guix-patches@gnu.org; Wed, 04 Aug 2021 14:35:19 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTP id 01D7C874 for ; Wed, 4 Aug 2021 20:35:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:date:date:subject:subject:from:from:received :received:received; s=dkim20160331; t=1628102110; x=1629916511; bh=OWm3E8mo57bxrWVNvTtfxAjxx4dbrL0Giv57No/c5mE=; b=OIiqvdmJLSFI LbaAdQ2dShngEc7H5MSThDb50TU84Ut9JALxUtc8c0vDnaLxei0eh0k92D7R0bil 7TPRADco1Og9WqLUv/KOMkpcUKJctxnNQWRl3CzosL/l9mJQlnLEiqSFZ/2IyjgU nIuFaLcFAdBfBm+Oss3+FbsOjFTelq/FAmkgauzRbXjS2onbfkGjvYiO+acz2toj c6vAFWm6Pbt0rsp8c1pLigpRu8cwqyHlA4vbl2XQSiNeaX4QM2jYCiqcEPozOPNQ apqT6pa+bj7ms+HRR0JrNq41U4hmFxocs4vnqbYSJ/sq9+H1QCpQXd1U3CzJZVLw ZpeqL75b+cELWrlL4MsD9qxVhgNNWY4sLYb0uR3hm2znX0ihRIEJkAiceFcdZ7XG eVItftSvP+I3p99Gzch+6R9sAcRXKNLmhfaGBvY0Q650VYjUWHOguTOCY0iUpnvw 9XTbUW+c7vxDxioTYl/tDcHh97DRt2jcGCMk+HVpb8w0XPr0rso21DJKeZ8LcaIN Af9wL2TQfUHo6hsMaEroSvkbNyamL/lnjCLapIfbnf4N6WeANPHYlc5r+WwNXjtr 0A8YKjRHBNHhGcj77bbSJ9IuqhCsl6Lz9p9LDKJGV3P1m7CXaxsRc9qLL10eRXn6 dfsx117U7PzpC6/5lEYf2Vx/fr6MChY= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-10 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zFHF0-1TSCRm for ; Wed, 4 Aug 2021 20:35:10 +0200 (CEST) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by ext-mx-out002.mykolab.com (Postfix) with ESMTPS id 6B96A49A for ; Wed, 4 Aug 2021 20:35:09 +0200 (CEST) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx002.mykolab.com (Postfix) with ESMTPS id 71A6657F4; Wed, 4 Aug 2021 20:35:08 +0200 (CEST) From: Thiago Jung Bauermann To: guix-patches@gnu.org Subject: [PATCH 1/2] gnu: gmp-boot: Fix build on powerpc64le-linux Date: Wed, 4 Aug 2021 15:34:54 -0300 Message-Id: <20210804183454.153783-1-bauermann@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=95.128.36.41; envelope-from=bauermann@kolabnow.com; helo=mx.kolabnow.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: submit Cc: Thiago Jung Bauermann X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Linux on powerpc64 used to run in big-endian mode only. When support for little-endian mode was added around 2014, they took the opportunity to update the ELF ABI. The new ABI is known as ELF ABI v2, and the old one retroactively called ELF ABI v1. GMP 4.3.2 was released in 2010, so its hand-optimized assembly code for powerpc64 only support ELF ABI v1. This causes a build failure on powerpc64le-linux, which can be fixed by passing a host triplet with the “none” CPU type. This tells the configure script to use generic C code for the build. * gnu/packages/commencement.scm (gmp-boot)[arguments]{#:configure-flags}: Add “--host=none-unknown-linux-gnu” for powerpc64le targets. --- Hello, This patch fixes the following build error on powerpc64le-linux (shown below for one file, but happens on several): ld: mpn/.libs/add_n.o: ABI version 1 is not compatible with ABI version 2 output ld: failed to merge target specific data of file mpn/.libs/add_n.o I started investigating the problem in core-udpates-frozen but the same issue happens in master as well so I suggest comitting it there instead. The patch applies cleanly to both branches. Thanks, Thiago gnu/packages/commencement.scm | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm index e7bd6cf002c7..ae3f07bc59ef 100644 --- a/gnu/packages/commencement.scm +++ b/gnu/packages/commencement.scm @@ -1840,7 +1840,23 @@ ac_cv_c_float_format='IEEE (little-endian)' (uri (string-append "mirror://gnu/gmp/gmp-" version ".tar.gz")) (sha256 (base32 - "15rwq54fi3s11izas6g985y9jklm3xprfsmym3v1g6xr84bavqvv")))))) + "15rwq54fi3s11izas6g985y9jklm3xprfsmym3v1g6xr84bavqvv")))) + (arguments + (substitute-keyword-arguments (package-arguments gmp) + ((#:configure-flags gmp-configure-flags) + `(cons* ,@(if (string-prefix? "powerpc64le-" (or (%current-target-system) + (%current-system))) + ;; The powerpc64 assembly code in this version of GMP + ;; only supports the ELF ABI v1 but powerpc64le uses ELF + ;; ABI v2, so use the generic C code instead. This is + ;; done by specifying the CPU type as “none”. + ;; + ;; According to the manual, “this will run quite slowly, + ;; but it should be portable and should at least make it + ;; possible to get something running if all else fails.” + '("--host=none-unknown-linux-gnu") + '()) + ,gmp-configure-flags)))))) (define mpfr-boot (package From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 04 14:41:53 2021 Received: (at 49880) by debbugs.gnu.org; 4 Aug 2021 18:41:53 +0000 Received: from localhost ([127.0.0.1]:45132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBLpx-00050F-2r for submit@debbugs.gnu.org; Wed, 04 Aug 2021 14:41:53 -0400 Received: from mx.kolabnow.com ([95.128.36.41]:9972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBLpv-000501-5u for 49880@debbugs.gnu.org; Wed, 04 Aug 2021 14:41:51 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out001.mykolab.com (Postfix) with ESMTP id E85F3CFD for <49880@debbugs.gnu.org>; Wed, 4 Aug 2021 20:41:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:mime-version:message-id:date:date :subject:subject:from:from:received:received:received; s= dkim20160331; t=1628102504; x=1629916905; bh=nfUtC4vWFPESexmRaiK Dcag3wXSk6yr4/ZYNzmfmAUM=; b=n3K5PzU4SXGGdgKnHBI1ispqZK0RQ2vCeSo SaSulF765WX6OloeXB6QmjxzyaDxWy10ZgBPR/IPgRpR5+CilAJPMgRVkZbtsXxM ncGVwgYYm0F0eEgpNJ1YkVKYt1Hj0I07NPx/U0Wg+GWNzri6NOdXlfddIzpW/NPm 6tEpTciGr+j3L1frAgRBv1dhdMAUBS3N/sD8dEnm7nHMEIsksLqLaJZIU5M5TyZ+ qoIM834iIu6rlVrUAcvE5b9vTDTct9TF8DYio/M43r3hXujRH69NlZ27s/H6xpRO XJUW5DaKxwrfhJYavtWNZ7Jf08Op0s7LRkum3DQ1sqHrVvRE5dMN1xJ8VRkE6Nag jC6BuaUeUbQZF7Ia6NiZnOv8EGrHf9K5tAFmi0wZLQNjZZsviu28lgjLbPqNOViY uUTSPArB7nkHXWfkV7opNvcbVjHRA/2MAF7H+7MTFJ0eId3mplzuQWcETgy8grkh gUi1/TETlH1yRwVmtgw95S7+vFJxMlnwGkjH8lMqkUZX9a3IdLjiwjFhu4nvea3+ pxfWixsqAXl5ORYZlEpxgsNGNR7LEL1i3mSdBnPTN6WrrhSAAWVzxuJulOUa8+f1 VR7XxFR32NsB/EAUo/4XvDwF30497Qi4zhgQ2IcbIY55HDFdFrISflSO3EDrfIT+ NOgq6wRg= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-10 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P461NOlnJL4Q for <49880@debbugs.gnu.org>; Wed, 4 Aug 2021 20:41:44 +0200 (CEST) Received: from int-mx003.mykolab.com (unknown [10.9.13.3]) by ext-mx-out001.mykolab.com (Postfix) with ESMTPS id 03786A2F for <49880@debbugs.gnu.org>; Wed, 4 Aug 2021 20:41:43 +0200 (CEST) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx003.mykolab.com (Postfix) with ESMTPS id 90DF0514D; Wed, 4 Aug 2021 20:41:43 +0200 (CEST) From: Thiago Jung Bauermann To: 49880@debbugs.gnu.org Subject: [PATCH 2/2] gnu: gmp-boot: Fix t-scan test crash Date: Wed, 4 Aug 2021 15:41:28 -0300 Message-Id: <20210804184128.153984-1-bauermann@kolabnow.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49880 Cc: Thiago Jung Bauermann X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) GMP 4.3 was released with a bug in the t-scan test which causes it to crash with a segmentation fault. Backport fix from upstream. * gnu/packages/commencement.scm (gmp-boot): Apply gmp-4.3-fix-t-scan-test.patch. * gnu/packages/patches/gmp-4.3-fix-t-scan-test.patch: New file. --- Hello, With this and the previous patch applied, gmp-boot builds successfully on powerpc64le-linux both in master and core-updates-frozen. It should also fix the same problem in i686-linux: https://ci.guix.gnu.org/build/699347/details gnu/packages/commencement.scm | 4 +++- .../patches/gmp-4.3-fix-t-scan-test.patch | 24 +++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/gmp-4.3-fix-t-scan-test.patch diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm index ae3f07bc59ef..16eb46d44d77 100644 --- a/gnu/packages/commencement.scm +++ b/gnu/packages/commencement.scm @@ -1840,7 +1840,9 @@ ac_cv_c_float_format='IEEE (little-endian)' (uri (string-append "mirror://gnu/gmp/gmp-" version ".tar.gz")) (sha256 (base32 - "15rwq54fi3s11izas6g985y9jklm3xprfsmym3v1g6xr84bavqvv")))) + "15rwq54fi3s11izas6g985y9jklm3xprfsmym3v1g6xr84bavqvv")) + ;; See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60933#c11 + (patches (search-patches "gmp-4.3-fix-t-scan-test.patch")))) (arguments (substitute-keyword-arguments (package-arguments gmp) ((#:configure-flags gmp-configure-flags) diff --git a/gnu/packages/patches/gmp-4.3-fix-t-scan-test.patch b/gnu/packages/patches/gmp-4.3-fix-t-scan-test.patch new file mode 100644 index 000000000000..85b4b666215a --- /dev/null +++ b/gnu/packages/patches/gmp-4.3-fix-t-scan-test.patch @@ -0,0 +1,24 @@ +Testcase fix obtained from upstream at: + +https://gmplib.org/repo/gmp/raw-rev/966737bd91ed + +# HG changeset patch +# User Torbjorn Granlund +# Date 1318259187 -7200 +# Node ID 966737bd91ed4cd158ca9730167f70db47442fc1 +# Parent 27913f466a23776215bd9341866e10a50cf61c01 +(check_ref): Fix loop end bound. + +diff -r 27913f466a23 -r 966737bd91ed tests/mpz/t-scan.c +--- a/tests/mpz/t-scan.c Mon Oct 10 12:06:39 2011 +0200 ++++ b/tests/mpz/t-scan.c Mon Oct 10 17:06:27 2011 +0200 +@@ -79,7 +79,7 @@ + + for (isize = 0; isize <= size; isize++) + { +- for (oindex = 0; oindex <= numberof (offset); oindex++) ++ for (oindex = 0; oindex < numberof (offset); oindex++) + { + o = offset[oindex]; + if ((int) isize*GMP_NUMB_BITS < -o) + From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 04 14:51:35 2021 Received: (at 49880) by debbugs.gnu.org; 4 Aug 2021 18:51:35 +0000 Received: from localhost ([127.0.0.1]:45143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBLzK-0005EH-T2 for submit@debbugs.gnu.org; Wed, 04 Aug 2021 14:51:35 -0400 Received: from mx.kolabnow.com ([95.128.36.40]:17134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBLzI-0005E1-Ae for 49880@debbugs.gnu.org; Wed, 04 Aug 2021 14:51:33 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out003.mykolab.com (Postfix) with ESMTP id 3D0A74080A for <49880@debbugs.gnu.org>; Wed, 4 Aug 2021 20:51:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:date:subject:subject :from:from:received:received:received; s=dkim20160331; t= 1628103085; x=1629917486; bh=8yB3FAWzGGfcOjSovo8EQ23Ur/GElZFJqtn 3aegolts=; b=NAj7L/4ag4Xc/ydClM6xSf0gFi01diAwXj4UE1EN6IFl5jCCnkj f4Xuppk+klf8P9OcmtVi+xVZ6R6aJdN41LG24MXxPlJtY42p6ViuO4YUSDmKQBEN dDw2u18VwfNS+urpdWuNlPk7cH3EvihLKP6zy4qt5ZHIIp5wVaiTZT7Y3FmB88Wt ZOlrf1Z22eRKBHn5a+wHFmW6LC9xL7SGWPUCsA1ywcpT0xtFuBTDaqDw+oMrWP10 z2scE386wrD/ihbhoRMwrHckhUmMoeHo9ql9osPQtUvvuaKGV2BiWpe4tiMlPoHz p8RybP5KCBs5+7DReb3Od8yTXR2keXAx4/djs80rQ2GVm8fWFQ0fNjQzgthQhENu 6TYPes9BqOD+KoaEw1Di27SHZRUnRXswZhlIhJMLHl/tYpPBJD8wXnZbQaid6Xtb dSefZWyES22JW0co+s70aSwambbN0Mx6adhveWbQqMofYj9fALeys0LaU7WLRDQq AFRfOgQRU+KMiIy18v+Hk9EinlIBF22iTCdmac0Cm3Uf91UCLjrcYYp1QPAvuwiA m6YcyOF0uC/WsnmbkWGokT2MlNBavQkIRjymHxLweaAE7XTv1annXrxPhocObf5f 2PEhtG95ikH0zC1/DIN6CMOQXY/t/GoT+19Ug/K40Ckul6d8o/ck+evY= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.899 X-Spam-Level: X-Spam-Status: No, score=-1.899 tagged_above=-10 required=5 tests=[BAYES_00=-1.9, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out003.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gaBt3X3QNBUH for <49880@debbugs.gnu.org>; Wed, 4 Aug 2021 20:51:25 +0200 (CEST) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by ext-mx-out003.mykolab.com (Postfix) with ESMTPS id 979AA403E5 for <49880@debbugs.gnu.org>; Wed, 4 Aug 2021 20:51:25 +0200 (CEST) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx001.mykolab.com (Postfix) with ESMTPS id 0E4EE23CB for <49880@debbugs.gnu.org>; Wed, 4 Aug 2021 20:51:24 +0200 (CEST) From: Thiago Jung Bauermann To: 49880@debbugs.gnu.org Subject: Re: [PATCH 2/2] gnu: gmp-boot: Fix t-scan test crash Date: Wed, 04 Aug 2021 15:51:19 -0300 Message-ID: <1657454.uzBIRb8K2f@popigai> In-Reply-To: <20210804184128.153984-1-bauermann@kolabnow.com> References: <20210804184128.153984-1-bauermann@kolabnow.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49880 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Em quarta-feira, 4 de agosto de 2021, =E0s 15:41:28 -03, Thiago Jung Bauerm= ann escreveu: > * gnu/packages/commencement.scm (gmp-boot): Apply > gmp-4.3-fix-t-scan-test.patch. > * gnu/packages/patches/gmp-4.3-fix-t-scan-test.patch: New file. Sorry, I just noticed that I forgot to add the new file to local.mk. Could you please squash this change when applying the patch? Alternatively, I can send a v2. Whichever you prefer. * gnu/local.mk (dist_patch_DATA): Add new patch. diff --git a/gnu/local.mk b/gnu/local.mk index e8494806fda5..ca8254c22320 100644 =2D-- a/gnu/local.mk +++ b/gnu/local.mk @@ -1163,6 +1163,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/glibc-2.28-supported-locales.patch \ %D%/packages/patches/glibc-2.29-supported-locales.patch \ %D%/packages/patches/glibc-supported-locales.patch \ + %D%/packages/patches/gmp-4.3-fix-t-scan-test.patch \ %D%/packages/patches/gmp-arm-asm-nothumb.patch \ %D%/packages/patches/gmp-faulty-test.patch \ %D%/packages/patches/gnash-fix-giflib-version.patch \ =2D-=20 Thanks, Thiago From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 11 17:29:36 2021 Received: (at 49880) by debbugs.gnu.org; 11 Aug 2021 21:29:36 +0000 Received: from localhost ([127.0.0.1]:36794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDvn6-00082y-Ck for submit@debbugs.gnu.org; Wed, 11 Aug 2021 17:29:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDvn4-00082k-Gq for 49880@debbugs.gnu.org; Wed, 11 Aug 2021 17:29:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46878) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDvmy-0004pK-Q4; Wed, 11 Aug 2021 17:29:28 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48774 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDvmy-0006OF-H2; Wed, 11 Aug 2021 17:29:28 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Thiago Jung Bauermann Subject: Re: bug#49880: [PATCH 1/2] gnu: gmp-boot: Fix build on powerpc64le-linux References: <20210804183454.153783-1-bauermann@kolabnow.com> Date: Wed, 11 Aug 2021 23:29:26 +0200 In-Reply-To: <20210804183454.153783-1-bauermann@kolabnow.com> (Thiago Jung Bauermann's message of "Wed, 4 Aug 2021 15:34:54 -0300") Message-ID: <878s17k6vd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49880 Cc: 49880@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Thiago Jung Bauermann skribis: > Linux on powerpc64 used to run in big-endian mode only. When support for > little-endian mode was added around 2014, they took the opportunity to > update the ELF ABI. The new ABI is known as ELF ABI v2, and the old one > retroactively called ELF ABI v1. > > GMP 4.3.2 was released in 2010, so its hand-optimized assembly code for > powerpc64 only support ELF ABI v1. This causes a build failure on > powerpc64le-linux, which can be fixed by passing a host triplet with the > =E2=80=9Cnone=E2=80=9D CPU type. This tells the configure script to use = generic C code for > the build. > > * gnu/packages/commencement.scm (gmp-boot)[arguments]{#:configure-flags}:= Add > =E2=80=9C--host=3Dnone-unknown-linux-gnu=E2=80=9D for powerpc64le targets. [...] > + (substitute-keyword-arguments (package-arguments gmp) > + ((#:configure-flags gmp-configure-flags) > + `(cons* ,@(if (string-prefix? "powerpc64le-" (or (%current-targe= t-system) > + (%current-syste= m))) > + ;; The powerpc64 assembly code in this version of = GMP > + ;; only supports the ELF ABI v1 but powerpc64le us= es ELF > + ;; ABI v2, so use the generic C code instead. Thi= s is > + ;; done by specifying the CPU type as =E2=80=9Cnon= e=E2=80=9D. > + ;; > + ;; According to the manual, =E2=80=9Cthis will run= quite slowly, > + ;; but it should be portable and should at least m= ake it > + ;; possible to get something running if all else f= ails.=E2=80=9D > + '("--host=3Dnone-unknown-linux-gnu") > + '()) > + ,gmp-configure-flags)))))) The patch LGTM. However, could you tweak it so we can apply it on =E2=80=98core-updates-frozen=E2=80=99 while not triggering a rebuild on oth= er arches? Something like: (if (string-prefix? =E2=80=A6) `(cons =E2=80=A6 ,gmp-configure-flags) gmp-configure-flags) TIA! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 11 17:34:40 2021 Received: (at 49880) by debbugs.gnu.org; 11 Aug 2021 21:34:40 +0000 Received: from localhost ([127.0.0.1]:36807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDvrz-0008EB-Ts for submit@debbugs.gnu.org; Wed, 11 Aug 2021 17:34:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDvry-0008Do-Bv for 49880@debbugs.gnu.org; Wed, 11 Aug 2021 17:34:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47020) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDvrs-0008E4-SZ; Wed, 11 Aug 2021 17:34:32 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48776 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDvrs-0000Ps-KN; Wed, 11 Aug 2021 17:34:32 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Thiago Jung Bauermann Subject: Re: bug#49880: [PATCH 1/2] gnu: gmp-boot: Fix build on powerpc64le-linux References: <20210804183454.153783-1-bauermann@kolabnow.com> <20210804184128.153984-1-bauermann@kolabnow.com> Date: Wed, 11 Aug 2021 23:34:31 +0200 In-Reply-To: <20210804184128.153984-1-bauermann@kolabnow.com> (Thiago Jung Bauermann's message of "Wed, 4 Aug 2021 15:41:28 -0300") Message-ID: <87zgtnis2g.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49880 Cc: 49880@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thiago Jung Bauermann skribis: > GMP 4.3 was released with a bug in the t-scan test which causes it to cra= sh > with a segmentation fault. Backport fix from upstream. > > * gnu/packages/commencement.scm (gmp-boot): Apply > gmp-4.3-fix-t-scan-test.patch. > * gnu/packages/patches/gmp-4.3-fix-t-scan-test.patch: New file. Please add the file to gnu/local.mk as well. > + ;; See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D6093= 3#c11 > + (patches (search-patches "gmp-4.3-fix-t-scan-test.patch"))= )) Comments about the patch should go at the top of the patch, preferably. So, we could avoid a world rebuild by applying the patch in a powerpc64le-specific build phase instead of adding it to =E2=80=98patches= =E2=80=99. Now, I suppose we=E2=80=99re just lucky that this test hasn=E2=80=99t crash= ed on other platforms, aren=E2=80=99t we? In that case, that would call for applying t= he patch (or skipping tests, even) unconditionally, thus triggering a world rebuild on all arches. Thoughts? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 11 17:50:52 2021 Received: (at control) by debbugs.gnu.org; 11 Aug 2021 21:50:52 +0000 Received: from localhost ([127.0.0.1]:36819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDw7f-0002N1-SR for submit@debbugs.gnu.org; Wed, 11 Aug 2021 17:50:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDw7e-0002Mm-4y for control@debbugs.gnu.org; Wed, 11 Aug 2021 17:50:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47228) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDw7Y-0002hY-Tw for control@debbugs.gnu.org; Wed, 11 Aug 2021 17:50:44 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48782 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDw7Y-0001hk-FE for control@debbugs.gnu.org; Wed, 11 Aug 2021 17:50:44 -0400 Date: Wed, 11 Aug 2021 23:50:43 +0200 Message-Id: <87r1ezirbg.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #49881 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 49881 49880 quit From unknown Fri Aug 22 01:33:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 12 Sep 2021 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator