GNU bug report logs - #49868
[PATCH 0/2] guix: dune-build-system: Add a profile parameter.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#49868: closed ([PATCH 0/2] guix: dune-build-system: Add a
 profile parameter.)
Date: Fri, 20 Aug 2021 22:10:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 21 Aug 2021 00:09:26 +0200
with message-id <20210821000926.00deacf3 <at> tachikoma.lepiller.eu>
and subject line Re: [bug#49868] [PATCH 0/2] guix: dune-build-system: Add a profile parameter.
has caused the debbugs.gnu.org bug report #49868,
regarding [PATCH 0/2] guix: dune-build-system: Add a profile parameter.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
49868: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49868
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: pukkamustard <pukkamustard <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: pukkamustard <pukkamustard <at> posteo.net>
Subject: [PATCH 0/2] guix: dune-build-system: Add a profile parameter.
Date: Wed,  4 Aug 2021 08:04:23 +0000

Hi,

This adds a profile parameter to the dune-build-system and sets it to "release" by default.

The exact effects of the "release" profile are not clearly documented in dune [1]. But it seems to be the default when installing packages with OPAM [2]. I think it should also be the default in Guix.

Some OCaml packages had set the profile to "release" manually by specifiying it in the build flags. This has been removed.

This patch will probably require a rebuild of almost all OCaml packages.

A second patch is attached that removes unnecessary arguments from the ocaml4.07-base packages. This is a more intrusive change to the package, so I've kept it in a separate commit.

-pukkamustard

[1] https://github.com/ocaml/dune/issues/3359
[2] https://dune.readthedocs.io/en/stable/faq.html#how-to-make-warnings-non-fatal

pukkamustard (2):
  guix: dune-build-system: Add a profile parameter.
  gnu: ocaml4.07-base: Remove unnecessary arguments.

 doc/guix.texi                    |  7 +++++++
 gnu/packages/ocaml.scm           | 27 ++++++---------------------
 guix/build-system/dune.scm       |  3 +++
 guix/build/dune-build-system.scm |  8 ++++++--
 4 files changed, 22 insertions(+), 23 deletions(-)

-- 
2.32.0

[Message part 3 (message/rfc822, inline)]

From: Julien Lepiller <julien <at> lepiller.eu>
To: pukkamustard <pukkamustard <at> posteo.net>
Cc: 49868-done <at> debbugs.gnu.org
Subject: Re: [bug#49868] [PATCH 0/2] guix: dune-build-system: Add a profile
 parameter.
Date: Sat, 21 Aug 2021 00:09:26 +0200

Pushed to master as 777ce1485749cc3dbe178fcc1e0654a7e74900c5 and
33a1ec29fa0ad72c61cef13c8af08c847eb399c1, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.