Subject: bug#49868: closed (Re: [bug#49868] [PATCH 0/2] guix: dune-build-system: Add a profile parameter.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 20 Aug 2021 22:10:02 +0000

Your bug report

#49868: [PATCH 0/2] guix: dune-build-system: Add a profile parameter.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
49868: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49868
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#49868] [PATCH 0/2] guix: dune-build-system: Add a profile parameter.
From: Julien Lepiller <[email-masked]>
To: pukkamustard <[email-masked]>
Cc: [email-masked]
Date: Sat, 21 Aug 2021 00:09:26 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Pushed to master as 777ce1485749cc3dbe178fcc1e0654a7e74900c5 and
33a1ec29fa0ad72c61cef13c8af08c847eb399c1, thanks!

Subject: [PATCH 0/2] guix: dune-build-system: Add a profile parameter.
From: pukkamustard <[email-masked]>
To: [email-masked]
Cc: pukkamustard <[email-masked]>
Date: Wed, 4 Aug 2021 08:04:23 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

This adds a profile parameter to the dune-build-system and sets it to "release" by default.

The exact effects of the "release" profile are not clearly documented in dune [1]. But it seems to be the default when installing packages with OPAM [2]. I think it should also be the default in Guix.

Some OCaml packages had set the profile to "release" manually by specifiying it in the build flags. This has been removed.

This patch will probably require a rebuild of almost all OCaml packages.

A second patch is attached that removes unnecessary arguments from the ocaml4.07-base packages. This is a more intrusive change to the package, so I've kept it in a separate commit.

-pukkamustard

[1] https://github.com/ocaml/dune/issues/3359
[2] https://dune.readthedocs.io/en/stable/faq.html#how-to-make-warnings-non-fatal

pukkamustard (2):
  guix: dune-build-system: Add a profile parameter.
  gnu: ocaml4.07-base: Remove unnecessary arguments.

 doc/guix.texi                    |  7 +++++++
 gnu/packages/ocaml.scm           | 27 ++++++---------------------
 guix/build-system/dune.scm       |  3 +++
 guix/build/dune-build-system.scm |  8 ++++++--
 4 files changed, 22 insertions(+), 23 deletions(-)

-- 
2.32.0