Subject: Re: [bug#49867] [PATCH 15/29] gnu: Add ocaml-ptime.

From: pukkamustard <[email-masked]>
Date: Sun, 08 Aug 2021 11:13:28 +0000

Xinglu Chen <[email-masked]> writes:

> Use (string-append "https://erratique.ch..." version ".tbz") to 
> make it
> easier to update the package in the future.

Done.

>> +       (sha256
>> +        (base32
>> + 
>> "1fxq57xy1ajzfdnvv5zfm7ap2nf49znw5f9gbi4kb9vds942ij27"))))
>> +    (build-system ocaml-build-system)
>> +    (arguments
>> +     `(#:tests? #f
>
> What’s the reason for disabling tests?
>

Laziness, I guess.. :)

Enabled in V2.

>> +    (description "Ptime has platform independent POSIX time 
>> support in pure
>> +OCaml. It provides a type to represent a well-defined range of 
>> POSIX
>          ^
> Double spacing.  :-)
>

Thanks!

>> +Ptime is not a calendar library.
>
> Not really sure if this sentence is necessary.  I think the 
> previous
> sentences has hade it pretty clear that it a time and date 
> library.
>

Agree, removed sentence.

>> +Ptime depends on the @code{ocaml-result} compatibility 
>> package. Ptime_clock
>> +depends on your system library. Ptime_clock's optional 
>> JavaScript support
>> +depends on @code{js-of-ocaml}.")
>
> This two sentences are probably also not necessary for users of 
> the
> package.  It should be the packager’s job to specify the 
> dependencies.  :-)

Also agree. Removed sentences.