GNU bug report logs - #49839
[PATCH] shepherd: add keep-tty flag to skip setsid

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49839 in the body.
You can then email your comments to 49839 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] shepherd: add keep-tty flag to skip setsid
Date: Tue, 03 Aug 2021 04:07:10 +0300

[Message part 1 (text/plain, inline)]

* modules/shepherd/service.scm: add keep-tty flag to skip setsid

when using shepherd as user, programs like xorg server, 
potentially any
program which ends up interacting with user, require terminal to 
remain.

currently, setsid is called unconditionally from exec-command 
function,
making it impossible to have such process.

this adds keep-tty flag to make-forkexec-constructor up to 
exec-command
function where setsid is actually called.

[shepherd-keep-tty.patch (text/x-patch, inline)]

diff --git a/modules/shepherd/service.scm b/modules/shepherd/service.scm
index 587ff68..1ae9544 100644
--- a/modules/shepherd/service.scm
+++ b/modules/shepherd/service.scm
@@ -786,6 +786,7 @@ daemon writing FILE is running in a separate PID namespace."
                        (log-file #f)
                        (directory (default-service-directory))
                        (file-creation-mask #f)
+                       (keep-tty #f)
                        (environment-variables (default-environment-variables)))
   "Run COMMAND as the current process from DIRECTORY, with FILE-CREATION-MASK
 if it's true, and with ENVIRONMENT-VARIABLES (a list of strings like
@@ -804,7 +805,7 @@ false."
     ((program args ...)
      ;; Become the leader of a new session and session group.
      ;; Programs such as 'mingetty' expect this.
-     (setsid)
+     (unless keep-tty (setsid))
 
      (chdir directory)
      (environ environment-variables)
@@ -889,6 +890,7 @@ false."
                             (log-file #f)
                             (directory (default-service-directory))
                             (file-creation-mask #f)
+                            (keep-tty #f)
                             (environment-variables
                              (default-environment-variables)))
   "Spawn a process that executed COMMAND as per 'exec-command', and return
@@ -920,6 +922,7 @@ its PID."
                           #:log-file log-file
                           #:directory directory
                           #:file-creation-mask file-creation-mask
+                          #:keep-tty keep-tty
                           #:environment-variables environment-variables))
           pid))))
 
@@ -929,6 +932,7 @@ its PID."
                                     (group #f)
                                     (supplementary-groups '())
                                     (directory (default-service-directory))
+                                    (keep-tty #f)
                                     (environment-variables
                                      (default-environment-variables))
                                     (file-creation-mask #f)
@@ -949,7 +953,9 @@ When @var{pid-file} is true, it must be the name of a PID file associated with
 the process being launched; the return value is the PID read from that file,
 once that file has been created.  If @var{pid-file} does not show up in less
 than @var{pid-file-timeout} seconds, the service is considered as failing to
-start."
+start.
+
+When @var{keep-tty} is true, will not call @code{setsid} for process."
   (lambda args
     (define (clean-up file)
       (when file
@@ -969,6 +975,7 @@ start."
                                   #:log-file log-file
                                   #:directory directory
                                   #:file-creation-mask file-creation-mask
+                                  #:keep-tty keep-tty
                                   #:environment-variables
                                   environment-variables)))
       (if pid-file

Message #10 received at 49839-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: muradm <mail <at> muradm.net>
Cc: 49839-done <at> debbugs.gnu.org
Subject: Re: bug#49839: [PATCH] shepherd: add keep-tty flag to skip setsid
Date: Tue, 10 Aug 2021 14:51:51 +0200

Hi,

muradm <mail <at> muradm.net> skribis:

> * modules/shepherd/service.scm: add keep-tty flag to skip setsid
>
> when using shepherd as user, programs like xorg server, potentially
> any
> program which ends up interacting with user, require terminal to
> remain.
>
> currently, setsid is called unconditionally from exec-command
> function,
> making it impossible to have such process.
>
> this adds keep-tty flag to make-forkexec-constructor up to
> exec-command
> function where setsid is actually called.
>
> diff --git a/modules/shepherd/service.scm b/modules/shepherd/service.scm
> index 587ff68..1ae9544 100644
> --- a/modules/shepherd/service.scm
> +++ b/modules/shepherd/service.scm
> @@ -786,6 +786,7 @@ daemon writing FILE is running in a separate PID namespace."
>                         (log-file #f)
>                         (directory (default-service-directory))
>                         (file-creation-mask #f)
> +                       (keep-tty #f)
>                         (environment-variables (default-environment-variables)))
>    "Run COMMAND as the current process from DIRECTORY, with FILE-CREATION-MASK
>  if it's true, and with ENVIRONMENT-VARIABLES (a list of strings like
> @@ -804,7 +805,7 @@ false."
>      ((program args ...)
>       ;; Become the leader of a new session and session group.
>       ;; Programs such as 'mingetty' expect this.
> -     (setsid)
> +     (unless keep-tty (setsid))

I did that slightly differently:

  https://git.savannah.gnu.org/cgit/shepherd.git/commit/?id=c43f81794344dbac31bcb8b8f1c0d266f47f14fa

Let me know if it works for you.

Thanks,
Ludo’.

Message #13 received at 49839-done <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 49839-done <at> debbugs.gnu.org
Subject: Re: bug#49839: [PATCH] shepherd: add keep-tty flag to skip setsid
Date: Wed, 11 Aug 2021 00:08:36 +0300

Hi,

Basically it is samething, should work.
Any idea when to expect it in public?

Thanks in advance,
muradm

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> muradm <mail <at> muradm.net> skribis:
>
>> * modules/shepherd/service.scm: add keep-tty flag to skip 
>> setsid
>>
>> when using shepherd as user, programs like xorg server, 
>> potentially
>> any
>> program which ends up interacting with user, require terminal 
>> to
>> remain.
>>
>> currently, setsid is called unconditionally from exec-command
>> function,
>> making it impossible to have such process.
>>
>> this adds keep-tty flag to make-forkexec-constructor up to
>> exec-command
>> function where setsid is actually called.
>>
>> diff --git a/modules/shepherd/service.scm 
>> b/modules/shepherd/service.scm
>> index 587ff68..1ae9544 100644
>> --- a/modules/shepherd/service.scm
>> +++ b/modules/shepherd/service.scm
>> @@ -786,6 +786,7 @@ daemon writing FILE is running in a 
>> separate PID namespace."
>>                         (log-file #f)
>>                         (directory (default-service-directory))
>>                         (file-creation-mask #f)
>> +                       (keep-tty #f)
>>                         (environment-variables (default-environment-variables)))
>>    "Run COMMAND as the current process from DIRECTORY, with 
>>    FILE-CREATION-MASK
>>  if it's true, and with ENVIRONMENT-VARIABLES (a list of 
>>  strings like
>> @@ -804,7 +805,7 @@ false."
>>      ((program args ...)
>>       ;; Become the leader of a new session and session group.
>>       ;; Programs such as 'mingetty' expect this.
>> -     (setsid)
>> +     (unless keep-tty (setsid))
>
> I did that slightly differently:
>
>   https://git.savannah.gnu.org/cgit/shepherd.git/commit/?id=c43f81794344dbac31bcb8b8f1c0d266f47f14fa
>
> Let me know if it works for you.
>
> Thanks,
> Ludo’.

Message #16 received at 49839-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: muradm <mail <at> muradm.net>
Cc: 49839-done <at> debbugs.gnu.org
Subject: Re: bug#49839: [PATCH] shepherd: add keep-tty flag to skip setsid
Date: Wed, 11 Aug 2021 11:57:43 +0200

Hi,

muradm <mail <at> muradm.net> skribis:

> Basically it is samething, should work.
> Any idea when to expect it in public?

There are no planned Shepherd releases currently, we’ll see…

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.