GNU bug report logs - #49828
[PATCH 00/20] Add minetest mods

Previous Next

Full log

Message #71 received at 49828 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 49828 <at> debbugs.gnu.org
Subject: Re: [PATCH 01/20] gnu: minetest: Respect --without-tests.
Date: Mon, 02 Aug 2021 19:18:48 +0200

[Message part 1 (text/plain, inline)]

Leo Prikler schreef op ma 02-08-2021 om 19:14 [+0200]:
> Hi Maxime,
> 
> Am Montag, den 02.08.2021, 17:50 +0200 schrieb Maxime Devos:
> > * gnu/packages/games.scm
> >   (minetest)[arguments]<#:phases>{check}: Use 'tests?' instead
> >   of ',(%current-target-system)'. Remove trailing #t.
> For context, (%current-target-system) is used because tests only work
> in native builds.  If this can't be reflected in the value of tests?,
> we should have both checks, imo.

'cmake-cross-build' sets '#:tests?' to #f by default, so I don't think
both checks are needed.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.