GNU bug report logs - #49828
[PATCH 00/20] Add minetest mods

Previous Next

Full log

Message #68 received at 49828 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Maxime Devos <maximedevos <at> telenet.be>, 49828 <at> debbugs.gnu.org
Subject: Re: [PATCH 01/20] gnu: minetest: Respect --without-tests.
Date: Mon, 02 Aug 2021 19:14:04 +0200

Hi Maxime,

Am Montag, den 02.08.2021, 17:50 +0200 schrieb Maxime Devos:
> * gnu/packages/games.scm
>   (minetest)[arguments]<#:phases>{check}: Use 'tests?' instead
>   of ',(%current-target-system)'. Remove trailing #t.
For context, (%current-target-system) is used because tests only work
in native builds.  If this can't be reflected in the value of tests?,
we should have both checks, imo.
> ---
>  gnu/packages/games.scm | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 8c6b5523f1..3e7086b398 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -3590,13 +3590,12 @@ match, cannon keep, and grave-itation pit.")
>                       (string-append (getcwd) "/games")) ; for check
>               #t))
>           (replace 'check
> -           (lambda _
> +           (lambda* (#:key tests? #:allow-other-keys)
>               ;; Thanks to our substitutions, the tests should also
> run
>               ;; when invoked on the target outside of `guix build'.
> -             (unless ,(%current-target-system)
> +             (when tests?
>                 (setenv "HOME" "/tmp")
> -               (invoke "src/minetest" "--run-unittests"))
> -             #t)))))
> +               (invoke "src/minetest" "--run-unittests")))))))
>      (native-search-paths
>       (list (search-path-specification
>              (variable "MINETEST_SUBGAME_PATH")

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.