GNU bug report logs - #49823
[PATCH] gnu: Add jsonnet.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#49823: closed ([PATCH] gnu: Add jsonnet.)
Date: Thu, 12 Aug 2021 07:55:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 12 Aug 2021 09:53:53 +0200
with message-id <87im0bhze6.fsf <at> gnu.org>
and subject line Re: bug#49823: [PATCH] gnu: Add jsonnet.
has caused the debbugs.gnu.org bug report #49823,
regarding [PATCH] gnu: Add jsonnet.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
49823: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49823
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add jsonnet.
Date: Mon, 02 Aug 2021 17:01:07 +0200

[Message part 3 (text/plain, inline)]

Hello,

Here is jsonnet. I don’t fully understand what it does, but thanks to
leoprikler, I know it is a dependency to package GraalJS, an
interpreter for JavaScript on the Java Virtual Machine.

For the sake of having "no dependencies", it bundles a custom
implementation of MD5. According to a comment in the associated
license, it is taken from the implementation of bzflag, but it does not
seem to use the same as of today.

I decided to use nettle, and add a few lines of C++ to shape it into
the required interface.

Best regards,

Vivien

[0001-gnu-Add-jsonnet.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: 49823-done <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>,
 Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Re: bug#49823: [PATCH] gnu: Add jsonnet.
Date: Thu, 12 Aug 2021 09:53:53 +0200

[Message part 6 (text/plain, inline)]

Hi Vivien,

Vivien Kraus <vivien <at> planete-kraus.eu> skribis:

> From 8ce461001ed14c3267d839334e4853feaed69b50 Mon Sep 17 00:00:00 2001
> From: Vivien Kraus <vivien <at> planete-kraus.eu>
> Date: Mon, 2 Aug 2021 16:07:08 +0200
> Subject: [PATCH] gnu: Add jsonnet.
>
> * gnu/packages/cpp.scm (jsonnet): New variable.

Applied with the tweak below.

Thank you, and thanks for taking the time for the extra work!

Ludo’.

[Message part 7 (text/x-patch, inline)]

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 870c02dac3..8c8109fb83 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -1232,16 +1232,13 @@ of reading and writing XML.")
             (rename-file "third_party/md5" ".md5")
             (delete-file-recursively "third_party")
             (delete-file-recursively "doc/third_party")
-            (substitute*
-                '("core/vm.cpp")
+            (substitute* '("core/vm.cpp")
               (("#include \"json.hpp\"") "#include <nlohmann/json.hpp>"))
             (mkdir "third_party")
             (rename-file ".md5" "third_party/md5")))))
     (build-system cmake-build-system)
     (arguments
      `(#:configure-flags '("-DUSE_SYSTEM_GTEST=ON" "-DUSE_SYSTEM_JSON=ON")))
-    (propagated-inputs
-     '())
     (native-inputs
      `(("googletest" ,googletest)
        ("pkg-config" ,pkg-config)))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.