GNU bug report logs - #49821
[PATCH] * lisp/delsel.el (minibuffer-keyboard-quit): Use abort-minibuffers

Previous Next

Package: emacs;

Reported by: Miha Rihtaršič <miha <at> kamnitnik.top>

Date: Mon, 2 Aug 2021 11:14:02 UTC

Severity: normal

Tags: patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49821 in the body.
You can then email your comments to 49821 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#49821; Package emacs. (Mon, 02 Aug 2021 11:14:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Miha Rihtaršič <miha <at> kamnitnik.top>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 02 Aug 2021 11:14:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Miha Rihtaršič <miha <at> kamnitnik.top>
To: bug-gnu-emacs <at> gnu.org
Cc: Miha Rihtaršič <miha <at> kamnitnik.top>
Subject: [PATCH] * lisp/delsel.el (minibuffer-keyboard-quit): Use
 abort-minibuffers
Date: Mon,  2 Aug 2021 13:16:01 +0200

---
Previously, C-g was bound to abort-recursive-edit, now it is bound to
abort-minibuffers.  However, after requiring delsel, it gets bound to
minibuffer-keyboard-quit, which still uses abort-recursive-edit.  Use
the new function instead.

 lisp/delsel.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/delsel.el b/lisp/delsel.el
index 3c99dd2344..93fdc6a886 100644
--- a/lisp/delsel.el
+++ b/lisp/delsel.el
@@ -300,7 +300,7 @@ minibuffer-keyboard-quit
   (interactive)
   (if (and delete-selection-mode (region-active-p))
       (setq deactivate-mark t)
-    (abort-recursive-edit)))
+    (abort-minibuffers)))
 
 (define-key minibuffer-local-map "\C-g" 'minibuffer-keyboard-quit)
 
-- 
2.32.0
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49821; Package emacs. (Wed, 04 Aug 2021 07:16:01 GMT) Full text and rfc822 format available.

Message #8 received at 49821 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Miha Rihtaršič <miha <at> kamnitnik.top>
Cc: 49821 <at> debbugs.gnu.org
Subject: Re: bug#49821: [PATCH] * lisp/delsel.el (minibuffer-keyboard-quit):
 Use abort-minibuffers
Date: Wed, 04 Aug 2021 09:15:47 +0200

Miha Rihtaršič <miha <at> kamnitnik.top> writes:

> Previously, C-g was bound to abort-recursive-edit, now it is bound to
> abort-minibuffers.  However, after requiring delsel, it gets bound to
> minibuffer-keyboard-quit, which still uses abort-recursive-edit.  Use
> the new function instead.

Makes sense to me; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
bug marked as fixed in version 28.1, send any further explanations to 49821 <at> debbugs.gnu.org and Miha Rihtaršič <miha <at> kamnitnik.top> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 04 Aug 2021 07:16:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 01 Sep 2021 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 5 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.