GNU bug report logs - #49819
[PATCH] gnu: Add emacs-geiser-chez.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49819 in the body.
You can then email your comments to 49819 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-geiser-chez.
Date: Mon, 02 Aug 2021 11:23:10 +0200

* gnu/packages/emacs-xyz.scm (emacs-geiser-chez): New variable.
---
 gnu/packages/emacs-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e3b94228e1..bbda1db614 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -138,6 +138,7 @@
   #:use-module (gnu packages aspell)
   #:use-module (gnu packages audio)
   #:use-module (gnu packages bash)
+  #:use-module (gnu packages chez)
   #:use-module (gnu packages cmake)
   #:use-module (gnu packages code)
   #:use-module (gnu packages cpp)
@@ -408,6 +409,48 @@ a generic Scheme interaction mode for the GNU Emacs editor.")
 a generic Scheme interaction mode for the GNU Emacs editor.")
     (license license:bsd-3)))
 
+(define-public emacs-geiser-chez
+  (package
+    (name "emacs-geiser-chez")
+    (version "0.16")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://gitlab.com/emacs-geiser/chez")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0cc1z5z5cpvxa5f3n8kvms0wxlybzcg4l1bh3rwv1l1sb0lk1xzx"))))
+    (build-system emacs-build-system)
+    (arguments
+     '(#:include (cons "^src/" %default-include)
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'make-autoloads 'patch-autoloads
+           (lambda* (#:key outputs #:allow-other-keys)
+             (substitute* (string-append
+                           (elpa-directory (assoc-ref outputs "out"))
+                           "/geiser-chez-autoloads.el")
+               ;; Activating implementations fails when Geiser is not yet
+               ;; loaded, so let's defer that until it is.
+               (("\\(geiser-activate-implementation .*\\)" all)
+                (string-append
+                 "(eval-after-load 'geiser-impl '" all ")"))
+               (("\\(geiser-implementation-extension .*\\)" all)
+                (string-append
+                 "(eval-after-load 'geiser-impl '" all ")"))))))))
+    (inputs
+     `(("chez-scheme" ,chez-scheme)))
+    (propagated-inputs
+     `(("emacs-geiser" ,emacs-geiser)))
+    (home-page "https://nongnu.org/geiser/")
+    (synopsis "Support for Chez Scheme in Geiser")
+    (description
+     "This package adds support for using Chez Scheme in Emacs with Geiser.")
+    (license license:bsd-3)))
+
 (define-public emacs-vc-hgcmd
   (package
     (name "emacs-vc-hgcmd")

base-commit: 536bec1ce5b3d68a6773f31e3788c63e8905ce98
-- 
2.32.0

Message #8 received at 49819 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 49819 <at> debbugs.gnu.org
Subject: Re: bug#49819: [PATCH] gnu: Add emacs-geiser-chez.
Date: Tue, 03 Aug 2021 15:01:04 -0400

Hello,

Xinglu Chen <public <at> yoctocell.xyz> writes:

> * gnu/packages/emacs-xyz.scm (emacs-geiser-chez): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index e3b94228e1..bbda1db614 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -138,6 +138,7 @@
>    #:use-module (gnu packages aspell)
>    #:use-module (gnu packages audio)
>    #:use-module (gnu packages bash)
> +  #:use-module (gnu packages chez)
>    #:use-module (gnu packages cmake)
>    #:use-module (gnu packages code)
>    #:use-module (gnu packages cpp)
> @@ -408,6 +409,48 @@ a generic Scheme interaction mode for the GNU Emacs editor.")
>  a generic Scheme interaction mode for the GNU Emacs editor.")
>      (license license:bsd-3)))
>  
> +(define-public emacs-geiser-chez
> +  (package
> +    (name "emacs-geiser-chez")
> +    (version "0.16")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://gitlab.com/emacs-geiser/chez")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "0cc1z5z5cpvxa5f3n8kvms0wxlybzcg4l1bh3rwv1l1sb0lk1xzx"))))
> +    (build-system emacs-build-system)
> +    (arguments
> +     '(#:include (cons "^src/" %default-include)
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'make-autoloads 'patch-autoloads
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (substitute* (string-append
> +                           (elpa-directory (assoc-ref outputs "out"))
> +                           "/geiser-chez-autoloads.el")
> +               ;; Activating implementations fails when Geiser is not yet
> +               ;; loaded, so let's defer that until it is.
> +               (("\\(geiser-activate-implementation .*\\)" all)
> +                (string-append
> +                 "(eval-after-load 'geiser-impl '" all ")"))
> +               (("\\(geiser-implementation-extension .*\\)" all)
> +                (string-append
> +                 "(eval-after-load 'geiser-impl '" all ")"))))))))

Could you please report the above issue to upstream so that it can
properly be fixed?  And then add a reference to it in a comment in the
above package definition.

> +    (inputs
> +     `(("chez-scheme" ,chez-scheme)))
> +    (propagated-inputs
> +     `(("emacs-geiser" ,emacs-geiser)))
> +    (home-page "https://nongnu.org/geiser/")
> +    (synopsis "Support for Chez Scheme in Geiser")
> +    (description
> +     "This package adds support for using Chez Scheme in Emacs with Geiser.")
> +    (license license:bsd-3)))
> +
>  (define-public emacs-vc-hgcmd
>    (package
>      (name "emacs-vc-hgcmd")

The rest LGTM!

Thank you,

Maxim

Message #11 received at 49819 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 49819 <at> debbugs.gnu.org
Subject: Re: [bug#49819] [PATCH] gnu: Add emacs-geiser-chez.
Date: Wed, 04 Aug 2021 10:14:34 +0200

[Message part 1 (text/plain, inline)]

On Tue, Aug 03 2021, Maxim Cournoyer wrote:

> Hello,
>
> Xinglu Chen <public <at> yoctocell.xyz> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-geiser-chez): New variable.
>> ---
>>  gnu/packages/emacs-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 43 insertions(+)
>>
>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>> index e3b94228e1..bbda1db614 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -138,6 +138,7 @@
>>    #:use-module (gnu packages aspell)
>>    #:use-module (gnu packages audio)
>>    #:use-module (gnu packages bash)
>> +  #:use-module (gnu packages chez)
>>    #:use-module (gnu packages cmake)
>>    #:use-module (gnu packages code)
>>    #:use-module (gnu packages cpp)
>> @@ -408,6 +409,48 @@ a generic Scheme interaction mode for the GNU Emacs editor.")
>>  a generic Scheme interaction mode for the GNU Emacs editor.")
>>      (license license:bsd-3)))
>>  
>> +(define-public emacs-geiser-chez
>> +  (package
>> +    (name "emacs-geiser-chez")
>> +    (version "0.16")
>> +    (source
>> +     (origin
>> +       (method git-fetch)
>> +       (uri (git-reference
>> +             (url "https://gitlab.com/emacs-geiser/chez")
>> +             (commit version)))
>> +       (file-name (git-file-name name version))
>> +       (sha256
>> +        (base32
>> +         "0cc1z5z5cpvxa5f3n8kvms0wxlybzcg4l1bh3rwv1l1sb0lk1xzx"))))
>> +    (build-system emacs-build-system)
>> +    (arguments
>> +     '(#:include (cons "^src/" %default-include)
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'make-autoloads 'patch-autoloads
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (substitute* (string-append
>> +                           (elpa-directory (assoc-ref outputs "out"))
>> +                           "/geiser-chez-autoloads.el")
>> +               ;; Activating implementations fails when Geiser is not yet
>> +               ;; loaded, so let's defer that until it is.
>> +               (("\\(geiser-activate-implementation .*\\)" all)
>> +                (string-append
>> +                 "(eval-after-load 'geiser-impl '" all ")"))
>> +               (("\\(geiser-implementation-extension .*\\)" all)
>> +                (string-append
>> +                 "(eval-after-load 'geiser-impl '" all ")"))))))))
>
> Could you please report the above issue to upstream so that it can
> properly be fixed?  And then add a reference to it in a comment in the
> above package definition.

Reported upstream; I will send a v2.  :)

  <https://gitlab.com/emacs-geiser/chez/-/issues/7>

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 49819 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: 49819 <at> debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: [PATCH v2] gnu: Add emacs-geiser-chez.
Date: Wed, 04 Aug 2021 10:17:55 +0200

* gnu/packages/emacs-xyz.scm (emacs-geiser-chez): New variable.
---
Changes since v1:

* Add link to upstream issue.

 gnu/packages/emacs-xyz.scm | 44 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e3b94228e1..f7763c7889 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -138,6 +138,7 @@
   #:use-module (gnu packages aspell)
   #:use-module (gnu packages audio)
   #:use-module (gnu packages bash)
+  #:use-module (gnu packages chez)
   #:use-module (gnu packages cmake)
   #:use-module (gnu packages code)
   #:use-module (gnu packages cpp)
@@ -408,6 +409,49 @@ a generic Scheme interaction mode for the GNU Emacs editor.")
 a generic Scheme interaction mode for the GNU Emacs editor.")
     (license license:bsd-3)))
 
+(define-public emacs-geiser-chez
+  (package
+    (name "emacs-geiser-chez")
+    (version "0.16")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://gitlab.com/emacs-geiser/chez")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0cc1z5z5cpvxa5f3n8kvms0wxlybzcg4l1bh3rwv1l1sb0lk1xzx"))))
+    (build-system emacs-build-system)
+    (arguments
+     '(#:include (cons "^src/" %default-include)
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'make-autoloads 'patch-autoloads
+           (lambda* (#:key outputs #:allow-other-keys)
+             (substitute* (string-append
+                           (elpa-directory (assoc-ref outputs "out"))
+                           "/geiser-chez-autoloads.el")
+               ;; Activating implementations fails when Geiser is not yet
+               ;; loaded, so let's defer that until it is.
+               ;; See <https://gitlab.com/emacs-geiser/chez/-/issues/7>.
+               (("\\(geiser-activate-implementation .*\\)" all)
+                (string-append
+                 "(eval-after-load 'geiser-impl '" all ")"))
+               (("\\(geiser-implementation-extension .*\\)" all)
+                (string-append
+                 "(eval-after-load 'geiser-impl '" all ")"))))))))
+    (inputs
+     `(("chez-scheme" ,chez-scheme)))
+    (propagated-inputs
+     `(("emacs-geiser" ,emacs-geiser)))
+    (home-page "https://nongnu.org/geiser/")
+    (synopsis "Support for Chez Scheme in Geiser")
+    (description
+     "This package adds support for using Chez Scheme in Emacs with Geiser.")
+    (license license:bsd-3)))
+
 (define-public emacs-vc-hgcmd
   (package
     (name "emacs-vc-hgcmd")

base-commit: 10f554700c417b84c22c56fdd007567a52c45d75
-- 
2.32.0

Message #19 received at 49819-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 49819-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Add emacs-geiser-chez.
Date: Wed, 04 Aug 2021 11:32:36 -0400

Hello,

Xinglu Chen <public <at> yoctocell.xyz> writes:

> * gnu/packages/emacs-xyz.scm (emacs-geiser-chez): New variable.
> ---
> Changes since v1:
>
> * Add link to upstream issue.
>
>  gnu/packages/emacs-xyz.scm | 44 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)

Pushed with commit dfb154e6d0.

Thanks!

Closing.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.