GNU bug report logs - #49813
[PATCH 00/34] Fix regexes in FIND-FILES invocations.

Previous Next

Full log

Message #113 received at 49813 <at> debbugs.gnu.org (full text, mbox):

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 49813 <at> debbugs.gnu.org
Subject: Re: [bug#49813] [PATCH 04/34] gnu: tao: Fix regex in FIND-FILES
 invocation.
Date: Sat, 28 Aug 2021 15:59:32 -0700

Hi Maxime,

Thanks for taking a look at this.

Maxime Devos <maximedevos <at> telenet.be> writes:

> Sarah Morgensen schreef op zo 01-08-2021 om 14:18 [-0700]:
>> -                         (find-files "include" "\\.h"))
>> +                         (find-files "include" "\\.h$"))
>
> C++ header files are sometimes named "something.hpp" instead
> of "something.h", so you might want to verify these don't exist.
> (And if they do exist, keep the regex "\\.h", or make it "\\.(h|hpp)$"?)
>
> Likewise for 'kaldi', 'shogun' and 'rtags'.  Otherwise, these
> new regexes look good to me (but I didn't test them).

Good catch.  I just checked the sources for all of those, and I can
verify that they don't exist.  (Shogun and rtags do have .hpp files in
their source, but only in other directories.)

--
Sarah

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.