GNU bug report logs - #4981
C-l during query-replace

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Juri Linkov <juri <at> jurta.org>
Subject: bug#4981: marked as done (C-l during query-replace)
Date: Mon, 30 Nov 2009 16:30:14 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 30 Nov 2009 18:06:33 +0200
with message-id <87skbwt9xq.fsf <at> mail.jurta.org>
and subject line Re: bug#4981: C-l during query-replace
has caused the Emacs bug report #4981,
regarding C-l during query-replace
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact help-debbugs <at> gnu.org
immediately.)


-- 
4981: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=4981
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: C-l during query-replace
Date: Thu, 19 Nov 2009 16:16:59 -0800 (PST)

C-l during query-replace should run `recenter-top-bottom', not
`recenter' for consistency with what C-l normally does nowadays.

[Message part 3 (message/rfc822, inline)]

From: Juri Linkov <juri <at> jurta.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 4981-done <at> debbugs.gnu.org, Dan Nicolaescu <dann <at> ics.uci.edu>
Subject: Re: bug#4981: C-l during query-replace
Date: Mon, 30 Nov 2009 18:06:33 +0200

> Why not:
>
>> Index: lisp/replace.el
>> ===================================================================
>> RCS file: /sources/emacs/emacs/lisp/replace.el,v
>> retrieving revision 1.287
>> diff -u -r1.287 replace.el
>> --- lisp/replace.el	12 Nov 2009 06:55:43 -0000	1.287
>> +++ lisp/replace.el	29 Nov 2009 23:43:28 -0000
>> @@ -1785,7 +1788,9 @@
>>  			((eq def 'skip)
>>  			 (setq done t))
>>  			((eq def 'recenter)
>> -			 (recenter nil))
>> +                      (let ((this-command 'recenter-top-bottom))
>> +			 (recenter-top-bottom)))
>>  			((eq def 'edit)
>>  			 (let ((opos (point-marker)))
>>  			   (setq real-match-data (replace-match-data

Thanks, this helped.  Fixed with more changes to keep the cycling order.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.