From dann@godzilla.ics.uci.edu Thu Nov 19 16:18:43 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 20 Nov 2009 00:18:43 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.8 required=4.0 tests=AWL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAK0IfcA030752 for ; Thu, 19 Nov 2009 16:18:43 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBHCz-0008Oc-Cn for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2009 19:18:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBHCu-0008I6-Su for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2009 19:18:41 -0500 Received: from [199.232.76.173] (port=50487 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBHCu-0008Hr-LB for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2009 19:18:36 -0500 Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]:53702) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NBHCu-0001bv-7h for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2009 19:18:36 -0500 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nAK0H0VS014000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 19 Nov 2009 16:17:00 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nAK0Gxf5005670; Thu, 19 Nov 2009 16:16:59 -0800 (PST) Date: Thu, 19 Nov 2009 16:16:59 -0800 (PST) Message-Id: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Subject: C-l during query-replace X-Debbugs-No-Ack: yes Lines: 3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nAK0H0VS014000 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) C-l during query-replace should run `recenter-top-bottom', not `recenter' for consistency with what C-l normally does nowadays. From juri@jurta.org Fri Nov 20 01:38:33 2009 Received: (at 4981) by emacsbugs.donarmstrong.com; 20 Nov 2009 09:38:33 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out3.starman.ee [85.253.0.5]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAK9cVxV020085 for <4981@emacsbugs.donarmstrong.com>; Fri, 20 Nov 2009 01:38:32 -0800 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.34.117.cable.starman.ee [82.131.34.117]) by mx1.starman.ee (Postfix) with ESMTP id 2994B3F40E5; Fri, 20 Nov 2009 11:38:25 +0200 (EET) From: Juri Linkov To: Dan Nicolaescu Cc: 4981@debbugs.gnu.org Subject: Re: bug#4981: C-l during query-replace Organization: JURTA References: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> Date: Fri, 20 Nov 2009 11:29:20 +0200 In-Reply-To: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Thu, 19 Nov 2009 16:16:59 -0800 (PST)") Message-ID: <873a49ad0f.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > C-l during query-replace should run `recenter-top-bottom', not > `recenter' for consistency with what C-l normally does nowadays. I guess there are many other places that need replacing with the new command (e.g. `gnus-recenter'). But with the patch I proposed in http://thread.gmane.org/gmane.emacs.devel/110349/focus=115915 the name `recenter-top-bottom' makes no sense anymore. Maybe we should rename it to something more suitable before replacing `recenter' calls with the new name everywhere? -- Juri Linkov http://www.jurta.org/emacs/ From juri@jurta.org Sun Nov 29 15:46:49 2009 Received: (at 4981) by emacsbugs.donarmstrong.com; 29 Nov 2009 23:46:49 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out3.starman.ee [85.253.0.5]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nATNkl4f028416 for <4981@emacsbugs.donarmstrong.com>; Sun, 29 Nov 2009 15:46:48 -0800 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.32.20.cable.starman.ee [82.131.32.20]) by mx1.starman.ee (Postfix) with ESMTP id 3FC833F40BF; Mon, 30 Nov 2009 01:46:41 +0200 (EET) From: Juri Linkov To: Dan Nicolaescu Cc: 4981@debbugs.gnu.org Subject: Re: bug#4981: C-l during query-replace Organization: JURTA References: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> <873a49ad0f.fsf@mail.jurta.org> Date: Mon, 30 Nov 2009 01:44:30 +0200 In-Reply-To: <873a49ad0f.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 20 Nov 2009 11:29:20 +0200") Message-ID: <87fx7w7v6p.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > I guess there are many other places that need replacing with the new > command (e.g. `gnus-recenter'). I fixed `gnus-recenter' in gnus-sum.el. > But with the patch I proposed in > http://thread.gmane.org/gmane.emacs.devel/110349/focus=115915 > the name `recenter-top-bottom' makes no sense anymore. > Maybe we should rename it to something more suitable > before replacing `recenter' calls with the new name everywhere? Installed. Currently I have no opinion about renaming `recenter-top-bottom' to something more reasonable. >> C-l during query-replace should run `recenter-top-bottom', not >> `recenter' for consistency with what C-l normally does nowadays. I can't find a clean solution because in the case of query-replace, `this-command' is always `query-replace'. This patch kinda works (though it doesn't reset the cycling order), but I don't like this. Index: lisp/window.el =================================================================== RCS file: /sources/emacs/emacs/lisp/window.el,v retrieving revision 1.190 diff -u -r1.190 window.el --- lisp/window.el 29 Nov 2009 23:34:09 -0000 1.190 +++ lisp/window.el 29 Nov 2009 23:42:30 -0000 @@ -1654,7 +1654,8 @@ (arg (recenter arg)) ; Always respect ARG. (t (setq recenter-last-op - (if (eq this-command last-command) + (if (or (eq this-command last-command) + (eq this-command 'query-replace)) (car (or (cdr (member recenter-last-op recenter-positions)) recenter-positions)) (car recenter-positions))) Index: lisp/replace.el =================================================================== RCS file: /sources/emacs/emacs/lisp/replace.el,v retrieving revision 1.287 diff -u -r1.287 replace.el --- lisp/replace.el 12 Nov 2009 06:55:43 -0000 1.287 +++ lisp/replace.el 29 Nov 2009 23:43:28 -0000 @@ -1785,7 +1788,9 @@ ((eq def 'skip) (setq done t)) ((eq def 'recenter) - (recenter nil)) + (recenter-top-bottom)) ((eq def 'edit) (let ((opos (point-marker))) (setq real-match-data (replace-match-data -- Juri Linkov http://www.jurta.org/emacs/ From monnier@iro.umontreal.ca Sun Nov 29 17:28:14 2009 Received: (at 4981) by emacsbugs.donarmstrong.com; 30 Nov 2009 01:28:14 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.183]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAU1SC5A005442 for <4981@emacsbugs.donarmstrong.com>; Sun, 29 Nov 2009 17:28:14 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqEEAKuuEktFpYc//2dsb2JhbACBTtIIhDEEihk X-IronPort-AV: E=Sophos;i="4.47,309,1257138000"; d="scan'208";a="50298798" Received: from 69-165-135-63.dsl.teksavvy.com (HELO ceviche.home) ([69.165.135.63]) by ironport2-out.pppoe.ca with ESMTP; 29 Nov 2009 20:28:07 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 4BF4A701E4; Sun, 29 Nov 2009 20:28:07 -0500 (EST) From: Stefan Monnier To: Juri Linkov Cc: 4981@debbugs.gnu.org, Dan Nicolaescu Subject: Re: bug#4981: C-l during query-replace Message-ID: References: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> <873a49ad0f.fsf@mail.jurta.org> <87fx7w7v6p.fsf@mail.jurta.org> Date: Sun, 29 Nov 2009 20:28:07 -0500 In-Reply-To: <87fx7w7v6p.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 30 Nov 2009 01:44:30 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > I can't find a clean solution because in the case of query-replace, > `this-command' is always `query-replace'. Why not: > Index: lisp/replace.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/replace.el,v > retrieving revision 1.287 > diff -u -r1.287 replace.el > --- lisp/replace.el 12 Nov 2009 06:55:43 -0000 1.287 > +++ lisp/replace.el 29 Nov 2009 23:43:28 -0000 > @@ -1785,7 +1788,9 @@ > ((eq def 'skip) > (setq done t)) > ((eq def 'recenter) > - (recenter nil)) > + (let ((this-command 'recenter-top-bottom)) > + (recenter-top-bottom))) > ((eq def 'edit) > (let ((opos (point-marker))) > (setq real-match-data (replace-match-data -- Stefan From dann@godzilla.ics.uci.edu Sun Nov 29 22:30:12 2009 Received: (at 4981) by emacsbugs.donarmstrong.com; 30 Nov 2009 06:30:13 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.2 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from paul-mcgann-v0.ics.uci.edu (paul-mcgann-v0.ics.uci.edu [128.195.1.147]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAU6UB95003634 for <4981@emacsbugs.donarmstrong.com>; Sun, 29 Nov 2009 22:30:12 -0800 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by paul-mcgann-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nAU6U09K015433 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 29 Nov 2009 22:30:00 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nAU6Txdn009909; Sun, 29 Nov 2009 22:29:59 -0800 (PST) Date: Sun, 29 Nov 2009 22:29:59 -0800 (PST) Message-Id: <200911300629.nAU6Txdn009909@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Juri Linkov Cc: 4981@debbugs.gnu.org Subject: Re: bug#4981: C-l during query-replace References: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> <873a49ad0f.fsf@mail.jurta.org> <87fx7w7v6p.fsf@mail.jurta.org> X-Debbugs-No-Ack: yes In-Reply-To: <87fx7w7v6p.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 30 Nov 2009 01:44:30 +0200") Lines: 64 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nAU6U09K015433 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Juri Linkov writes: > > I guess there are many other places that need replacing with the new > > command (e.g. `gnus-recenter'). > > I fixed `gnus-recenter' in gnus-sum.el. > > > But with the patch I proposed in > > http://thread.gmane.org/gmane.emacs.devel/110349/focus=115915 > > the name `recenter-top-bottom' makes no sense anymore. > > Maybe we should rename it to something more suitable > > before replacing `recenter' calls with the new name everywhere? > > Installed. Currently I have no opinion about renaming > `recenter-top-bottom' to something more reasonable. > > >> C-l during query-replace should run `recenter-top-bottom', not > >> `recenter' for consistency with what C-l normally does nowadays. > > I can't find a clean solution because in the case of query-replace, > `this-command' is always `query-replace'. > > This patch kinda works (though it doesn't reset the cycling order), > but I don't like this. > > Index: lisp/window.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/window.el,v > retrieving revision 1.190 > diff -u -r1.190 window.el > --- lisp/window.el 29 Nov 2009 23:34:09 -0000 1.190 > +++ lisp/window.el 29 Nov 2009 23:42:30 -0000 > @@ -1654,7 +1654,8 @@ > (arg (recenter arg)) ; Always respect ARG. > (t > (setq recenter-last-op > - (if (eq this-command last-command) > + (if (or (eq this-command last-command) > + (eq this-command 'query-replace)) > (car (or (cdr (member recenter-last-op recenter-positions)) > recenter-positions)) > (car recenter-positions))) > > Index: lisp/replace.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/replace.el,v > retrieving revision 1.287 > diff -u -r1.287 replace.el > --- lisp/replace.el 12 Nov 2009 06:55:43 -0000 1.287 > +++ lisp/replace.el 29 Nov 2009 23:43:28 -0000 > @@ -1785,7 +1788,9 @@ > ((eq def 'skip) > (setq done t)) > ((eq def 'recenter) > - (recenter nil)) > + (recenter-top-bottom)) > ((eq def 'edit) > (let ((opos (point-marker))) > (setq real-match-data (replace-match-data Thanks for fixing this. Are you sure that the new `recenter-positions' is needed? Given that there are 3 choices, it's easy to cycle through them, so adding yet another defcustom that would be use by a very small number of users does not seem justified (IMHO). From lekktu@gmail.com Mon Nov 30 03:12:56 2009 Received: (at 4981) by emacsbugs.donarmstrong.com; 30 Nov 2009 11:12:57 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-bw0-f227.google.com (mail-bw0-f227.google.com [209.85.218.227]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUBCs0e031756 for <4981@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 03:12:56 -0800 Received: by bwz27 with SMTP id 27so2493491bwz.1 for <4981@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 03:12:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=2X9DroJ7BCVJQ+RXELR17ju8L+u39hWxFoCBBanPQNg=; b=voLMLh8Hfa1NdUD/Ntw8HwmzIRBCLWKtjy1d4UMgRh4wAMX4Se7lyAkvCOA/k2FWQg vuZ/j795JVwRI20pSXZKypO5826SAg16LblpzjRpNOSWMVrakOiFdq9Cb3B/V0lJvUgH ECkeu8cnlNGyyF6Y22TVtbV8bESOWTlJZMDzw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=NOp3My385qPeDfAR22ys4P9ETc3UgsQc3yaum780o3iDsNtXugboa9Ca4cb7kPj5DB rg4NYTJhpGTIG/XwKoqt0Zp5zSua+v7VaLmOCQsX9etOQUbrLnKHfvAibxuqqjGg96Za DOXnibkA104kHdo+n1UQLckC7Iqcz/JPxqjRU= MIME-Version: 1.0 Received: by 10.204.11.23 with SMTP id r23mr4211092bkr.158.1259579569167; Mon, 30 Nov 2009 03:12:49 -0800 (PST) In-Reply-To: <200911300629.nAU6Txdn009909@godzilla.ics.uci.edu> References: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> <873a49ad0f.fsf@mail.jurta.org> <87fx7w7v6p.fsf@mail.jurta.org> <200911300629.nAU6Txdn009909@godzilla.ics.uci.edu> From: Juanma Barranquero Date: Mon, 30 Nov 2009 12:12:29 +0100 Message-ID: Subject: Re: bug#4981: C-l during query-replace To: Dan Nicolaescu Cc: Juri Linkov , 4981@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, Nov 30, 2009 at 07:29, Dan Nicolaescu wrote: > Are you sure that the new `recenter-positions' > is needed? =C2=A0Given that there are 3 choices, it's easy to cycle throu= gh > them With Juri's `recenter-positions', there are more than 3 choices. Juanma From juri@jurta.org Mon Nov 30 04:44:56 2009 Received: (at 4981) by emacsbugs.donarmstrong.com; 30 Nov 2009 12:44:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out3.starman.ee [85.253.0.5]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUCisZs007060 for <4981@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 04:44:56 -0800 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.52.137.cable.starman.ee [82.131.52.137]) by mx1.starman.ee (Postfix) with ESMTP id 2DEE43F4117; Mon, 30 Nov 2009 14:44:48 +0200 (EET) From: Juri Linkov To: Juanma Barranquero Cc: Dan Nicolaescu , 4981@debbugs.gnu.org Subject: Re: bug#4981: C-l during query-replace Organization: JURTA References: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> <873a49ad0f.fsf@mail.jurta.org> <87fx7w7v6p.fsf@mail.jurta.org> <200911300629.nAU6Txdn009909@godzilla.ics.uci.edu> Date: Mon, 30 Nov 2009 14:04:17 +0200 In-Reply-To: (Juanma Barranquero's message of "Mon, 30 Nov 2009 12:12:29 +0100") Message-ID: <873a3wuqxa.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit >> Are you sure that the new `recenter-positions' >> is needed?  Given that there are 3 choices, it's easy to cycle through >> them > > With Juri's `recenter-positions', there are more than 3 choices. Or what is more important, also *less* than 3 choices :-) E.g. when two positions is enough, I'd like to use for `recenter-positions' the value `(0.15 top)'. -- Juri Linkov http://www.jurta.org/emacs/ From monnier@iro.umontreal.ca Mon Nov 30 06:14:00 2009 Received: (at 4981) by emacsbugs.donarmstrong.com; 30 Nov 2009 14:14:00 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUEDwUQ015736 for <4981@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 06:14:00 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AroEAPZhE0tFpYc//2dsb2JhbACBTtVThDEEihmDDg X-IronPort-AV: E=Sophos;i="4.47,314,1257138000"; d="scan'208";a="50322603" Received: from 69-165-135-63.dsl.teksavvy.com (HELO pastel.home) ([69.165.135.63]) by ironport2-out.pppoe.ca with ESMTP; 30 Nov 2009 09:13:52 -0500 Received: by pastel.home (Postfix, from userid 20848) id 341BBEB978; Mon, 30 Nov 2009 09:13:52 -0500 (EST) From: Stefan Monnier To: Dan Nicolaescu Cc: 4981@debbugs.gnu.org, Juri Linkov Subject: Re: bug#4981: C-l during query-replace Message-ID: References: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> <873a49ad0f.fsf@mail.jurta.org> <87fx7w7v6p.fsf@mail.jurta.org> <200911300629.nAU6Txdn009909@godzilla.ics.uci.edu> Date: Mon, 30 Nov 2009 09:13:52 -0500 In-Reply-To: <200911300629.nAU6Txdn009909@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 29 Nov 2009 22:29:59 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Thanks for fixing this. Are you sure that the new `recenter-positions' > is needed? Given that there are 3 choices, it's easy to cycle through > them, so adding yet another defcustom that would be use by a very small > number of users does not seem justified (IMHO). I agree that it's overengineering. This patch is only acceptable if (to compensate) it unifies the two duplicate code paths of move-to-window-line-top-bottom and recenter-top-bottom. Stefan From juri@jurta.org Mon Nov 30 08:22:17 2009 Received: (at 4981) by emacsbugs.donarmstrong.com; 30 Nov 2009 16:22:17 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out4.starman.ee [85.253.0.6]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUGMFgg031747 for <4981@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 08:22:17 -0800 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.52.137.cable.starman.ee [82.131.52.137]) by mx2.starman.ee (Postfix) with ESMTP id C49B53F40A6; Mon, 30 Nov 2009 18:22:09 +0200 (EET) From: Juri Linkov To: Stefan Monnier Cc: Dan Nicolaescu , 4981@debbugs.gnu.org Subject: Re: bug#4981: C-l during query-replace Organization: JURTA References: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> <873a49ad0f.fsf@mail.jurta.org> <87fx7w7v6p.fsf@mail.jurta.org> <200911300629.nAU6Txdn009909@godzilla.ics.uci.edu> Date: Mon, 30 Nov 2009 18:07:45 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 30 Nov 2009 09:13:52 -0500") Message-ID: <87tywcqe94.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> Thanks for fixing this. Are you sure that the new `recenter-positions' >> is needed? Given that there are 3 choices, it's easy to cycle through >> them, so adding yet another defcustom that would be use by a very small >> number of users does not seem justified (IMHO). > > I agree that it's overengineering. I think what is overengineering is adding recenter-top-bottom in the first place. It imposes the arbitrary fixed cycling order on users with no hope to customize such fundamental feature as recentering. `recenter-positions' mitigates this problem in the true Emacs way as the *customizable* editor. Please also note that even a minor feature `next-error' allows a similar customization with `next-error-recenter'. Perhaps we should try to merge them, or at least provide a new option in `next-error-recenter' to use the first value of `recenter-positions' as the primary position the user prefers to put point after recentering. > This patch is only acceptable if (to compensate) it unifies the two > duplicate code paths of move-to-window-line-top-bottom and > recenter-top-bottom. Do you mean we should merge move-to-window-line-top-bottom and recenter-top-bottom into one function? -- Juri Linkov http://www.jurta.org/emacs/ From juri@jurta.org Mon Nov 30 08:22:17 2009 Received: (at 4981-done) by emacsbugs.donarmstrong.com; 30 Nov 2009 16:22:17 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out4.starman.ee [85.253.0.6]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUGMGC2031748 for <4981-done@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 08:22:17 -0800 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.52.137.cable.starman.ee [82.131.52.137]) by mx2.starman.ee (Postfix) with ESMTP id A3AAD3F4096; Mon, 30 Nov 2009 18:22:08 +0200 (EET) From: Juri Linkov To: Stefan Monnier Cc: 4981-done@debbugs.gnu.org, Dan Nicolaescu Subject: Re: bug#4981: C-l during query-replace Organization: JURTA References: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> <873a49ad0f.fsf@mail.jurta.org> <87fx7w7v6p.fsf@mail.jurta.org> Date: Mon, 30 Nov 2009 18:06:33 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 29 Nov 2009 20:28:07 -0500") Message-ID: <87skbwt9xq.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Why not: > >> Index: lisp/replace.el >> =================================================================== >> RCS file: /sources/emacs/emacs/lisp/replace.el,v >> retrieving revision 1.287 >> diff -u -r1.287 replace.el >> --- lisp/replace.el 12 Nov 2009 06:55:43 -0000 1.287 >> +++ lisp/replace.el 29 Nov 2009 23:43:28 -0000 >> @@ -1785,7 +1788,9 @@ >> ((eq def 'skip) >> (setq done t)) >> ((eq def 'recenter) >> - (recenter nil)) >> + (let ((this-command 'recenter-top-bottom)) >> + (recenter-top-bottom))) >> ((eq def 'edit) >> (let ((opos (point-marker))) >> (setq real-match-data (replace-match-data Thanks, this helped. Fixed with more changes to keep the cycling order. -- Juri Linkov http://www.jurta.org/emacs/ From drew.adams@oracle.com Mon Nov 30 09:24:47 2009 Received: (at 4981) by emacsbugs.donarmstrong.com; 30 Nov 2009 17:24:47 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from rgminet12.oracle.com (rcsinet12.oracle.com [148.87.113.124]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUHOjDq005154 for <4981@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 09:24:46 -0800 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id nAUHOVuv030020 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Nov 2009 17:24:32 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id nAUFRf1A006966; Mon, 30 Nov 2009 17:24:41 GMT Received: from abhmt012.oracle.com by acsmt354.oracle.com with ESMTP id 687483871259601874; Mon, 30 Nov 2009 09:24:34 -0800 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 30 Nov 2009 09:24:33 -0800 From: "Drew Adams" To: "'Juri Linkov'" , <4981@debbugs.gnu.org>, "'Stefan Monnier'" Cc: "'Dan Nicolaescu'" References: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu><873a49ad0f.fsf@mail.jurta.org> <87fx7w7v6p.fsf@mail.jurta.org><200911300629.nAU6Txdn009909@godzilla.ics.uci.edu> <87tywcqe94.fsf@mail.jurta.org> Subject: RE: bug#4981: C-l during query-replace Date: Mon, 30 Nov 2009 09:24:33 -0800 Message-ID: <713ECE6EFF3F4F51A45EBD56E1076DD1@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87tywcqe94.fsf@mail.jurta.org> Thread-Index: Acpx4AvqlHaEMpx0TPK8Sbcc870sgQAAKdFQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: acsmt355.oracle.com [141.146.40.155] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090206.4B13FFD4.0156:SCFMA4539814,ss=1,fgs=0 > >> Thanks for fixing this. Are you sure that the new > >> `recenter-positions' is needed? Given that there > >> are 3 choices, it's easy to cycle through > >> them, so adding yet another defcustom that would be use by > >> a very small number of users does not seem justified (IMHO). > > > > I agree that it's overengineering. > > I think what is overengineering is adding recenter-top-bottom > in the first place. It imposes the arbitrary fixed cycling order > on users with no hope to customize such fundamental feature as > recentering. `recenter-positions' mitigates this problem in the true > Emacs way as the *customizable* editor. As the one originally responsible for `recenter-top-bottom', let me chime in. ;-) 1. Just as with `recenter', a `recenter-top-bottom' user can always provide a prefix arg to get the exact behavior wanted. It imposes nothing more than `recenter' imposed. 2. The fact that we seem to be extending the use of this to other areas indicates that it has proved to be an improvement wrt `recenter'. 3. I have no objection to user's being able, via an option, to add more cycle points and define their positions. That's not overengineering, IMO. I think the default should be what `recenter-top-bottom' defined: 3 cycle points, top, center, bottom. - Drew From monnier@faina.iro.umontreal.ca Mon Nov 30 12:55:14 2009 Received: (at 4981) by emacsbugs.donarmstrong.com; 30 Nov 2009 20:55:14 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.9 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pruche.dit.umontreal.ca (pruche.dit.umontreal.ca [132.204.246.22]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUKtBgq025009 for <4981@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 12:55:13 -0800 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id nAUKtAaf028495; Mon, 30 Nov 2009 15:55:10 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 32D3E3A280; Mon, 30 Nov 2009 15:55:10 -0500 (EST) From: Stefan Monnier To: Juri Linkov Cc: Dan Nicolaescu , 4981@debbugs.gnu.org Subject: Re: bug#4981: C-l during query-replace Message-ID: References: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> <873a49ad0f.fsf@mail.jurta.org> <87fx7w7v6p.fsf@mail.jurta.org> <200911300629.nAU6Txdn009909@godzilla.ics.uci.edu> <87tywcqe94.fsf@mail.jurta.org> Date: Mon, 30 Nov 2009 15:55:10 -0500 In-Reply-To: <87tywcqe94.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 30 Nov 2009 18:07:45 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3417=0 > Do you mean we should merge move-to-window-line-top-bottom and > recenter-top-bottom into one function? No, but the core of both (which is identical) should be moved to a third function, used by the two commands. So as to remove the code duplication. Stefan From unknown Sun Jun 22 17:18:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 29 Dec 2009 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator