GNU bug report logs - #49800
28.0.50; [PATCH] Extend Gnus summary highlight faces by default

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49800 in the body.
You can then email your comments to 49800 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Protesilaos Stavrou <info <at> protesilaos.com>,
 Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: 28.0.50; [PATCH] Extend Gnus summary highlight faces by default
Date: Sun, 01 Aug 2021 00:12:59 +0200

[Message part 1 (text/plain, inline)]

Hello,

This is a followup to bug#47026, where we made
gnus-summary-highlight-line and gnus-highlight-selected-summary apply
the highlighting face up to and including the final newline.

In this new patch, I went over the faces in gnus-summary-highlight and
added :extend t to all of them.  Even though most of them have no
background or underline set in the default theme, :extend's special
handling means that other themes will not need to set that property
explicitly.

[0001-Extend-Gnus-summary-highlight-faces-by-default.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0)
 of 2021-07-30 built on hirondell
Repository revision: 5f65b67daccf7f4f30274f147a1adb5142328c6d
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description: Debian GNU/Linux 10 (buster)

Configured using:
 'configure --with-xwidgets --with-cairo'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
X11 XDBE XIM XPM XWIDGETS GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Message #8 received at 49800 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
Cc: 49800 <at> debbugs.gnu.org, Protesilaos Stavrou <info <at> protesilaos.com>
Subject: Re: bug#49800: 28.0.50; [PATCH] Extend Gnus summary highlight faces
 by default
Date: Sun, 01 Aug 2021 00:16:49 +0200

Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:

> In this new patch, I went over the faces in gnus-summary-highlight and
> added :extend t to all of them.  Even though most of them have no
> background or underline set in the default theme, :extend's special
> handling means that other themes will not need to set that property
> explicitly.

Makes sense to me.  Pushed to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 49800 <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 49800 <at> debbugs.gnu.org, Protesilaos Stavrou <info <at> protesilaos.com>
Subject: Re: bug#49800: 28.0.50; [PATCH] Extend Gnus summary highlight faces
 by default
Date: Sun, 01 Aug 2021 00:25:02 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:
>
>> In this new patch, I went over the faces in gnus-summary-highlight and
>> added :extend t to all of them.  Even though most of them have no
>> background or underline set in the default theme, :extend's special
>> handling means that other themes will not need to set that property
>> explicitly.
>
> Makes sense to me.  Pushed to Emacs 28.

Mmm, somehow I failed to include a couple of face names in the ChangeLog
entry…  I'm fairly certain I used C-x 4 a from a vc-diff buffer?

Sorry about that 😕  I'll be sure to triple-check the message next time.

Message #16 received at 49800 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
Cc: 49800 <at> debbugs.gnu.org, Protesilaos Stavrou <info <at> protesilaos.com>
Subject: Re: bug#49800: 28.0.50; [PATCH] Extend Gnus summary highlight faces
 by default
Date: Sun, 01 Aug 2021 00:26:42 +0200

Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:

> Mmm, somehow I failed to include a couple of face names in the ChangeLog
> entry…  I'm fairly certain I used C-x 4 a from a vc-diff buffer?
>
> Sorry about that 😕  I'll be sure to triple-check the message next time.

And I missed it too.  :-/  Oh, well, not a major deal...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.