From unknown Fri Jun 13 11:02:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49783] [PATCH] Add vimpc mpd client package definition Resent-From: guil_fsf@tutanota.com Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 30 Jul 2021 14:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49783 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49783@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162765493721806 (code B ref -1); Fri, 30 Jul 2021 14:23:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 Jul 2021 14:22:17 +0000 Received: from localhost ([127.0.0.1]:60662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9TOz-0005fX-5P for submit@debbugs.gnu.org; Fri, 30 Jul 2021 10:22:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:58474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9SbL-0002wW-CO for submit@debbugs.gnu.org; Fri, 30 Jul 2021 09:31:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9SbL-0005MQ-1V for guix-patches@gnu.org; Fri, 30 Jul 2021 09:30:59 -0400 Received: from w1.tutanota.de ([81.3.6.162]:53458) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9SbI-00046O-9x for guix-patches@gnu.org; Fri, 30 Jul 2021 09:30:58 -0400 Received: from w3.tutanota.de (unknown [192.168.1.164]) by w1.tutanota.de (Postfix) with ESMTP id D20BAFA030C for ; Fri, 30 Jul 2021 13:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1627651852; s=s1; d=tutanota.com; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:Sender; bh=+q7nu0nu624wbMSyejqQHMgj4JulD7hehwkD0eMmRSo=; b=IExVZAhT2ITFdOcq22o8g4Eq7wMSkB/fMeqvLNGbcmVT2zSyjGBvn9gSzR13DjFo HwZtb8bcea1TLg0J6nc+zG3Hegg7t5hQtlg75D7Wmi0UAGYDBePLasxhEh144/50AaJ XZ11zM8C3iSDX5i78TOnlbGkqWJW1b1qvYFU/UiVCjhl1Em5AI5HqnEz0kBFTNQDhSX nlnAIr+mXklhRmkuAAxLTpo0MG0XMDrFZBFfaBRGcqB9VjYbPGtz8K+fciEEmu3yo8p AFdQPXyWiNoC+dUmQSaUIDjcdDvE49p6OMD55TL+HCO2k2WzZ28S5LEwJSBVWvx7S4F +/xNIW1b2A== Date: Fri, 30 Jul 2021 15:30:52 +0200 (CEST) From: guil_fsf@tutanota.com Message-ID: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_273138_379000216.1627651852841" Received-SPF: pass client-ip=81.3.6.162; envelope-from=guil_fsf@tutanota.com; helo=w1.tutanota.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Mailman-Approved-At: Fri, 30 Jul 2021 10:22:15 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) ------=_Part_273138_379000216.1627651852841 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable --- gnu/packages/mpd.scm | 50 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm index b97abcafc3..2c1f189421 100644 --- a/gnu/packages/mpd.scm +++ b/gnu/packages/mpd.scm @@ -513,3 +513,53 @@ for your favorite MPD client but an addition to get a = better album-experience.") =C2=A0=C2=A0=C2=A0=C2=A0 (home-page "https://gitlab.com/coderkun/mcg") =C2=A0=C2=A0=C2=A0=C2=A0 (license license:gpl3+))) + +(define-module (vimpc) +=C2=A0 #:use-module (guix licenses) +=C2=A0 #:use-module (guix packages) +=C2=A0 #:use-module (guix build-system gnu) +=C2=A0 #:use-module (guix git-download) +=C2=A0 #:use-module (gnu packages mpd) +=C2=A0 #:use-module (gnu packages pcre) +=C2=A0 #:use-module (gnu packages mp3) +=C2=A0 #:use-module (gnu packages autotools) +=C2=A0 #:use-module (gnu packages curl) +=C2=A0 #:use-module (gnu packages pkg-config) +=C2=A0 #:use-module (gnu packages ncurses)) + +(define-public vimpc +=C2=A0 (package +=C2=A0=C2=A0 (name "vimpc") +=C2=A0=C2=A0 (version "0.09.2") + +=C2=A0=C2=A0 (source (origin +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (method= git-fetch) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (uri (g= it-reference +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (url "https://github.com/boysetsfrog/vimpc.g= it") +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (commit (string-append "v" version)))) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (sha256= (base32 "0lswzkap2nm7v5h7ppb6a64cb35rajysd09nb204rxgrkij4m6nx")) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (file-n= ame (git-file-name name version)))) +=C2=A0=C2=A0 (build-system gnu-build-system) +=C2=A0=C2=A0 (native-inputs `(("autoconf" ,autoconf) +=09=09=C2=A0=C2=A0=C2=A0 ("automake" ,automake))) +=C2=A0=C2=A0 (inputs `(("libmpdclient" ,libmpdclient) +=09=C2=A0=C2=A0=C2=A0=C2=A0 ("pcre" ,pcre) +=09=C2=A0=C2=A0=C2=A0=C2=A0 ("taglib" ,taglib) +=09=C2=A0=C2=A0=C2=A0=C2=A0 ("pkg-config" ,pkg-config) +=09=C2=A0=C2=A0=C2=A0=C2=A0 ("curl" ,curl) +=09=C2=A0=C2=A0=C2=A0=C2=A0 ("ncurses" ,ncurses) +=09=C2=A0=C2=A0=C2=A0=C2=A0 )) +=C2=A0=C2=A0 (arguments +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 `(#:tests? #false + +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:phases +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (modify-phases %standard-= phases +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (add-after 'u= npack 'fix-hardcoded-paths +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (= lambda _ +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (system* "./autogen") +=09=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ))))) + +=C2=A0=C2=A0 (synopsis "Vi-like Mpd TUI client written in C++") +=C2=A0=C2=A0 (description "Vimpc provides an alternative to other mpd clie= nts (such as ncmpc and ncmpcpp) that tries to provide an interface similar = to that of the vim text editor.") +=C2=A0=C2=A0 (home-page "https://github.com/boysetsfrog/vimpc") +=C2=A0=C2=A0 (license gpl3+))) -- 2.32.0=20 ------=_Part_273138_379000216.1627651852841 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
---
gnu/packages/mpd.scm | 50 +++++++++++++= +++++++++++++++++++++++++++++++
1 file changed, = 50 insertions(+)

dif= f --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index b97abcafc3..2c1f189421 100644
--- a/= gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm<= br>
@@ -513,3 +513,53 @@ for your favorite MPD clien= t but an addition to get a better
album-experien= ce.")
     (home-page "https://gitlab.com/coderkun/mcg"= )
     (license license:gpl3= +)))
+
+(define-modul= e (vimpc)
+  #:use-module (guix licenses)
+  #:use-module (guix packages)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix git-download)
+  #:use-module (gnu packages mpd)
+&n= bsp; #:use-module (gnu packages pcre)
+  #:= use-module (gnu packages mp3)
+  #:use-modu= le (gnu packages autotools)
+  #:use-module= (gnu packages curl)
+  #:use-module (gnu p= ackages pkg-config)
+  #:use-module (gnu pa= ckages ncurses))
+
+(= define-public vimpc
+  (package
+   (name "vimpc")
+&n= bsp;  (version "0.09.2")
+
+   (source (origin
+ =            (method git-fe= tch)
+       =      (uri (git-reference
+&n= bsp;            = ;     (url "https://github.com/boysetsfrog/vimpc.git")
+          &nbs= p;       (commit (string-append "v" version))= ))
+       &n= bsp;    (sha256 (base32 "0lswzkap2nm7v5h7ppb6a64cb35rajysd09= nb204rxgrkij4m6nx"))
+    &n= bsp;       (file-name (git-file-name name ver= sion))))
+   (build-system gnu-build-s= ystem)
+   (native-inputs `(("autoconf= " ,autoconf)
+=09=09    ("automak= e" ,automake)))
+   (inputs `(("libmpd= client" ,libmpdclient)
+=09   &nb= sp; ("pcre" ,pcre)
+=09     = ("taglib" ,taglib)
+=09     = ("pkg-config" ,pkg-config)
+=09   = ;  ("curl" ,curl)
+=09   &nb= sp; ("ncurses" ,ncurses)
+=09   &= nbsp; ))
+   (arguments
+       `(#:tests? #false
+
+    =      #:phases
+  &= nbsp;      (modify-phases %standard-phases
+         =   (add-after 'unpack 'fix-hardcoded-paths
+=              (l= ambda _
+      &nb= sp;           (system* ".= /autogen")
+=09     &nb= sp; )))))
+
+ &n= bsp; (synopsis "Vi-like Mpd TUI client written in C++")
+   (description "Vimpc provides an alternative to othe= r mpd clients (such as ncmpc and ncmpcpp) that tries to provide an interfac= e similar to that of the vim text editor.")
+&nb= sp;  (home-page "http= s://github.com/boysetsfrog/vimpc")
+ &n= bsp; (license gpl3+)))
--
2.32.0
------=_Part_273138_379000216.1627651852841-- From unknown Fri Jun 13 11:02:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49783] [PATCH] Add vimpc mpd client package definition Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 30 Jul 2021 18:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49783 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: guil_fsf@tutanota.com, 49783@debbugs.gnu.org Received: via spool by 49783-submit@debbugs.gnu.org id=B49783.162767132724595 (code B ref 49783); Fri, 30 Jul 2021 18:56:02 +0000 Received: (at 49783) by debbugs.gnu.org; 30 Jul 2021 18:55:27 +0000 Received: from localhost ([127.0.0.1]:60944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9XfL-0006Od-8W for submit@debbugs.gnu.org; Fri, 30 Jul 2021 14:55:27 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:41462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9XfH-0006OT-S3 for 49783@debbugs.gnu.org; Fri, 30 Jul 2021 14:55:25 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id bWvM2500U0mfAB406WvNEq; Fri, 30 Jul 2021 20:55:22 +0200 Message-ID: <245c92a24b2ea0e7d21190c2d3d1835d23168308.camel@telenet.be> From: Maxime Devos Date: Fri, 30 Jul 2021 20:55:14 +0200 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-wKXF8NzEA+GjRqjseiSh" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1627671322; bh=+0TFNbq7QTUj1+iTrrv0UQn9nYlitsD6NG9IP9aT4e8=; h=Subject:From:To:Date:In-Reply-To:References; b=jDnTQP94PKx+5kOlA3pHHAghYITXq99GAc2hwwFsbPfA8zkHGFeCRQeQkGduo6ZCe 1GfrP9x2FZPqTt55+yDKoDXgxT9cWWyJNhVY8DWQvSJ6U37KqeHdvDEs/dXhRJyCJn p467aAPYeEGlzbuBiPSwsA3Z7GRgCUcp1lXtKnYsQnuDNr5nB7MUj97wopgiD77EjK uiIMD/gW1VSlTjXDqNhTEdRQLL7gdosOS/QKKwgyqN5yjqyjVBNQb7dsSwKKNmS4JU LwAMedx67Yl76TqMZDHMTpfceIT4QlqZ6/VomLHOjWa9digXg5riJkkYP9xjgWao5i gq8wec/3BRsxw== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-wKXF8NzEA+GjRqjseiSh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, guil_fsf--- via Guix-patches via schreef op vr 30-07-2021 om 15:30 [+0200]: > --- > gnu/packages/mpd.scm | 50 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) A commit message is missing. > diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm > index b97abcafc3..2c1f189421 100644 > --- a/gnu/packages/mpd.scm > +++ b/gnu/packages/mpd.scm > @@ -513,3 +513,53 @@ for your favorite MPD client but an addition to get = a better > album-experience.") > (home-page "https://gitlab.com/coderkun/mcg") > (license license:gpl3+))) > + > +(define-module (vimpc) > + #:use-module (guix licenses) > + #:use-module (guix packages) > + #:use-module (guix build-system gnu) > + #:use-module (guix git-download) > + #:use-module (gnu packages mpd) > + #:use-module (gnu packages pcre) > + #:use-module (gnu packages mp3) > + #:use-module (gnu packages autotools) > + #:use-module (gnu packages curl) > + #:use-module (gnu packages pkg-config) > + #:use-module (gnu packages ncurses)) This define-module block can be removed, and the #:use-module can be moved to the top of the file. > +(define-public vimpc > + (package > + (name "vimpc") > + (version "0.09.2") > + > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/boysetsfrog/vimpc.git") I think there is a linter checking that ".git" is not included in GitHub URLs. Try "./pre-inst-env guix lint vimpc". > + (commit (string-append "v" version)))) > + (sha256 (base32 "0lswzkap2nm7v5h7ppb6a64cb35rajysd09nb204rxg= rkij4m6nx")) > + (file-name (git-file-name name version)))) > + (build-system gnu-build-system) > + (native-inputs `(("autoconf" ,autoconf) > + ("automake" ,automake))) > + (inputs `(("libmpdclient" ,libmpdclient) > + ("pcre" ,pcre) > + ("taglib" ,taglib) > + ("pkg-config" ,pkg-config) "pkg-config" should most likely be in 'native-inputs', not 'inputs'. The difference between 'inputs' and 'native-inputs' matters when cross-compiling. I'd suggest running "./pre-inst-env guix build vimpc --target=3Dx86_64-linux-gnu" for testing, but meson-build-system (used by libmpdclient) doesn't support cross-compilation yet (at least, on master it doesn't. On the core-updates branch, meson-build-system supports cross-compilation), so that wouldn't work yet anyway. > + ("curl" ,curl) > + ("ncurses" ,ncurses) > + )) > + (arguments > + `(#:tests? #false When disabling tests, always write a comment explaining why. If the tests fail, that may indicate a real problem (that's the purpose of tests). > + > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'fix-hardcoded-paths > + (lambda _ > + (system* "./autogen") > + ))))) The formatting went wrong here (whitespace and lonely parentheses). I'd recommend using "git format-patch HEAD^..HEAD" and sending the patch as an attachment, or using "git send-email". > + (synopsis "Vi-like Mpd TUI client written in C++") > + (description "Vimpc provides an alternative to other mpd clients (suc= h as ncmpc and ncmpcpp) that tries to provide an interface similar to that = of the vim text editor.") This description doesn't explain anything to people who don't know what 'Mpd', 'Vi', 'nmpc' and 'ncmpcpp' are. I only know of the first two (a music/video player and a customisable text editor), but only because I've read something about it some time ago.=20 Browsing through the source code, I notice files named "lyricsloader.cpp", "lyricsfetcher.cpp", "song.cpp". Maybe you could note that "vimpc" is a music player? Greetings, Maxime. --=-wKXF8NzEA+GjRqjseiSh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYQRLEhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7sUdAP9Y+dXhqXhwBrerRzDASJRBh/9t 6fejJbR/ibeE82suuwEApWE4V8Xr6ElCR67JtIowfrN/5GJbWfZldRNonZKzZAw= =6wKA -----END PGP SIGNATURE----- --=-wKXF8NzEA+GjRqjseiSh--