From unknown Sun Jun 15 08:26:10 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#49776 <49776@debbugs.gnu.org> To: bug#49776 <49776@debbugs.gnu.org> Subject: Status: 28.0.50; Incorrect username completion results reported by `read-file-name-interal` Reply-To: bug#49776 <49776@debbugs.gnu.org> Date: Sun, 15 Jun 2025 15:26:10 +0000 retitle 49776 28.0.50; Incorrect username completion results reported by `r= ead-file-name-interal` reassign 49776 emacs submitter 49776 Daniel Mendler severity 49776 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 29 18:18:06 2021 Received: (at submit) by debbugs.gnu.org; 29 Jul 2021 22:18:06 +0000 Received: from localhost ([127.0.0.1]:58414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9ELu-0004VK-GX for submit@debbugs.gnu.org; Thu, 29 Jul 2021 18:18:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:58138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9ELs-0004VB-Ud for submit@debbugs.gnu.org; Thu, 29 Jul 2021 18:18:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9ELs-0005le-Nz for bug-gnu-emacs@gnu.org; Thu, 29 Jul 2021 18:18:04 -0400 Received: from server.qxqx.de ([2a01:4f8:121:346::180]:40245 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9ELp-0000m4-FE for bug-gnu-emacs@gnu.org; Thu, 29 Jul 2021 18:18:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Date: Message-ID:Subject:From:To:Sender:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Qu7Mol4DoQ2zSTjMkSxR3kwL3dv1DsleQKYRcKKpJO8=; b=cokICopubgGbYlCDJWxZ9aElOU Ou+XVqXV+xVC4R71l5hD0xd9gFcoBAJcqqIWelgkg0iHJk0nNco4W+9QpD3slpYQuheB+CL8vozd1 RpxSZigidg71bCoj1va9tvrRkwKaUiUhkDk13LPKxaJ0c9j3rXHfJJuHzJ3my47uIt4Y=; To: bug-gnu-emacs@gnu.org From: Daniel Mendler Subject: 28.0.50; Incorrect username completion results reported by `read-file-name-interal` Message-ID: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> Date: Fri, 30 Jul 2021 00:17:40 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) `(all-completions "~/.config/~man" #'read-file-name-internal)` returns the list `("/.config/~man")`. The file completion table incorrectly recognizes "/.config/~man" as the username instead of only "~man". From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 30 01:47:57 2021 Received: (at 49776) by debbugs.gnu.org; 30 Jul 2021 05:47:57 +0000 Received: from localhost ([127.0.0.1]:58788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9LNF-0006pX-HD for submit@debbugs.gnu.org; Fri, 30 Jul 2021 01:47:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9LNE-0006pM-Hw for 49776@debbugs.gnu.org; Fri, 30 Jul 2021 01:47:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33028) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9LN9-0000IO-0b; Fri, 30 Jul 2021 01:47:51 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2162 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9LN8-00074V-LN; Fri, 30 Jul 2021 01:47:50 -0400 Date: Fri, 30 Jul 2021 08:47:33 +0300 Message-Id: <834kccs68a.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> (message from Daniel Mendler on Fri, 30 Jul 2021 00:17:40 +0200) Subject: Re: bug#49776: 28.0.50; Incorrect username completion results reported by `read-file-name-interal` References: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49776 Cc: 49776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Mendler > Date: Fri, 30 Jul 2021 00:17:40 +0200 > > `(all-completions "~/.config/~man" #'read-file-name-internal)` returns > the list `("/.config/~man")`. The file completion table incorrectly > recognizes "/.config/~man" as the username instead of only "~man". Why do you think that is incorrect? AFAIU, this is a well-documented behavior: "~" anywhere in the name discards everything before it. Exactly like "/" does. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 30 06:00:20 2021 Received: (at control) by debbugs.gnu.org; 30 Jul 2021 10:00:20 +0000 Received: from localhost ([127.0.0.1]:59024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9PJU-0006iJ-AX for submit@debbugs.gnu.org; Fri, 30 Jul 2021 06:00:20 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9PJS-0006i4-IE for control@debbugs.gnu.org; Fri, 30 Jul 2021 06:00:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3n9K7G1Wv0oIgop5KRcQPQF28Xuyv0hyE/trUxXDBHg=; b=cibBkEDAwEtO6SO6Ao+3m7qjbo 7clF5nWGHpTpLFWNNlAGkQRT6OCqo2FJ37krQ3yXRg8QjU3KovLg1cFXoz4VyrQLIQ0lpJZODnUOQ rvLgb0/xKmV6Y6dYVe0uVxPcHcClndrsXY1BwHB4vRFiKRXGTy1QeRcD5noAwuObcTGk=; Received: from 2.149.45.105.tmi.telenormobil.no ([2.149.45.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9PJJ-0005zF-Mg for control@debbugs.gnu.org; Fri, 30 Jul 2021 12:00:12 +0200 Date: Fri, 30 Jul 2021 12:00:07 +0200 Message-Id: <87y29oqfyw.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #49777 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: forcemerge 49777 49776 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) forcemerge 49777 49776 quit From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 30 07:47:37 2021 Received: (at 49776) by debbugs.gnu.org; 30 Jul 2021 11:47:38 +0000 Received: from localhost ([127.0.0.1]:59169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9QzJ-0007NR-CN for submit@debbugs.gnu.org; Fri, 30 Jul 2021 07:47:37 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9QzH-0007HY-BA for 49776@debbugs.gnu.org; Fri, 30 Jul 2021 07:47:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MRePaZ5u/AsFSU8+OW1G6wuj+2hR98t+UHfCeZg38Ew=; b=CxUX8Q7WmBfxU1HYumIU9n/V8G 4+I+Tj3mGfM8KMg92PekVK0UvOjmEhCCFvzlJr6pZGxWMNvpt4Fx9UcCZ2rucjaJJb2Tdr7iBTceX Z9z+GwE3j5jGPLDTb3EP8XvvyHXTWFs1Wz5Nz3wkvhpk1tQA+3aQG4/EbSbIbBt83oGQ=; Received: from 2.149.45.105.tmi.telenormobil.no ([2.149.45.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9Qz8-00070w-10; Fri, 30 Jul 2021 13:47:28 +0200 From: Lars Ingebrigtsen To: Daniel Mendler Subject: Re: bug#49776: 28.0.50; Incorrect username completion results reported by `read-file-name-interal` References: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> Date: Fri, 30 Jul 2021 13:47:23 +0200 In-Reply-To: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> (Daniel Mendler's message of "Fri, 30 Jul 2021 00:17:40 +0200") Message-ID: <87bl6kowfo.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Daniel Mendler writes: > `(all-completions "~/.config/~man" #'read-file-name-internal)` returns > the list `("/.config/~man")`. The file completion table incorrectly > recognizes "/.config/~man" as the username instead of o [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49776 Cc: 49776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Daniel Mendler writes: > `(all-completions "~/.config/~man" #'read-file-name-internal)` returns > the list `("/.config/~man")`. The file completion table incorrectly > recognizes "/.config/~man" as the username instead of only "~man". I'm unable to reproduce this problem, and you haven't used `M-x report-emacs-bug', so I don't know what system you're seeing this on. I'm getting the expected on Debian/bullseye: (all-completions "~/.config/~man" #'read-file-name-internal) => (#("/.config/~man/" 0 13 (face completions-common-part))) That is, it's expanding ~man to ~man/ since it interprets that bit as a user name. And, of course: (all-completions "~/.config/~man/" #'read-file-name-internal) => ("tr/" "zh/" "CACHEDIR.TAG" "de/" "ru/" "ro/" "cat3/" "it/" "pt/" "./" "cat7/" "zh_TW/" "sr/" "fr.ISO8859-1/" "hr/" "cat6/" "fi/" "ja/" "index.db" "cat1/" "cat2/" "cat5/" "cat8/" "vi/" "ko/" "nl/" "uk/" "sl/" "../" "zh_CN/" "id/" "hu/" "da/" "sv/" "es/" "fr.UTF-8/" "pt_BR/" "cs/" "pl/" "sk/" "cat4/" "fr/") -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 30 08:29:28 2021 Received: (at 49776) by debbugs.gnu.org; 30 Jul 2021 12:29:28 +0000 Received: from localhost ([127.0.0.1]:59311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9Rdo-0004Tn-23 for submit@debbugs.gnu.org; Fri, 30 Jul 2021 08:29:28 -0400 Received: from server.qxqx.de ([178.63.65.180]:53919 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9Rdm-0004TS-2E for 49776@debbugs.gnu.org; Fri, 30 Jul 2021 08:29:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fih3xhi/KWGvL565V/anJqxMXp7ABZK0J511Zd5Uly8=; b=YNJAhpOi6/gLnasbwHPbs2rL+T 8191MAQEopM66Z3IAXW7DCN5PAFlwaxjEktsht4TKWQ6ILUZ8CzbtiZJuuP2ez23/PEJgX7y7CX25 p4GZXg2AU1dr7skxz8M6NJuIrXssutIUR2poQZ9anM1YF+DSO+wvVRwyMUs/1uR1rry0=; Subject: Re: bug#49776: 28.0.50; Incorrect username completion results reported by `read-file-name-interal` To: Lars Ingebrigtsen References: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> <87bl6kowfo.fsf@gnus.org> From: Daniel Mendler Message-ID: <48dff852-4ba9-730f-54c9-6800dffe9e8f@daniel-mendler.de> Date: Fri, 30 Jul 2021 14:29:18 +0200 MIME-Version: 1.0 In-Reply-To: <87bl6kowfo.fsf@gnus.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49776 Cc: 49776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 7/30/21 1:47 PM, Lars Ingebrigtsen wrote: >> `(all-completions "~/.config/~man" #'read-file-name-internal)` returns >> the list `("/.config/~man")`. The file completion table incorrectly >> recognizes "/.config/~man" as the username instead of only "~man". > > I'm unable to reproduce this problem, and you haven't used `M-x > report-emacs-bug', so I don't know what system you're seeing this on. > I'm getting the expected on Debian/bullseye: > > (all-completions "~/.config/~man" #'read-file-name-internal) > => (#("/.config/~man/" 0 13 (face completions-common-part))) No, this is exactly the problem I meant (You reproduced it). "/.config/~man" is an invalid completion string. It is not a valid path nor a valid username on my system. The file completion table should not return invalid completion candidates. > And, of course: > > (all-completions "~/.config/~man/" #'read-file-name-internal) > => ("tr/" "zh/" "CACHEDIR.TAG" "de/" "ru/" "ro/" "cat3/" "it/" "pt/" "./" "cat7/" "zh_TW/" "sr/" "fr.ISO8859-1/" "hr/" "cat6/" "fi/" "ja/" "index.db" "cat1/" "cat2/" "cat5/" "cat8/" "vi/" "ko/" "nl/" "uk/" "sl/" "../" "zh_CN/" "id/" "hu/" "da/" "sv/" "es/" "fr.UTF-8/" "pt_BR/" "cs/" "pl/" "sk/" "cat4/" "fr/") Yes, of course. This works correctly and as expected. Daniel From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 30 08:45:48 2021 Received: (at 49776) by debbugs.gnu.org; 30 Jul 2021 12:45:48 +0000 Received: from localhost ([127.0.0.1]:59376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9Rtc-0005dB-Am for submit@debbugs.gnu.org; Fri, 30 Jul 2021 08:45:48 -0400 Received: from server.qxqx.de ([178.63.65.180]:34799 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9RtZ-0005Vu-J0; Fri, 30 Jul 2021 08:45:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8hiZgOdt+bHMlgpK06DviFQD+a3zM7X/vN0Lv7S0d4g=; b=MYPcAdXPTSQetko1WrgIq6TNyg C8haFGtERuIrf2h3t5URUAKMbRi4RqhSgJV0NFdDcjsP/F5sibG+ycIfTzuN/n811qFBwMtbStEC5 lU0ZFUnCIELZBgfdLLYVYsy5jjgZsqKCQqf/8CU0mGd/+SDPVwUT9+OEprN1SAS1N4nc=; Subject: Re: bug#49776: 28.0.50; Incorrect username completion results reported by `read-file-name-interal` To: 49776@debbugs.gnu.org, 49777@debbugs.gnu.org References: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> <87bl6kowfo.fsf@gnus.org> From: Daniel Mendler Message-ID: <411b546e-b7c3-77b7-3ea7-5941a1f8e485@daniel-mendler.de> Date: Fri, 30 Jul 2021 14:45:37 +0200 MIME-Version: 1.0 In-Reply-To: <87bl6kowfo.fsf@gnus.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49776 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) A few more examples for comparison: (all-completions "~/etc/~man" 'read-file-name-internal); /etc/~man/, bug (all-completions "~/etc/~foo" 'read-file-name-internal); nil, ok (all-completions "/etc/~man" 'read-file-name-internal); man/, ok (all-completions "/etc/~man/" 'read-file-name-internal); ~man files, ok (all-completions "~/etc/~man/" 'read-file-name-internal); ~man files, ok From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 30 08:50:16 2021 Received: (at 49776) by debbugs.gnu.org; 30 Jul 2021 12:50:16 +0000 Received: from localhost ([127.0.0.1]:59382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9Rxw-0007Em-0C for submit@debbugs.gnu.org; Fri, 30 Jul 2021 08:50:16 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9Rxu-0007EV-9y for 49776@debbugs.gnu.org; Fri, 30 Jul 2021 08:50:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OZ1aUb5evO0sXzEUs9sZtvZ2c6cJKc3cbBSSXkVTfTI=; b=PXIuJWDCK6/NVrtTlECK+w7mnH m3GRkGvnEPAkYGA+gPCsUDDKAF+zp+7Yke5qmaGFOC/S7LlWYhqCLB99TD+8V5W0aLsUVgecD74oU 92W75RCwZv6x59/+gczbo/agHU4GXX6h1SB/K2pce6lLd5BXTvzXl1rk3dzFlBOWocjI=; Received: from 2.149.45.105.tmi.telenormobil.no ([2.149.45.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9Rxl-0007Z1-Et; Fri, 30 Jul 2021 14:50:08 +0200 From: Lars Ingebrigtsen To: Daniel Mendler Subject: Re: bug#49776: 28.0.50; Incorrect username completion results reported by `read-file-name-interal` References: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> <87bl6kowfo.fsf@gnus.org> <48dff852-4ba9-730f-54c9-6800dffe9e8f@daniel-mendler.de> Date: Fri, 30 Jul 2021 14:50:03 +0200 In-Reply-To: <48dff852-4ba9-730f-54c9-6800dffe9e8f@daniel-mendler.de> (Daniel Mendler's message of "Fri, 30 Jul 2021 14:29:18 +0200") Message-ID: <8735rwm0ec.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Daniel Mendler writes: > On 7/30/21 1:47 PM, Lars Ingebrigtsen wrote: >>> `(all-completions "~/.config/~man" #'read-file-name-internal)` returns >>> the list `("/.config/~man")`. The file completion table incorrectly >>> re [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49776 Cc: 49776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Daniel Mendler writes: > On 7/30/21 1:47 PM, Lars Ingebrigtsen wrote: >>> `(all-completions "~/.config/~man" #'read-file-name-internal)` returns >>> the list `("/.config/~man")`. The file completion table incorrectly >>> recognizes "/.config/~man" as the username instead of only "~man". >> >> I'm unable to reproduce this problem, and you haven't used `M-x >> report-emacs-bug', so I don't know what system you're seeing this on. >> I'm getting the expected on Debian/bullseye: >> >> (all-completions "~/.config/~man" #'read-file-name-internal) >> => (#("/.config/~man/" 0 13 (face completions-common-part))) > > No, this is exactly the problem I meant (You reproduced it). But you said it returned "/.config/~man" for you (while it returns "/.config/~man/" for me) (note trailing slash)... > "/.config/~man" is an invalid completion string. It is not a valid path > nor a valid username on my system. Oh, you don't have a user named "man" on your system? That explains why we're getting different results. And I'm unable to reproduce that here: (all-completions "~/.config/~notexist" #'read-file-name-internal) => nil So what kind of system are you on? > The file completion table should not return invalid completion > candidates. The confusing bit for me is why there's a "/" at the start of the returned value, to be honest. ".config/~man/" should be the correct value here, I think... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 30 09:12:48 2021 Received: (at 49776) by debbugs.gnu.org; 30 Jul 2021 13:12:48 +0000 Received: from localhost ([127.0.0.1]:59405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9SJk-0007mi-4r for submit@debbugs.gnu.org; Fri, 30 Jul 2021 09:12:48 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9SJi-0007mU-7G for 49776@debbugs.gnu.org; Fri, 30 Jul 2021 09:12:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zobLsmx+KLf6nWNWff5TiBHMZ46oM4AadPcUccv651A=; b=lpeFVZhGB2mAQENJtBwJ7zL3Ky vLvNE45k1uSdkO26erB416hOuXdy+tz/W09rVdS8qDhtRgL9MKkfSdpDCklrGC56di/q1KKKxX1V1 VgWGS02hia6WHC/AK0dYGDpZ79ILz20/15RlG+MDUmIDllpncdc8NHyslkT21l+s5nkI=; Received: from 2.149.45.105.tmi.telenormobil.no ([2.149.45.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9SJZ-0007qf-5U; Fri, 30 Jul 2021 15:12:39 +0200 From: Lars Ingebrigtsen To: Daniel Mendler Subject: Re: bug#49776: 28.0.50; Incorrect username completion results reported by `read-file-name-interal` References: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> <87bl6kowfo.fsf@gnus.org> <48dff852-4ba9-730f-54c9-6800dffe9e8f@daniel-mendler.de> <8735rwm0ec.fsf@gnus.org> Date: Fri, 30 Jul 2021 15:12:35 +0200 In-Reply-To: <8735rwm0ec.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 30 Jul 2021 14:50:03 +0200") Message-ID: <87sfzwkksc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > (all-completions "~/.config/~notexist" #'read-file-name-internal) > => nil And note that this is the same as Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49776 Cc: 49776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > (all-completions "~/.config/~notexist" #'read-file-name-internal) > => nil And note that this is the same as (read-file-name-internal "~/.config/~notexist" nil t) => nil (read-file-name-internal "~/.config/~man" nil t) => (#("/.config/~man/" 0 13 (face completions-common-part))) and note that this is an internal function not to be used by users. So I don't see anything misbehaving here... What's the real problem you're seeing (when not using internal Emacs functions)? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 30 09:22:28 2021 Received: (at 49776) by debbugs.gnu.org; 30 Jul 2021 13:22:28 +0000 Received: from localhost ([127.0.0.1]:59419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9ST6-0001ko-GV for submit@debbugs.gnu.org; Fri, 30 Jul 2021 09:22:28 -0400 Received: from server.qxqx.de ([178.63.65.180]:54045 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9ST4-0001ka-CF for 49776@debbugs.gnu.org; Fri, 30 Jul 2021 09:22:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=H/FjDmypD3zFs54M2L5Use7b69M0P/imvJYdVPTlnsU=; b=RQwEXdY+UTbnFc5KPMtPQNsQZO hq1pQQmcz7YbO3Yun7azJ5sOpKn8WlX7L48FLKLWH+LHexE0ZIK6ZzfsusNkMQviDmIS4703RcCfK 5Tvl7CG+iuX7LCBEacYxW+yb+XUL+URpbyciUJ9Ar+sqnvIqChQUdyuxfhLyguiD6HGw=; Subject: Re: bug#49776: 28.0.50; Incorrect username completion results reported by `read-file-name-interal` To: Lars Ingebrigtsen References: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> <87bl6kowfo.fsf@gnus.org> <48dff852-4ba9-730f-54c9-6800dffe9e8f@daniel-mendler.de> <8735rwm0ec.fsf@gnus.org> From: Daniel Mendler Message-ID: <4bd7f6ed-5e65-af35-1952-501a45fce8f1@daniel-mendler.de> Date: Fri, 30 Jul 2021 15:22:18 +0200 MIME-Version: 1.0 In-Reply-To: <8735rwm0ec.fsf@gnus.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49776 Cc: 49776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 7/30/21 2:50 PM, Lars Ingebrigtsen wrote: > But you said it returned "/.config/~man" for you (while it returns > "/.config/~man/" for me) (note trailing slash)... Yes, this was a typo from my side, sorry for that. Please look at the other examples I've sent. So to describe this better: (all-completions "~/etc/~man" 'read-file-name-internal) returns ("/etc/~man/"). In contrast (all-completions "/usr/~man" 'read-file-name-internal) returns ("man/"). "/etc/~man/ is neither a valid user name nor a valid file path. I have the user "man" on my system of course (I am also on a recent Debian). So the problem here is that in to even call the completion table with "~/etc/~man", the completion boundary is placed such that the string behind the first "~" is completed. If I read Eli correctly, he says that this is the expected behavior, while I would have expected that the completion boundary is placed behind the second "~", such that the completion table does not return odd looking results like "/etc/~man". Furthermore the string before the first "~" can be considered shadowed. So maybe the problem here is not with the results returned by `all-completions` but rather with the completion boundaries. I think this needs further investigation from my side. Daniel From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 30 09:31:35 2021 Received: (at 49776) by debbugs.gnu.org; 30 Jul 2021 13:31:35 +0000 Received: from localhost ([127.0.0.1]:59435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9Sbv-0003Uh-0d for submit@debbugs.gnu.org; Fri, 30 Jul 2021 09:31:35 -0400 Received: from server.qxqx.de ([178.63.65.180]:40329 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9Sbs-0003Ms-LX for 49776@debbugs.gnu.org; Fri, 30 Jul 2021 09:31:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MeZKGb4lhiF8yZ7F3jENybTKWwn6QlWRNsVYXlfbhG0=; b=FTF0bD13y6OYBhidJKa382F6BT 0RBGYJ4/i5aE4r/TZBV8ZUVYmt8Cvw8nd7S4cu0fcjTfweroOJPSxKTaaCbmnlOFkZQLfOQBq2KrQ JHFYGuCjsfAXPoIClodtbdWtNTeoZQ+4POEUewlg7GBZk8vG8gp26kN5eWujd0lqjUaA=; Subject: Re: bug#49776: 28.0.50; Incorrect username completion results reported by `read-file-name-interal` To: Lars Ingebrigtsen References: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> <87bl6kowfo.fsf@gnus.org> <48dff852-4ba9-730f-54c9-6800dffe9e8f@daniel-mendler.de> <8735rwm0ec.fsf@gnus.org> <87sfzwkksc.fsf@gnus.org> From: Daniel Mendler Message-ID: <07e53ddd-92aa-435a-23e0-9b8030af9f5f@daniel-mendler.de> Date: Fri, 30 Jul 2021 15:31:23 +0200 MIME-Version: 1.0 In-Reply-To: <87sfzwkksc.fsf@gnus.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49776 Cc: 49776@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 7/30/21 3:12 PM, Lars Ingebrigtsen wrote: > Lars Ingebrigtsen writes: > >> (all-completions "~/.config/~notexist" #'read-file-name-internal) >> => nil > (read-file-name-internal "~/.config/~notexist" nil t) > => nil Yes, this is what I expect. I see the same. > (read-file-name-internal "~/.config/~man" nil t) > => (#("/.config/~man/" 0 13 (face completions-common-part))) I see this too and it may be correct behavior. But then I wonder why the completion boundaries are placed as they are. > and note that this is an internal function not to be used by users. I am not looking at this as a user. I am investigating odd completion results in my Vertico completion UI (on GNU ELPA), when completing file names. If you type "~/etc/~man", you see these odd candidates "/etc/~man", where "/etc/" is actually part of the shadowed path. So to say it differently, I don't expect the shadowed path to take part in the completion. Maybe Stefan can chime in here and explain some of the background. I've corresponded with him before a few times regarding how the completion machinery works internally. Daniel From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 30 13:19:11 2021 Received: (at 49776) by debbugs.gnu.org; 30 Jul 2021 17:19:11 +0000 Received: from localhost ([127.0.0.1]:60804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9WAA-0001ls-PC for submit@debbugs.gnu.org; Fri, 30 Jul 2021 13:19:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9WA8-0001lc-QD for 49776@debbugs.gnu.org; Fri, 30 Jul 2021 13:19:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=P4nCJfF5XIsEepA2b7f0KDG2/0b8dbo0i0mHCU4fYA4=; b=vEn63mYb34aI9iK/2rxhvVBh42 ulQw1Cn43TcVPXXlctsmEMaP6RutPHUdFNI5Gq7a/VoLAf+1yCXPz74rNMq7t8i/QYNc/hMEf1r3R BsB8IfAhVu/1+DrlqORnIse4ouWbgsrAEv9HzIM+eVJrvcCMNMKjms0N2lOJqxMVQEw8=; Received: from 2.149.45.105.tmi.telenormobil.no ([2.149.45.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9W9y-0001og-Az; Fri, 30 Jul 2021 19:19:01 +0200 From: Lars Ingebrigtsen To: Daniel Mendler Subject: Re: bug#49776: 28.0.50; Incorrect username completion results reported by `read-file-name-interal` References: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> <87bl6kowfo.fsf@gnus.org> <48dff852-4ba9-730f-54c9-6800dffe9e8f@daniel-mendler.de> <8735rwm0ec.fsf@gnus.org> <87sfzwkksc.fsf@gnus.org> <07e53ddd-92aa-435a-23e0-9b8030af9f5f@daniel-mendler.de> Date: Fri, 30 Jul 2021 19:18:53 +0200 In-Reply-To: <07e53ddd-92aa-435a-23e0-9b8030af9f5f@daniel-mendler.de> (Daniel Mendler's message of "Fri, 30 Jul 2021 15:31:23 +0200") Message-ID: <87a6m3lnya.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Daniel Mendler writes: > I am not looking at this as a user. I am investigating odd completion > results in my Vertico completion UI (on GNU ELPA), when completing file > names. If you type "~/etc/~man", you see these odd c [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49776 Cc: 49776@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Daniel Mendler writes: > I am not looking at this as a user. I am investigating odd completion > results in my Vertico completion UI (on GNU ELPA), when completing file > names. If you type "~/etc/~man", you see these odd candidates > "/etc/~man", where "/etc/" is actually part of the shadowed path. So to > say it differently, I don't expect the shadowed path to take part in the > completion. Ah, right. > Maybe Stefan can chime in here and explain some of the background. I've > corresponded with him before a few times regarding how the completion > machinery works internally. Right. Stefan, in short -- the thing we're wondering is whether this is correct: (read-file-name-internal "~/foo/~man" nil t) => (#("/foo/~man/" 0 9 (face completions-common-part))) (read-file-name-internal "./foo/~man" nil t) => (#("man/" 0 3 (face completions-common-part))) I'd kinda expect both to give the same result (i.e., the latter result)? (And "man" is a valid user in this scenario.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 30 17:45:33 2021 Received: (at 49776) by debbugs.gnu.org; 30 Jul 2021 21:45:33 +0000 Received: from localhost ([127.0.0.1]:32867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9aJw-0002C4-Oi for submit@debbugs.gnu.org; Fri, 30 Jul 2021 17:45:33 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9aJu-0002Br-LY for 49776@debbugs.gnu.org; Fri, 30 Jul 2021 17:45:31 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 70663441240; Fri, 30 Jul 2021 17:45:24 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1E82F44122E; Fri, 30 Jul 2021 17:45:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1627681523; bh=a0nTVViKFwIokh9K08tdcih2T2uuJXbvVa8zBXKFAZs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aPpmt3LQGEx3FqRaAvdByc/uPnZ0ImDTP4oSBdgmJ2dAKJ98waOviZUBJWf2U6HPG QNTAycheX77/v+tbuPm6xWzKBbJNkhQppZK9zxb2rHi8XLD22W1BANAFdxIRipA5rV /DEkR5E5epeJkmk9Ux8vUc34GsJYco396KGb0vySbClGYuYM6jLzjkN+iqiIs/aX0S rbnYPGPrO6aFhqENGDeVgBCKj/w8pGHNRRQRtJKb8XlJTCBclWgUPmukviGJJL9Mah KOe+f8iwlcQStB5i3TWS3x1XqpuZ2jer9F+40BcYhg0RzaihpygLr6imnsmqqAnkwD dJXNel8KHjZcQ== Received: from alfajor (unknown [216.154.29.138]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DE5B91202E4; Fri, 30 Jul 2021 17:45:22 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#49776: 28.0.50; Incorrect username completion results reported by `read-file-name-interal` Message-ID: References: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> <87bl6kowfo.fsf@gnus.org> <48dff852-4ba9-730f-54c9-6800dffe9e8f@daniel-mendler.de> <8735rwm0ec.fsf@gnus.org> <87sfzwkksc.fsf@gnus.org> <07e53ddd-92aa-435a-23e0-9b8030af9f5f@daniel-mendler.de> <87a6m3lnya.fsf@gnus.org> Date: Fri, 30 Jul 2021 17:45:22 -0400 In-Reply-To: <87a6m3lnya.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 30 Jul 2021 19:18:53 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.093 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49776 Cc: Daniel Mendler , 49776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2021-07-30 19:18:53] wrote: > Daniel Mendler writes: >> I am not looking at this as a user. I am investigating odd completion >> results in my Vertico completion UI (on GNU ELPA), when completing file >> names. If you type "~/etc/~man", you see these odd candidates >> "/etc/~man", where "/etc/" is actually part of the shadowed path. So to >> say it differently, I don't expect the shadowed path to take part in the >> completion. > > Ah, right. > >> Maybe Stefan can chime in here and explain some of the background. I've >> corresponded with him before a few times regarding how the completion >> machinery works internally. > > Right. Stefan, in short -- the thing we're wondering is whether this is > correct: > > (read-file-name-internal "~/foo/~man" nil t) > => (#("/foo/~man/" 0 9 (face completions-common-part))) Yup,. that's wrong. > (read-file-name-internal "./foo/~man" nil t) > => (#("man/" 0 3 (face completions-common-part))) This one looks right. > I'd kinda expect both to give the same result (i.e., the latter result)? Agreed. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 31 08:07:52 2021 Received: (at 49776) by debbugs.gnu.org; 31 Jul 2021 12:07:53 +0000 Received: from localhost ([127.0.0.1]:33408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9nmS-000472-ME for submit@debbugs.gnu.org; Sat, 31 Jul 2021 08:07:52 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9nmQ-00046l-6e for 49776@debbugs.gnu.org; Sat, 31 Jul 2021 08:07:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zwiPU8O04SHz3sHWrhnDoC5IZGZ/xPTkHZWZU+ZeUEs=; b=Wubqk9umZgk0MkXBJglw02it4R P+bwutCBM+N/bvRzerATQDjuAlXSRAjfqCYvIuPwlJGRegVvyB0XinPDLINsiHsVq8aOX6DYHtgdB hE8FGNyIn2kGKDZBvQEF2+Q6VEyISa+K9Saj5HHYTXjD5X+T5C3AN10HzesrMSCzZsb8=; Received: from 2.149.45.105.tmi.telenormobil.no ([2.149.45.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9nmF-0003MP-TS; Sat, 31 Jul 2021 14:07:42 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#49776: 28.0.50; Incorrect username completion results reported by `read-file-name-interal` References: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> <87bl6kowfo.fsf@gnus.org> <48dff852-4ba9-730f-54c9-6800dffe9e8f@daniel-mendler.de> <8735rwm0ec.fsf@gnus.org> <87sfzwkksc.fsf@gnus.org> <07e53ddd-92aa-435a-23e0-9b8030af9f5f@daniel-mendler.de> <87a6m3lnya.fsf@gnus.org> Date: Sat, 31 Jul 2021 14:07:38 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 30 Jul 2021 17:45:22 -0400") Message-ID: <87k0l6it4l.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >> (read-file-name-internal "~/foo/~man" nil t) >> => (#("/foo/~man/" 0 9 (face completions-common-part))) > > Yup,. that's wrong. I'm completely unfamiliar with this code... Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49776 Cc: Daniel Mendler , 49776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >> (read-file-name-internal "~/foo/~man" nil t) >> => (#("/foo/~man/" 0 9 (face completions-common-part))) > > Yup,. that's wrong. I'm completely unfamiliar with this code... (defun completion-table-with-quoting (table unquote requote) ... (boundary (car (completion-boundaries ustring table pred ""))) (completions (completion--twq-all string ustring completions boundary unquote requote)) ustring here is "~man", and the boundary is 1, so completion--twq-all returns "/foo/~man" (because it stripped off 1 character at the start). But it should have stripped off "~/foo/~", I think? Somehow? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 02 07:57:54 2021 Received: (at 49776) by debbugs.gnu.org; 2 Aug 2021 11:57:54 +0000 Received: from localhost ([127.0.0.1]:37817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mAWZu-0007PA-FQ for submit@debbugs.gnu.org; Mon, 02 Aug 2021 07:57:54 -0400 Received: from server.qxqx.de ([178.63.65.180]:52327 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mAWZs-0007Ow-AK for 49776@debbugs.gnu.org; Mon, 02 Aug 2021 07:57:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Am4MOQzmeubMSc2M/jQctCMjzwqTiL/oov/sXBynbu8=; b=vAySfsNJmhqFddVVFftgEWKZOd snHwn74R9WqlErt3HzCNdfqDlo6LB1658r8WnHGkefUABKaFBQkV3TrYdAnGs2rlm+tc8h3JrvSmb BARMfrEJq6hz4cWJphOhX/jCfGYjdl5C+C7hoi91B2QMzdrmy80Ojo82REYFV/ecSUck=; Subject: Re: bug#49776: 28.0.50; Incorrect username completion results reported by `read-file-name-interal` To: Lars Ingebrigtsen , Stefan Monnier References: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> <87bl6kowfo.fsf@gnus.org> <48dff852-4ba9-730f-54c9-6800dffe9e8f@daniel-mendler.de> <8735rwm0ec.fsf@gnus.org> <87sfzwkksc.fsf@gnus.org> <07e53ddd-92aa-435a-23e0-9b8030af9f5f@daniel-mendler.de> <87a6m3lnya.fsf@gnus.org> <87k0l6it4l.fsf@gnus.org> From: Daniel Mendler Message-ID: <80d828d7-7ba5-a9a6-ea65-f5081f9fc1d6@daniel-mendler.de> Date: Mon, 2 Aug 2021 13:57:43 +0200 MIME-Version: 1.0 In-Reply-To: <87k0l6it4l.fsf@gnus.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49776 Cc: 49776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 7/31/21 2:07 PM, Lars Ingebrigtsen wrote: > ustring here is "~man", and the boundary is 1, so completion--twq-all > returns "/foo/~man" (because it stripped off 1 character at the start). > > But it should have stripped off "~/foo/~", I think? Somehow? Yes. I think the problem here is the wrong completion boundary. The completion boundary should be placed such that the shadowed path is not part of the completion. In this case the completion boundary should be behind the second "~". Daniel From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 04 02:13:26 2021 Received: (at 49776) by debbugs.gnu.org; 4 Aug 2021 06:13:26 +0000 Received: from localhost ([127.0.0.1]:42261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBA9e-0007Oh-0f for submit@debbugs.gnu.org; Wed, 04 Aug 2021 02:13:26 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBA9X-0007OM-2E for 49776@debbugs.gnu.org; Wed, 04 Aug 2021 02:13:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=R6p8/aUO3apWVlnubNl9OrZgR6SavJJby1s9XICy6YA=; b=FPDeyltFE9+0JjQruUHp9AcRHC gch26zjQ8WJiFCYPymHKGgOqPTc4nkdFJJcWi0UWdAXMGFVyVmejhiEu3VqrijwFNjV0OydIkR3Mq p96w8dXmSxSgN2BPG6jaBkCx1+KTpUcKDGDDdoX21GsSQURpzyOmrp/Qk1jqE8zgZrZw=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBA9M-0004En-ML; Wed, 04 Aug 2021 08:13:12 +0200 From: Lars Ingebrigtsen To: Daniel Mendler Subject: Re: bug#49776: 28.0.50; Incorrect username completion results reported by `read-file-name-interal` References: <82d07cfd-a345-bf79-0fd4-4386ce2fe381@daniel-mendler.de> <87bl6kowfo.fsf@gnus.org> <48dff852-4ba9-730f-54c9-6800dffe9e8f@daniel-mendler.de> <8735rwm0ec.fsf@gnus.org> <87sfzwkksc.fsf@gnus.org> <07e53ddd-92aa-435a-23e0-9b8030af9f5f@daniel-mendler.de> <87a6m3lnya.fsf@gnus.org> <87k0l6it4l.fsf@gnus.org> <80d828d7-7ba5-a9a6-ea65-f5081f9fc1d6@daniel-mendler.de> Date: Wed, 04 Aug 2021 08:13:08 +0200 In-Reply-To: <80d828d7-7ba5-a9a6-ea65-f5081f9fc1d6@daniel-mendler.de> (Daniel Mendler's message of "Mon, 2 Aug 2021 13:57:43 +0200") Message-ID: <87r1f9hh57.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Daniel Mendler writes: >> ustring here is "~man", and the boundary is 1, so completion--twq-all >> returns "/foo/~man" (because it stripped off 1 character at the start). >> >> But it should have stripped off "~/foo/~", I t [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49776 Cc: 49776@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Daniel Mendler writes: >> ustring here is "~man", and the boundary is 1, so completion--twq-all >> returns "/foo/~man" (because it stripped off 1 character at the start). >> >> But it should have stripped off "~/foo/~", I think? Somehow? > > Yes. I think the problem here is the wrong completion boundary. The > completion boundary should be placed such that the shadowed path is not > part of the completion. In this case the completion boundary should be > behind the second "~". Yup. But my understanding of the completion code is extremely limited, so hopefully somebody who understands it better can propose a fix... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no