GNU bug report logs - #49756
[PATCH][core-updates] build-system: asdf: Remove %build-inputs reference.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Othacehe <othacehe <at> gnu.org>
Subject: bug#49756: closed (Re: bug#49756: [PATCH][core-updates]
 build-system: asdf: Remove %build-inputs reference.)
Date: Thu, 29 Jul 2021 08:30:04 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#49756: [PATCH][core-updates] build-system: asdf: Remove %build-inputs reference.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 49756 <at> debbugs.gnu.org.

-- 
49756: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49756
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 49756-done <at> debbugs.gnu.org
Subject: Re: bug#49756: [PATCH][core-updates] build-system: asdf: Remove
 %build-inputs reference.
Date: Thu, 29 Jul 2021 10:29:44 +0200

Hey,

> Note that I left ‘%build-inputs’ in the “main” build systems, but
> semi-intentionally left it out in other build systems, the idea being
> that we should no longer need it now, and it was already rarely used.

I see, thanks for explaining!

Closing this one,

Mathieu

[Message part 3 (message/rfc822, inline)]

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Mathieu Othacehe <othacehe <at> gnu.org>
Subject: [PATCH][core-updates] build-system: asdf: Remove %build-inputs
 reference.
Date: Wed, 28 Jul 2021 16:13:26 +0200

This is a follow-up of 7d873f194ca69d6096d28d7a224ab78e83e34fe1 that removes
the %build-inputs variable.

* guix/build-system/asdf.scm (asdf-build): Remove %build-inputs reference.
---
Hello,

This fixes the asdf based builds on core-updates.

Thanks,

Mathieu

 guix/build-system/asdf.scm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/guix/build-system/asdf.scm b/guix/build-system/asdf.scm
index 79de2ee5ba..f4ad7252df 100644
--- a/guix/build-system/asdf.scm
+++ b/guix/build-system/asdf.scm
@@ -28,7 +28,8 @@
   #:use-module (guix search-paths)
   #:use-module ((guix build utils)
                 #:select ((package-name->name+version
-                           . hyphen-separated-name->name+version)))
+                           . hyphen-separated-name->name+version)
+                          search-input-file))
   #:use-module (guix build-system)
   #:use-module (guix build-system gnu)
   #:use-module (ice-9 match)
@@ -295,9 +296,9 @@ set up using CL source package conventions."
       (with-imported-modules imported-modules
         #~(begin
             (use-modules #$@(sexp->gexp modules))
-            (parameterize ((%lisp (string-append
-                                   (assoc-ref %build-inputs #$lisp-type)
-                                   "/bin/" #$lisp-type))
+            (parameterize ((%lisp (search-input-file
+                                   #$(input-tuples->gexp inputs)
+                                   (string-append "bin/" #$lisp-type)))
                            (%lisp-type #$lisp-type))
               (asdf-build #:name #$name
                           #:source #+source
-- 
2.32.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.